From 28fcbaeb0c451fbc4e2c289de2ce1f29522239eb Mon Sep 17 00:00:00 2001 From: Julien Desfossez Date: Wed, 12 Jun 2013 14:59:05 -0400 Subject: [PATCH] Fix: overflow in uri_to_str_url Signed-off-by: Julien Desfossez Signed-off-by: David Goulet --- src/common/uri.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/uri.c b/src/common/uri.c index 4af94072c..4838372ee 100644 --- a/src/common/uri.c +++ b/src/common/uri.c @@ -194,13 +194,13 @@ int uri_to_str_url(struct lttng_uri *uri, char *dst, size_t size) if (uri->dtype == LTTNG_DST_PATH) { ipver = 0; addr = uri->dst.path; - (void) snprintf(proto, sizeof(proto) + 1, "file"); - (void) snprintf(port, sizeof(port) + 1, "%s", ""); + (void) snprintf(proto, sizeof(proto), "file"); + (void) snprintf(port, sizeof(port), "%s", ""); } else { ipver = (uri->dtype == LTTNG_DST_IPV4) ? 4 : 6; addr = (ipver == 4) ? uri->dst.ipv4 : uri->dst.ipv6; - (void) snprintf(proto, sizeof(proto) + 1, "net%d", ipver); - (void) snprintf(port, sizeof(port) + 1, ":%d", uri->port); + (void) snprintf(proto, sizeof(proto), "net%d", ipver); + (void) snprintf(port, sizeof(port), ":%d", uri->port); } ret = snprintf(dst, size, "%s://%s%s%s%s/%s", proto, -- 2.34.1