From 157b2d445425611ab8ada02e34204cd9134c2acc Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Tue, 17 Jan 2017 10:07:31 -0500 Subject: [PATCH] x is never reused, no need to shift it MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Also remove noise in scanbuild report. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau --- src/bin/lttng-sessiond/ust-metadata.c | 1 - src/common/compat/string.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/bin/lttng-sessiond/ust-metadata.c b/src/bin/lttng-sessiond/ust-metadata.c index c1a80c746..fb1f11521 100644 --- a/src/bin/lttng-sessiond/ust-metadata.c +++ b/src/bin/lttng-sessiond/ust-metadata.c @@ -74,7 +74,6 @@ int fls(unsigned int x) r -= 2; } if (!(x & 0x80000000U)) { - x <<= 1; r -= 1; } return r; diff --git a/src/common/compat/string.h b/src/common/compat/string.h index 7c426ef3d..db3db8052 100644 --- a/src/common/compat/string.h +++ b/src/common/compat/string.h @@ -117,7 +117,6 @@ static inline int lttng_fls(int val) r -= 2; } if (!(x & 0x80000000U)) { - x <<= 1; r -= 1; } return r; -- 2.34.1