From 03ea8167a703a8a81224ed8753072551ee12b625 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Tue, 17 May 2016 09:23:50 -0400 Subject: [PATCH 1/1] Fix: Wrong sizeof argument in pid tracker MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Found by Coverity: CID 1292557 (#1 of 1): Wrong sizeof argument (SIZEOF_MISMATCH)suspicious_sizeof: Passing argument 8UL /* sizeof (*_pid_list) */ to function zmalloc and then casting the return value to int * is suspicious. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- src/bin/lttng/commands/track-untrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng/commands/track-untrack.c b/src/bin/lttng/commands/track-untrack.c index 3771de5d9..d9e18c1d6 100644 --- a/src/bin/lttng/commands/track-untrack.c +++ b/src/bin/lttng/commands/track-untrack.c @@ -87,7 +87,7 @@ int parse_pid_string(const char *_pid_string, goto error; } if (all) { - pid_list = zmalloc(sizeof(*_pid_list)); + pid_list = zmalloc(sizeof(*pid_list)); if (!pid_list) { ERR("Out of memory"); retval = CMD_ERROR; -- 2.34.1