lttng-tools.git
10 years agoCleanup trace ust destroy functions
David Goulet [Mon, 14 Nov 2011 19:41:48 +0000 (14:41 -0500)] 
Cleanup trace ust destroy functions

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Mon, 14 Nov 2011 17:11:17 +0000 (12:11 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

10 years agoAdd cleanup function for UST app
David Goulet [Mon, 14 Nov 2011 17:09:51 +0000 (12:09 -0500)] 
Add cleanup function for UST app

Also, those functions uses the new ustctl_release_object function from
the UST API.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoChange malloc to zmalloc on UST metadata creation
David Goulet [Mon, 14 Nov 2011 17:09:31 +0000 (12:09 -0500)] 
Change malloc to zmalloc on UST metadata creation

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd hashtable destroy
David Goulet [Mon, 14 Nov 2011 17:08:29 +0000 (12:08 -0500)] 
Add hashtable destroy

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix possible NULL UST session on start trace
David Goulet [Mon, 14 Nov 2011 17:08:00 +0000 (12:08 -0500)] 
Fix possible NULL UST session on start trace

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix indentation
David Goulet [Mon, 14 Nov 2011 15:26:37 +0000 (10:26 -0500)] 
Fix indentation

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agosessiond: don't link on lttng-ust-comm anymore
Mathieu Desnoyers [Mon, 14 Nov 2011 16:03:48 +0000 (11:03 -0500)] 
sessiond: don't link on lttng-ust-comm anymore

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix incorrect POPT_ARG_STRING usage
Mathieu Desnoyers [Mon, 14 Nov 2011 14:40:48 +0000 (09:40 -0500)] 
Fix incorrect POPT_ARG_STRING usage

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agolttng enable-events: fix argument parsing
Mathieu Desnoyers [Mon, 14 Nov 2011 14:31:22 +0000 (09:31 -0500)] 
lttng enable-events: fix argument parsing

We should only specify one of arg expected is a string/opt string _or_
that the callback needs to read it, but not both.

Causes some arguments to be skipped with some libpopt versions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix debug message channel vs session name mixup
Mathieu Desnoyers [Mon, 14 Nov 2011 13:46:16 +0000 (08:46 -0500)] 
Fix debug message channel vs session name mixup

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRemove leftover debug message
Mathieu Desnoyers [Sun, 13 Nov 2011 21:11:02 +0000 (16:11 -0500)] 
Remove leftover debug message

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoadd_ustctx_all_channels: Move rcu_read_unlock in error label
Mathieu Desnoyers [Sun, 13 Nov 2011 17:28:43 +0000 (12:28 -0500)] 
add_ustctx_all_channels: Move rcu_read_unlock in error label

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoust_app_find_by_pid: move rcu_read_unlock to error label
Mathieu Desnoyers [Sun, 13 Nov 2011 17:21:06 +0000 (12:21 -0500)] 
ust_app_find_by_pid: move rcu_read_unlock to error label

Less error-prone than read unlock within the code, as proven by commit
1e3a10e37a519046fd49c77f2fa23807b132f330.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agosessiond find_app_by_sock: remove double-rcu-unlock in from error paths
Mathieu Desnoyers [Sun, 13 Nov 2011 17:17:57 +0000 (12:17 -0500)] 
sessiond find_app_by_sock: remove double-rcu-unlock in from error paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agosessiond trace-ust: fix memleak on error paths
Mathieu Desnoyers [Sun, 13 Nov 2011 17:16:22 +0000 (12:16 -0500)] 
sessiond trace-ust: fix memleak on error paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agolttng UI: read opt_cmd_name opt arg for each command
Mathieu Desnoyers [Sun, 13 Nov 2011 17:12:12 +0000 (12:12 -0500)] 
lttng UI: read opt_cmd_name opt arg for each command

Ensure all commands are layed out in the same way too.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoLTTng sessiond: fix ust app error handling
Mathieu Desnoyers [Sat, 12 Nov 2011 17:56:50 +0000 (12:56 -0500)] 
LTTng sessiond: fix ust app error handling

Fix incorrect error handling of ust_app_add_channel_all and
ust_app_add_event_all commands. Make ust_app_start_trace take RCU
read-side lock, because this API is exposed outside of ust-app.c.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix link to git repository
Michal Simek [Fri, 11 Nov 2011 16:53:10 +0000 (11:53 -0500)] 
Fix link to git repository

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix NULL dereference in liblttngctl
David Goulet [Thu, 10 Nov 2011 20:16:51 +0000 (15:16 -0500)] 
Fix NULL dereference in liblttngctl

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Thu, 10 Nov 2011 20:10:42 +0000 (15:10 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

10 years agoAdd tracepoint listing for UST
David Goulet [Thu, 10 Nov 2011 20:10:35 +0000 (15:10 -0500)] 
Add tracepoint listing for UST

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix not NULL pointer on size 0
David Goulet [Thu, 10 Nov 2011 20:07:48 +0000 (15:07 -0500)] 
Fix not NULL pointer on size 0

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate from upstream for ht macros
David Goulet [Thu, 10 Nov 2011 20:07:13 +0000 (15:07 -0500)] 
Update from upstream for ht macros

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUST support: send commands to app before register done
Mathieu Desnoyers [Thu, 10 Nov 2011 18:11:54 +0000 (13:11 -0500)] 
UST support: send commands to app before register done

Required for handling of short-lived applications.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix ust consumer channel memory non-zeroed allocation
Mathieu Desnoyers [Wed, 9 Nov 2011 16:09:39 +0000 (11:09 -0500)] 
Fix ust consumer channel memory non-zeroed allocation

The cpu count was expecting memory to be zeroed on allocation. Caused
stream open errors and zero-sized metadata files (and unability to open
channel files).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUpdate ust-abi/ust-ctl header copies
Mathieu Desnoyers [Wed, 9 Nov 2011 15:37:41 +0000 (10:37 -0500)] 
Update ust-abi/ust-ctl header copies

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCleanup ust-app.c and make it more modular
David Goulet [Tue, 8 Nov 2011 23:08:00 +0000 (18:08 -0500)] 
Cleanup ust-app.c and make it more modular

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix possible NULL pointer dereference
David Goulet [Tue, 8 Nov 2011 19:30:20 +0000 (14:30 -0500)] 
Fix possible NULL pointer dereference

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix wrong pathname creation for UST metadata
David Goulet [Tue, 8 Nov 2011 18:22:40 +0000 (13:22 -0500)] 
Fix wrong pathname creation for UST metadata

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix directory creation of UST traces
David Goulet [Tue, 8 Nov 2011 18:14:22 +0000 (13:14 -0500)] 
Fix directory creation of UST traces

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix useless context hashtable size and segfault on destroy
David Goulet [Tue, 8 Nov 2011 17:28:34 +0000 (12:28 -0500)] 
Fix useless context hashtable size and segfault on destroy

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd auto start UST trace support
David Goulet [Tue, 8 Nov 2011 17:07:07 +0000 (12:07 -0500)] 
Add auto start UST trace support

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUST consumer: perform buffer flush on hang up
Mathieu Desnoyers [Tue, 8 Nov 2011 14:42:17 +0000 (09:42 -0500)] 
UST consumer: perform buffer flush on hang up

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix wrong returned valu on UST start trace
David Goulet [Mon, 7 Nov 2011 21:38:04 +0000 (16:38 -0500)] 
Fix wrong returned valu on UST start trace

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix build system for urcu wfqueue
David Goulet [Mon, 7 Nov 2011 21:27:00 +0000 (16:27 -0500)] 
Fix build system for urcu wfqueue

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAuto creation of chan/event on apps registration
David Goulet [Mon, 7 Nov 2011 21:21:22 +0000 (16:21 -0500)] 
Auto creation of chan/event on apps registration

On UST apps registration, all channel(s) and event(s) from the UST
global domain are created on the apps.

Adds a new check for urcu wait-free queue in configure.ac

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd missing function references with no UST support
David Goulet [Mon, 7 Nov 2011 17:07:34 +0000 (12:07 -0500)] 
Add missing function references with no UST support

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix incorrect parenthesis for poll test in consumer
Mathieu Desnoyers [Sat, 5 Nov 2011 17:57:01 +0000 (13:57 -0400)] 
Fix incorrect parenthesis for poll test in consumer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUST consumer: implement missing ust-specific callbacks + fixes.
Mathieu Desnoyers [Sat, 5 Nov 2011 17:45:35 +0000 (13:45 -0400)] 
UST consumer: implement missing ust-specific callbacks + fixes.

Also fix consumer handling of poll fd: a mask should be used.
Also fix UST stream output passed to the consumer (the fix is a hack
currently, left a FIXME).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd missing rcu_read_unlock on error paths
Mathieu Desnoyers [Sat, 5 Nov 2011 15:31:24 +0000 (11:31 -0400)] 
Add missing rcu_read_unlock on error paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix order of streams
Mathieu Desnoyers [Sat, 5 Nov 2011 15:27:53 +0000 (11:27 -0400)] 
Fix order of streams

Use a list instead of hash table to send streams in correct order.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUST consumer interaction fix: send all channel streams
Mathieu Desnoyers [Fri, 4 Nov 2011 12:31:56 +0000 (08:31 -0400)] 
UST consumer interaction fix: send all channel streams

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoLTTng-UST support: --disable-lttng-ust build option
Mathieu Desnoyers [Fri, 4 Nov 2011 11:32:26 +0000 (07:32 -0400)] 
LTTng-UST support: --disable-lttng-ust build option

From now on, configure fails if lttng-ust is not found.
--disable-lttng-ust must be explicitely specified to build without UST
support.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoust consumer: flag shm/wait fd as copy
Mathieu Desnoyers [Thu, 3 Nov 2011 23:33:24 +0000 (19:33 -0400)] 
ust consumer: flag shm/wait fd as copy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoust consumer: fix double close
Mathieu Desnoyers [Thu, 3 Nov 2011 23:18:51 +0000 (19:18 -0400)] 
ust consumer: fix double close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoconsumer handling fix: send metadata channel shm size
Mathieu Desnoyers [Thu, 3 Nov 2011 19:18:04 +0000 (15:18 -0400)] 
consumer handling fix: send metadata channel shm size

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix UST consumer FD send: channels only send one FD
Mathieu Desnoyers [Thu, 3 Nov 2011 19:01:43 +0000 (15:01 -0400)] 
Fix UST consumer FD send: channels only send one FD

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix debug message in send consumer fd.
Mathieu Desnoyers [Thu, 3 Nov 2011 18:52:01 +0000 (14:52 -0400)] 
Fix debug message in send consumer fd.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRemove *bad* debug printf
David Goulet [Thu, 3 Nov 2011 18:26:26 +0000 (14:26 -0400)] 
Remove *bad* debug printf

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoChange linking libs using new UST names
David Goulet [Thu, 3 Nov 2011 17:19:06 +0000 (13:19 -0400)] 
Change linking libs using new UST names

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix configure.ac using new UST headers location
David Goulet [Thu, 3 Nov 2011 17:09:22 +0000 (13:09 -0400)] 
Fix configure.ac using new UST headers location

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoChange UST header location and update in tree headers
David Goulet [Thu, 3 Nov 2011 16:55:11 +0000 (12:55 -0400)] 
Change UST header location and update in tree headers

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoSupport urcu 0.6.6 with the likely/unlikely API change
David Goulet [Thu, 3 Nov 2011 15:59:02 +0000 (11:59 -0400)] 
Support urcu 0.6.6 with the likely/unlikely API change

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRename ltt-sessiond to lttng-sessiond
David Goulet [Thu, 3 Nov 2011 15:34:59 +0000 (11:34 -0400)] 
Rename ltt-sessiond to lttng-sessiond

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix UST renaming and update ust headers
David Goulet [Thu, 3 Nov 2011 15:06:40 +0000 (11:06 -0400)] 
Fix UST renaming and update ust headers

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate README and TODO
David Goulet [Thu, 3 Nov 2011 15:00:50 +0000 (11:00 -0400)] 
Update README and TODO

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix build system with libustcomm removed
David Goulet [Thu, 3 Nov 2011 14:13:01 +0000 (10:13 -0400)] 
Fix build system with libustcomm removed

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRemove unused and empty lib
David Goulet [Thu, 3 Nov 2011 14:01:17 +0000 (10:01 -0400)] 
Remove unused and empty lib

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoltt-sessiond: use short options for modprobe in order to support Busybox
Thomas Petazzoni [Thu, 3 Nov 2011 11:51:21 +0000 (12:51 +0100)] 
ltt-sessiond: use short options for modprobe in order to support Busybox

Many embedded systems are based on Busybox, and therefore use the
Busybox implementation of modprobe. This implementation does not
support long options such as --remove and --quiet, only short options
such as -r and -q are supported.

This patches changes ltt-sessiond to use the short options, which are
more widely available, and allows lttng to work easily on a
Busybox-based system.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
10 years agoPreliminary work for full UST support
David Goulet [Wed, 2 Nov 2011 19:44:27 +0000 (15:44 -0400)] 
Preliminary work for full UST support

Add hashtable support for all UST data structure. At this point, enable
channel and event works with the global UST domain. The interaction with
the ust consumer has problems for now thus not working at this stage.

NOTICE: This commit does NOT work with the user space tracer yet. Please
refer to next commit for working version.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate RCU hashtable from upstream urcu
David Goulet [Wed, 2 Nov 2011 19:43:50 +0000 (15:43 -0400)] 
Update RCU hashtable from upstream urcu

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoImport hashtable files from URCU upstream git
David Goulet [Thu, 27 Oct 2011 12:50:45 +0000 (14:50 +0200)] 
Import hashtable files from URCU upstream git

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoBasic hashtable support for UST
David Goulet [Thu, 27 Oct 2011 12:49:48 +0000 (14:49 +0200)] 
Basic hashtable support for UST

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate documentation following babeltrace UI change
Mathieu Desnoyers [Wed, 2 Nov 2011 14:06:49 +0000 (10:06 -0400)] 
Update documentation following babeltrace UI change

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUST support: add UST control commands
Mathieu Desnoyers [Thu, 27 Oct 2011 12:33:28 +0000 (14:33 +0200)] 
UST support: add UST control commands

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix kconsumerd number of fd expected
Mathieu Desnoyers [Thu, 27 Oct 2011 12:02:40 +0000 (08:02 -0400)] 
Fix kconsumerd number of fd expected

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd lttng-consumerd to gitignore
David Goulet [Wed, 26 Oct 2011 11:50:16 +0000 (07:50 -0400)] 
Add lttng-consumerd to gitignore

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRemove unused variable
David Goulet [Wed, 26 Oct 2011 11:49:38 +0000 (07:49 -0400)] 
Remove unused variable

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAPI change for lttng_get_readeable_code
David Goulet [Tue, 25 Oct 2011 19:29:50 +0000 (15:29 -0400)] 
API change for lttng_get_readeable_code

The liblttngctl lttng_get_readeable_code call is renamed to
lttng_strerror.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix array size in kconsumer add stream
David Goulet [Tue, 25 Oct 2011 19:26:09 +0000 (15:26 -0400)] 
Fix array size in kconsumer add stream

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix inline function bad definition
David Goulet [Tue, 25 Oct 2011 19:25:11 +0000 (15:25 -0400)] 
Fix inline function bad definition

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUse UST comm lib
Mathieu Desnoyers [Sun, 23 Oct 2011 13:23:12 +0000 (09:23 -0400)] 
Use UST comm lib

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUpdate UST messages
Mathieu Desnoyers [Sun, 23 Oct 2011 12:50:13 +0000 (08:50 -0400)] 
Update UST messages

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUST 2.0 support
Mathieu Desnoyers [Sun, 23 Oct 2011 01:06:11 +0000 (21:06 -0400)] 
UST 2.0 support

Refactoring of the consumer/sessiond interaction so the consumer
supports applications instrumented with libust (UST 2.0).

At this point, more testing of interaction between libust and sessiond
is required.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix disable event
David Goulet [Wed, 5 Oct 2011 22:40:19 +0000 (18:40 -0400)] 
Fix disable event

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd EEXIST support for kernel event on the tracer side
David Goulet [Wed, 5 Oct 2011 22:20:34 +0000 (18:20 -0400)] 
Add EEXIST support for kernel event on the tracer side

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix bad channel handling on enable-event
David Goulet [Wed, 5 Oct 2011 22:09:23 +0000 (18:09 -0400)] 
Fix bad channel handling on enable-event

The channel attributes and name were not passed to the create function
when a channel is requested and did not exist on enable-event.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix comments in lttng-sessiond-comm code
David Goulet [Tue, 4 Oct 2011 21:53:16 +0000 (17:53 -0400)] 
Fix comments in lttng-sessiond-comm code

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd recv fds function to lttng-comm API
David Goulet [Tue, 4 Oct 2011 21:49:27 +0000 (17:49 -0400)] 
Add recv fds function to lttng-comm API

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd missing mutex lock for kconsumerd pid
David Goulet [Tue, 4 Oct 2011 21:27:50 +0000 (17:27 -0400)] 
Add missing mutex lock for kconsumerd pid

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd sem_wait timeout on the kconsumerd thread
David Goulet [Tue, 4 Oct 2011 21:15:32 +0000 (17:15 -0400)] 
Add sem_wait timeout on the kconsumerd thread

It's unlikely to happen but is the kconsumerd was not able to send us
the sock ready command, at least the session daemon will not stall
forever. A 30 seconds timeout is added and error is handle after that.

Also adds the handling of the sem_init ret value and adds mutex lock
around the kconsumerd pid in the same function.

There was also a problem on error code handling where LTTCOMM error was
returned by spawn kconsumerd function but handled as if it might be
negative at the end of the call chain. This was preventing to return the
right error code to the client when the kconsumerd failed.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRemove session list lock acquisition of the search
David Goulet [Tue, 4 Oct 2011 20:24:10 +0000 (16:24 -0400)] 
Remove session list lock acquisition of the search

The lock/unlock of the session list in the find session by name function
is removed thus the caller must held the lock before calling that search
function.

Also, the path and name are now static size on the stack and not
allocated strings at session creation.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix possible use of uninitialized variable
David Goulet [Tue, 4 Oct 2011 14:54:05 +0000 (10:54 -0400)] 
Fix possible use of uninitialized variable

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix session list deadlock
David Goulet [Mon, 3 Oct 2011 19:23:16 +0000 (15:23 -0400)] 
Fix session list deadlock

On session destroy, the session list lock is acquired but this call
could be made inside a section where this lock is already acquired. The
call has been changed to using the session pointer and not the name thus
removing a useless list walk.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix enable syscall and bad value of poll set size
David Goulet [Mon, 3 Oct 2011 18:46:40 +0000 (14:46 -0400)] 
Fix enable syscall and bad value of poll set size

First, when enabling syscall tracing, on success 0 is return so we don't
add this value to the event list or else we were polling on fd 0 which
is not a valid event fd. A normal kernel create event, the fd of that
event is returned from the ioctl which is not the case for syscalls.

Second, the poll size was not reset when updating the kernel poll set so
at each kernel poll update, the value was not coherent with the real
poll size and thus creating unstable behavior (unknown).

This commit MIGHT fix a blocking problem happening when using a custom
channel and enabling syscall on it. This issue was reported by Julien
Desfossez <julien.desfossez@polymtl.ca>.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoDon't report an error when the last section of the path exist in mkdir_recursive
Yannick Brosseau [Mon, 19 Sep 2011 21:17:56 +0000 (17:17 -0400)] 
Don't report an error when the last section of the path exist in mkdir_recursive

Minor adjustment for perror call changed to PERROR using the lttngerr.h
interface.

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoVersion 2.0-pre14 v2.0-pre14
Mathieu Desnoyers [Fri, 30 Sep 2011 15:32:22 +0000 (11:32 -0400)] 
Version 2.0-pre14

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoImplement enable all vs enable tracepoints vs enable syscalls
Mathieu Desnoyers [Fri, 30 Sep 2011 15:23:32 +0000 (11:23 -0400)] 
Implement enable all vs enable tracepoints vs enable syscalls

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUpdate documentation for enable all events
Mathieu Desnoyers [Fri, 30 Sep 2011 13:58:50 +0000 (09:58 -0400)] 
Update documentation for enable all events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoEnable all events command enable also syscalls
David Goulet [Fri, 30 Sep 2011 13:42:10 +0000 (09:42 -0400)] 
Enable all events command enable also syscalls

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd liburcu function check to build system
David Goulet [Thu, 29 Sep 2011 20:24:16 +0000 (16:24 -0400)] 
Add liburcu function check to build system

rcu_thread_online and rcu_thread_offline are needed and only available
on urcu version >= 0.6.5

Reported-by: Yannick Brosseau <yannick.brosseau@polymtl.ca>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoWrite debug message on stderr
David Goulet [Thu, 29 Sep 2011 17:16:55 +0000 (13:16 -0400)] 
Write debug message on stderr

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix epoll not handling signal interruption
David Goulet [Thu, 29 Sep 2011 16:10:36 +0000 (12:10 -0400)] 
Fix epoll not handling signal interruption

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRename traceable-app and change ust app call
David Goulet [Tue, 27 Sep 2011 14:06:42 +0000 (10:06 -0400)] 
Rename traceable-app and change ust app call

Rename traceable-app to ust-app.c/.h and all calls to ust_app_* to be
consistent with the code base.

Add a channel_ust_copy() to copy UST channel and event list. Mostly used
for channel copy between ust session and ust app.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate quickstart, describing syscall events
Mathieu Desnoyers [Tue, 27 Sep 2011 14:07:42 +0000 (10:07 -0400)] 
Update quickstart, describing syscall events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoltt-kconsumerd: Fix incorrect typing
Mathieu Desnoyers [Tue, 27 Sep 2011 13:30:49 +0000 (09:30 -0400)] 
ltt-kconsumerd: Fix incorrect typing

ltt-kconsumerd.c: In function ‘on_recv_fd’:
ltt-kconsumerd.c:298: warning: passing argument 2 of
‘kernctl_get_mmap_len’ from incompatible pointer type
../include/lttng-kernel-ctl.h:47: note: expected ‘long unsigned int *’
but argument is of type ‘size_t *’

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd enable channel support for UST
David Goulet [Mon, 26 Sep 2011 22:33:16 +0000 (18:33 -0400)] 
Add enable channel support for UST

Also improve data structure for UST session control to fit new model
where we will have a list of lttng domain to indentify the ust session.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix UST define in global headers
David Goulet [Mon, 26 Sep 2011 22:32:45 +0000 (18:32 -0400)] 
Fix UST define in global headers

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate UST ABI and add UST some error message
David Goulet [Mon, 26 Sep 2011 22:30:54 +0000 (18:30 -0400)] 
Update UST ABI and add UST some error message

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
This page took 0.05897 seconds and 4 git commands to generate.