lttng-tools.git
8 years agoFix: set full path in .gitignore
David Goulet [Mon, 24 Mar 2014 19:55:59 +0000 (15:55 -0400)] 
Fix: set full path in .gitignore

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: use NULL url for load live session
David Goulet [Mon, 24 Mar 2014 19:52:31 +0000 (15:52 -0400)] 
Fix: use NULL url for load live session

For a live session, the control and data URI are mandatory thus pass
NULL to the create session so we can set them afterwards by a set
consumer URL call.

net:// can't be used for control and data so this fixes the uri to url
string by printing "tcp://" instead of net:// which is more accurate and
the good way to actually print the URL to the user.

Fixes #767

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: allow empty URL for live session creation
David Goulet [Mon, 24 Mar 2014 18:23:00 +0000 (14:23 -0400)] 
Fix: allow empty URL for live session creation

This is actually very important so -C/-D can be used with lttng create
--live command and also the load command can set the control and data
URL independently.

This also adds a small test to make sure -C/-D works in live mode.

Fixes #769

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing valid return code when adding an URI to consumer
David Goulet [Mon, 24 Mar 2014 18:22:34 +0000 (14:22 -0400)] 
Fix: missing valid return code when adding an URI to consumer

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: clarify sessiond ust app queue cmd comment
David Goulet [Thu, 20 Mar 2014 19:06:30 +0000 (15:06 -0400)] 
Fix: clarify sessiond ust app queue cmd comment

Reported-by: Daniel Thibault <Daniel.Thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: use uri API to parse url for save command
David Goulet [Wed, 19 Mar 2014 20:19:49 +0000 (16:19 -0400)] 
Fix: use uri API to parse url for save command

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Succesful session load might still report an error
Jérémie Galarneau [Wed, 19 Mar 2014 15:29:18 +0000 (11:29 -0400)] 
Fix: Succesful session load might still report an error

This ensures that the load command reports a successful load when
the session is found in the user's home session configuration
directory and not in the system-wide session configuration directory.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Pass session name to config_load_session when no path is provided
Jérémie Galarneau [Wed, 19 Mar 2014 15:28:52 +0000 (11:28 -0400)] 
Fix: Pass session name to config_load_session when no path is provided

Fixes #756

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Remove overly restrictive asserts in create_session()
Jérémie Galarneau [Wed, 19 Mar 2014 15:25:26 +0000 (11:25 -0400)] 
Fix: Remove overly restrictive asserts in create_session()

The current assertions only allow sessions containing all three
domain types to be created. The pointers are already checked at
ln 1242.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: syntax error in lttng.1
Michael Jeanson [Sat, 15 Mar 2014 17:55:11 +0000 (13:55 -0400)] 
Fix: syntax error in lttng.1

Signed-off-by: Michael Jeanson <mjeanson@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: rename config internal header to abi
David Goulet [Mon, 17 Mar 2014 15:33:10 +0000 (11:33 -0400)] 
Fix: rename config internal header to abi

Allow config ABI to be visible to the internal code.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add error/msg output to save command
David Goulet [Wed, 12 Mar 2014 21:08:32 +0000 (17:08 -0400)] 
Fix: add error/msg output to save command

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing string msg for save/load error code
David Goulet [Wed, 12 Mar 2014 20:50:48 +0000 (16:50 -0400)] 
Fix: add missing string msg for save/load error code

Also, the LTTNG_ERR_LOAD_SESSION_NOT_FOUND has been removed and replaced
by LTTNG_ERR_LOAD_SESSION_NOENT.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: return error if not in overwrite mode and file exists
David Goulet [Wed, 12 Mar 2014 20:41:43 +0000 (16:41 -0400)] 
Fix: return error if not in overwrite mode and file exists

For the save command, if the file is found and we are not in overwrite
mode, send back an new error indicating the client that the file already
exists.

Fixes #762

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing memset 0 and NULL byte in string
David Goulet [Wed, 12 Mar 2014 20:31:32 +0000 (16:31 -0400)] 
Fix: missing memset 0 and NULL byte in string

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: check relayd fd leak in lttng cmdline
David Goulet [Wed, 12 Mar 2014 18:47:39 +0000 (14:47 -0400)] 
Fix: check relayd fd leak in lttng cmdline

Fixes coverity issue 1188185.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: time of check time of use scenario
David Goulet [Wed, 12 Mar 2014 18:43:45 +0000 (14:43 -0400)] 
Fix: time of check time of use scenario

Fixes coverity issue 1191753.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing varargs cleanup on error
David Goulet [Wed, 12 Mar 2014 18:08:28 +0000 (14:08 -0400)] 
Fix: missing varargs cleanup on error

Fixes coverity issue 1191751.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: wrong number of elements in array for loop
David Goulet [Wed, 12 Mar 2014 18:07:12 +0000 (14:07 -0400)] 
Fix: wrong number of elements in array for loop

Fixes coverity issue 1191759.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible unlink on uninitialized buffer path
David Goulet [Wed, 12 Mar 2014 17:55:44 +0000 (13:55 -0400)] 
Fix: possible unlink on uninitialized buffer path

Fixes coverity issue 1191752.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible load config domain overwrite
David Goulet [Wed, 12 Mar 2014 17:48:53 +0000 (13:48 -0400)] 
Fix: possible load config domain overwrite

The uniqueness of the domain CAN NOT be enforced with the XML xsd schema
so if the same domains are seen, return an error.

Fixes coverity issue 1191755.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: memory leak
David Goulet [Wed, 12 Mar 2014 17:40:49 +0000 (13:40 -0400)] 
Fix: memory leak

Fixes coverity issue 1191756.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: save session usage of string size
David Goulet [Wed, 12 Mar 2014 17:29:44 +0000 (13:29 -0400)] 
Fix: save session usage of string size

Kind of fixes coverity issue 1191758 since there was a bad check but the
reported issue does not makes sense since there is in fact a validation
before writing the string making the "len" variable never able to reach
4096 (PATH_MAX).

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: remove unused tp in high-throughput test
Zifei Tong [Wed, 12 Mar 2014 09:44:10 +0000 (17:44 +0800)] 
Fix: remove unused tp in high-throughput test

Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUse autoconf AM_MAINTAINER_MODE.
Lars Persson [Wed, 12 Mar 2014 09:22:40 +0000 (10:22 +0100)] 
Use autoconf AM_MAINTAINER_MODE.

Give distribution maintainers the option to skip rebuilding autoconf and
automake generated files. The default behaviour is still to have the
rebuild rules enabled.

Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: handle signed return value for snprintf
David Goulet [Mon, 10 Mar 2014 20:18:42 +0000 (16:18 -0400)] 
Fix: handle signed return value for snprintf

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: clang 'constant-out-of-range-compare' warning
Zifei Tong [Tue, 4 Mar 2014 13:27:38 +0000 (21:27 +0800)] 
Fix: clang 'constant-out-of-range-compare' warning

This patch fixes two 'autological-constant-out-of-range-compare' clang
warnings caused by comparing enum type variables with -1.

It's possible that compilers optimize these two comparisons away.

Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Fail configuration if libxml2 is not found
Jérémie Galarneau [Mon, 10 Feb 2014 20:31:46 +0000 (15:31 -0500)] 
Fix: Fail configuration if libxml2 is not found

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd load command to the lttng client
Jérémie Galarneau [Mon, 10 Feb 2014 16:47:14 +0000 (11:47 -0500)] 
Add load command to the lttng client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd session configuration load capability to libconfig
Jérémie Galarneau [Mon, 10 Feb 2014 16:44:55 +0000 (11:44 -0500)] 
Add session configuration load capability to libconfig

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a save command based on the save API to the lttng client
Jérémie Galarneau [Wed, 22 Jan 2014 17:04:49 +0000 (12:04 -0500)] 
Add a save command based on the save API to the lttng client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd session configuration save feature to session daemon
Jérémie Galarneau [Wed, 22 Jan 2014 19:36:01 +0000 (14:36 -0500)] 
Add session configuration save feature to session daemon

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a save API to lttng-ctl
Jérémie Galarneau [Wed, 22 Jan 2014 16:57:19 +0000 (11:57 -0500)] 
Add a save API to lttng-ctl

This adds multiple function calls to the lttng-ctl API with save.h and
save-internal.h files.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd session configuration XSD
Jérémie Galarneau [Wed, 22 Jan 2014 16:46:06 +0000 (11:46 -0500)] 
Add session configuration XSD

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a config_writer API based on libxml2
Jérémie Galarneau [Tue, 21 Jan 2014 19:24:54 +0000 (14:24 -0500)] 
Add a config_writer API based on libxml2

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a dependency to libxml2
Jérémie Galarneau [Tue, 21 Jan 2014 18:44:56 +0000 (13:44 -0500)] 
Add a dependency to libxml2

libxml2 2.7.6 is the oldest supported version.
This is the version distributed as part of RHEL 6.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoSend filter expression string to session daemon
Jérémie Galarneau [Tue, 21 Jan 2014 17:24:24 +0000 (12:24 -0500)] 
Send filter expression string to session daemon

Send the filter expression string along with the filter's bytecode to
the session daemon. The session daemon now stores the filter expression.
This makes it possible to list the filter's expression when listing
events.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: tcp4 and net4 protocol support in uri_parse
Jérémie Galarneau [Tue, 28 Jan 2014 20:01:25 +0000 (15:01 -0500)] 
Fix: tcp4 and net4 protocol support in uri_parse

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agosession_find_by_name does not need a non-const name param
Jérémie Galarneau [Wed, 22 Jan 2014 16:50:10 +0000 (11:50 -0500)] 
session_find_by_name does not need a non-const name param

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Unchecked session pointer when destroying a connection in relayd
Jérémie Galarneau [Tue, 4 Mar 2014 18:45:17 +0000 (13:45 -0500)] 
Fix: Unchecked session pointer when destroying a connection in relayd

An unknown command currently crashes the relay daemon since
destroy_connection calls destroy_session without checking whether or not
a session is associated with the connection.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: improve lttng with live by spawning relayd
David Goulet [Fri, 28 Feb 2014 17:31:46 +0000 (12:31 -0500)] 
Fix: improve lttng with live by spawning relayd

The create --live, will try to spawn a default relayd if no URL is
given.

The lttng view now supports the live tracing mode thus lttng view is
usable with a live session.

Fixes #738

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: relayd should listen for viewers on localhost only by default
Mathieu Desnoyers [Fri, 28 Feb 2014 13:33:49 +0000 (08:33 -0500)] 
Fix: relayd should listen for viewers on localhost only by default

Having relayd listening by default on 0.0.0.0 (all interfaces) with a
protocol without authentication is an information leak waiting to
happen.

Users should explicitely specify if they want to listen on all
interfaces, using e.g. -L tcp://0.0.0.0:5344 (see lttng-relayd(8)
manpage for details). They should only do so if they use a firewall, or
are within a secured network.

Fixes #746

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: handle loglevel range ALL in list command
David Goulet [Thu, 27 Feb 2014 20:04:53 +0000 (15:04 -0500)] 
Fix: handle loglevel range ALL in list command

Print the ":" if we get the ALL range and not TYPE UNKNOWN.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTests: add JUL test for multiple loglevel
David Goulet [Thu, 27 Feb 2014 19:48:07 +0000 (14:48 -0500)] 
Tests: add JUL test for multiple loglevel

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: index JUL event by name *and* loglevel
David Goulet [Thu, 27 Feb 2014 19:00:13 +0000 (14:00 -0500)] 
Fix: index JUL event by name *and* loglevel

This is to support multiple loglevels for a JUL event.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: JUL to enable user and root tracepoints
David Goulet [Thu, 27 Feb 2014 15:03:14 +0000 (10:03 -0500)] 
Fix: JUL to enable user and root tracepoints

This is needed to support the LTTng JUL agent to connect to both user
and root session daemon, we have to enable different tracepoint for the
two cases in order to avoid duplicating the trace payload in both the
user and root trace output.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRevert "Fix: format + PACKAGE_URL for dynamic printing"
David Goulet [Thu, 27 Feb 2014 14:56:51 +0000 (09:56 -0500)] 
Revert "Fix: format + PACKAGE_URL for dynamic printing"

This changes the lttng version output considered as a stable ABI in RC
cycle. This will apply to 2.5.

This reverts commit 9afbd878f072d5e0577811acf1d3340f65cf2e26.

8 years agoFix: handle the registration done command for JUL
David Goulet [Wed, 26 Feb 2014 21:13:34 +0000 (16:13 -0500)] 
Fix: handle the registration done command for JUL

Lockstep with lttng-ust.

Part of the fix for issue #692

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTest fix: use temp file sync. of test app
David Goulet [Wed, 26 Feb 2014 20:13:46 +0000 (15:13 -0500)] 
Test fix: use temp file sync. of test app

Fixes #736

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: keep metadata channel attr in UST session
David Goulet [Wed, 26 Feb 2014 20:07:12 +0000 (15:07 -0500)] 
Fix: keep metadata channel attr in UST session

This is so that if we have NO application we can use the metadata
channel attributes once one appears.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTests fix: Missing waitpid in fork test
Jérémie Galarneau [Wed, 26 Feb 2014 15:56:57 +0000 (10:56 -0500)] 
Tests fix: Missing waitpid in fork test

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add loglevel type to lttng list <name>
David Goulet [Wed, 26 Feb 2014 18:22:32 +0000 (13:22 -0500)] 
Fix: add loglevel type to lttng list <name>

For range loglevel, the <= is used and for single ==. For instance:

ev_log_range (loglevel <= TRACE_WARNING (4)) (type: tracepoint)
ev_log_single (loglevel == TRACE_NOTICE (5)) (type: tracepoint)

Fixes #628

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: minor rephrasing of the lttng.1 man page
David Goulet [Wed, 26 Feb 2014 17:04:57 +0000 (12:04 -0500)] 
Fix: minor rephrasing of the lttng.1 man page

Fixes #730

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Warn user if JUL port is already being used
David Goulet [Wed, 26 Feb 2014 16:45:45 +0000 (11:45 -0500)] 
Fix: Warn user if JUL port is already being used

Fixes #740

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add some sane default values to --live opt
David Goulet [Wed, 26 Feb 2014 16:29:57 +0000 (11:29 -0500)] 
Fix: add some sane default values to --live opt

The lttng create --live now takes optional arguments meaning if no USEC
or/and -U are found, some defaults value are used.

Fixes #738

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible NULL deref. in sessiond error path
Stefan Seefeld [Wed, 26 Feb 2014 03:44:30 +0000 (22:44 -0500)] 
Fix: possible NULL deref. in sessiond error path

Fxies #735

Signed-off-by: Stefan Seefeld <stefan@codesourcery.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: format + PACKAGE_URL for dynamic printing
Jonathan Rajotte [Tue, 25 Feb 2014 18:04:17 +0000 (13:04 -0500)] 
Fix: format + PACKAGE_URL for dynamic printing

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: flag that kernel streams FDs has been sent
David Goulet [Tue, 25 Feb 2014 20:24:53 +0000 (15:24 -0500)] 
Fix: flag that kernel streams FDs has been sent

Flag the session *after* every stream was successfully sent.

Fixes #731

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: forbid session name creation if contains /
David Goulet [Tue, 25 Feb 2014 19:45:08 +0000 (14:45 -0500)] 
Fix: forbid session name creation if contains /

This adds a validation function for session name which for now denies
any session name containing '/'.

This is in response of bug #721 that actually uses a path as a session
name such as "test/../session1" which would then be concatenated to the
session path adding a relative path to it making this a serious security
issue.

Because of this issue, this is backported from master up to stable-2.3.

Fixes #721

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't start session if no channel
David Goulet [Tue, 25 Feb 2014 19:22:19 +0000 (14:22 -0500)] 
Fix: don't start session if no channel

This adds a new error code that indicates that the session contains NO
channel.

Fixes #715

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing relayd option to man page
David Goulet [Tue, 25 Feb 2014 19:02:32 +0000 (14:02 -0500)] 
Fix: add missing relayd option to man page

Fixes #706

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: report error if consumer can't be spawned
David Goulet [Tue, 25 Feb 2014 18:55:12 +0000 (13:55 -0500)] 
Fix: report error if consumer can't be spawned

On error of the UST consumer execl(), we now exit the forked process
like the kernel does.

Furthermore, fix an error handling value when timing out when waiting
for the consumer to bootstrap thus returning an error to the client and
not continuing with the command thinking that the consumer was actually
spawned.

So, the expected behavior is to wait for the pthread condition and if a
timeout is seen, the client is informed thus making the client command
hang for the default timeout value of 30 seconds.

Fixes #702

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: lttng list -u <name> should only list UST
David Goulet [Tue, 25 Feb 2014 17:42:04 +0000 (12:42 -0500)] 
Fix: lttng list -u <name> should only list UST

Fixes #654

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: kernel channel destroy on consumer if sent
David Goulet [Tue, 25 Feb 2014 17:21:32 +0000 (12:21 -0500)] 
Fix: kernel channel destroy on consumer if sent

An enable-channel immediately followed by a destroy session triggered an
assert on the consumer followed by the shutdown of the consumer thread
for the kernel.

This fix make sure we don't ask the consumer to destroy a channel if not
previously sent to it and handle not found channel on destroy.

Fixes #643

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUpdate changelog with stable 2.3 and 2.4 branch
David Goulet [Tue, 25 Feb 2014 17:01:59 +0000 (12:01 -0500)] 
Update changelog with stable 2.3 and 2.4 branch

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: only create UST metadata on start trace
David Goulet [Tue, 25 Feb 2014 16:03:35 +0000 (11:03 -0500)] 
Fix: only create UST metadata on start trace

Fixes #739

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRevert "Fix: wrong condition on startup for low-activity streams"
David Goulet [Mon, 24 Feb 2014 19:35:05 +0000 (14:35 -0500)] 
Revert "Fix: wrong condition on startup for low-activity streams"

This reverts commit d3aac146d0800fe9820d51e5b9fa52e7543c1237.

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing big endian conversion for one index field
Julien Desfossez [Mon, 24 Feb 2014 18:34:00 +0000 (13:34 -0500)] 
Fix: missing big endian conversion for one index field

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: wrong condition on startup for low-activity streams
Julien Desfossez [Mon, 24 Feb 2014 18:02:19 +0000 (13:02 -0500)] 
Fix: wrong condition on startup for low-activity streams

If we only received and sent one index, we should not be in the retry
condition.
The rstream->total_index_received == vstream->last_sent_index is checked
before.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: perror on index directory creation error
Julien Desfossez [Mon, 24 Feb 2014 18:02:18 +0000 (13:02 -0500)] 
Fix: perror on index directory creation error

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoComments fix: lttngerr.h -> error.h (./Changelog:754)
Jonathan Rajotte [Mon, 24 Feb 2014 00:50:52 +0000 (19:50 -0500)] 
Comments fix: lttngerr.h -> error.h (./Changelog:754)

Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: consumerd errors on exit
Mathieu Desnoyers [Fri, 21 Feb 2014 15:14:46 +0000 (10:14 -0500)] 
Fix: consumerd errors on exit

- The LTTNG_CONSUMER_STOP command is not used by sessiond anymore, so
  deprecate it,
- Ensure that the normal teardown (with signal handler) does not trigger
  a health error in consumer daemon by distinguishing between errors and
  "should exit" with different lttng_consumer_poll_socket() return values.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: scanf unbounded input
Mathieu Desnoyers [Fri, 21 Feb 2014 03:53:04 +0000 (22:53 -0500)] 
Fix: scanf unbounded input

Awaiting a proper cleanup (introducing nscanf), do what we can to
validate the scanf input using its utterly broken API.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: miscellaneous memory handling fixes
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:46 +0000 (10:23 -0500)] 
Fix: miscellaneous memory handling fixes

Issues found with Valgrind:

- Uninitialized memory sent through sendmsg,
- Uninitialized realloc memory,
- Erroneous pointer arithmetic in jul_list_events(),
- Memory leaks in kernel_consumer_add_channel(),
  kernel_consumer_add_metadata(),
- Memory leak (snapshot_destroy missing hash table cleanup),
- Uninitialized poll/epoll memory on realloc.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing VALGRIND ifdef checks and documentation
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:45 +0000 (10:23 -0500)] 
Fix: add missing VALGRIND ifdef checks and documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: race with index file creation
Julien Desfossez [Fri, 14 Feb 2014 19:25:26 +0000 (14:25 -0500)] 
Fix: race with index file creation

Only the data thread should create the index file since it is
responsible of filling the FD field of the index struct in memory.
When the control thread is ready to write the index, the FD is already
set.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: deadlock during rotation
Julien Desfossez [Fri, 14 Feb 2014 20:51:34 +0000 (15:51 -0500)] 
Fix: deadlock during rotation

The overwrite_lock is nested inside the viewer_stream_rotation_lock.
And the viewer_stream_rotate function is always called with the
viewer_stream_rotation_lock held.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: simplify get next index in live
David Goulet [Thu, 13 Feb 2014 18:58:19 +0000 (13:58 -0500)] 
Fix: simplify get next index in live

This fixes some case of unitialized status, use of bad ret value and
help modularize the get next index function.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: steal channel key in the consumer to avoid race
David Goulet [Wed, 12 Feb 2014 20:17:57 +0000 (15:17 -0500)] 
Fix: steal channel key in the consumer to avoid race

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: change ERR statement to DBG in kernel read subbuffer
David Goulet [Thu, 13 Feb 2014 15:55:47 +0000 (10:55 -0500)] 
Fix: change ERR statement to DBG in kernel read subbuffer

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: handle snapshot ENODATA in live timer
David Goulet [Thu, 13 Feb 2014 15:42:58 +0000 (10:42 -0500)] 
Fix: handle snapshot ENODATA in live timer

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: relayd leak on error in consumer splice()
David Goulet [Wed, 12 Feb 2014 16:19:43 +0000 (11:19 -0500)] 
Fix: relayd leak on error in consumer splice()

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: protect close_write_flag with the rotation lock
David Goulet [Tue, 11 Feb 2014 21:27:57 +0000 (16:27 -0500)] 
Fix: protect close_write_flag with the rotation lock

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoMan: clarify loglevel for JUL domain
David Goulet [Wed, 12 Feb 2014 19:46:08 +0000 (14:46 -0500)] 
Man: clarify loglevel for JUL domain

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Define __STDC_LIMIT_MACROS to fix C++ builds
Jérémie Galarneau [Mon, 10 Feb 2014 16:04:22 +0000 (11:04 -0500)] 
Fix: Define __STDC_LIMIT_MACROS to fix C++ builds

Necessary to include the fixed-width type limits on glibc versions
older than 2.18 when building with a C++ compiler.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: wrong data structure used in commit df41f83
David Goulet [Tue, 11 Feb 2014 21:36:30 +0000 (16:36 -0500)] 
Fix: wrong data structure used in commit df41f83

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing optional dependency to babeltrace in README
Christian Babeux [Fri, 7 Feb 2014 17:43:38 +0000 (12:43 -0500)] 
Fix: add missing optional dependency to babeltrace in README

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: cleanup inconsistent use of spaces/tabs in README
Christian Babeux [Fri, 7 Feb 2014 17:48:51 +0000 (12:48 -0500)] 
Fix: cleanup inconsistent use of spaces/tabs in README

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: only set the new_streams flag if a viewer is attached
Julien Desfossez [Mon, 10 Feb 2014 23:52:29 +0000 (18:52 -0500)] 
Fix: only set the new_streams flag if a viewer is attached

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: lttng-live documentation
Julien Desfossez [Mon, 10 Feb 2014 23:52:28 +0000 (18:52 -0500)] 
Fix: lttng-live documentation

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: remove dead code in relayd live code
David Goulet [Tue, 11 Feb 2014 21:08:43 +0000 (16:08 -0500)] 
Fix: remove dead code in relayd live code

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: use after free error code path
David Goulet [Tue, 11 Feb 2014 21:04:15 +0000 (16:04 -0500)] 
Fix: use after free error code path

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: wrong sizeof argument in live viewer create session
David Goulet [Tue, 11 Feb 2014 20:58:52 +0000 (15:58 -0500)] 
Fix: wrong sizeof argument in live viewer create session

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: zero out the reply structure in viewer_connect
David Goulet [Tue, 11 Feb 2014 20:16:34 +0000 (15:16 -0500)] 
Fix: zero out the reply structure in viewer_connect

Fixes #728

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: write index only if fd is valid
David Goulet [Tue, 11 Feb 2014 19:13:01 +0000 (14:13 -0500)] 
Fix: write index only if fd is valid

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: cleanup relayd on any I/O error in read subbuffer mmap
David Goulet [Tue, 11 Feb 2014 18:21:59 +0000 (13:21 -0500)] 
Fix: cleanup relayd on any I/O error in read subbuffer mmap

Any I/O operation that triggers an error now cleans the relayd since
there is no way we can recover from that in any cases and streams
associated to that relayd need to be cleaned up.

This commit also removes the "written" variable that is simply not
needed and was a bit confusing as a returned value.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: memory/fd leak when cleaning streams in channel
David Goulet [Tue, 11 Feb 2014 18:16:45 +0000 (13:16 -0500)] 
Fix: memory/fd leak when cleaning streams in channel

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: destroy streams in consumer del channel
David Goulet [Mon, 10 Feb 2014 22:23:20 +0000 (17:23 -0500)] 
Fix: destroy streams in consumer del channel

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing urcu wfqueue headers in relayd
David Goulet [Mon, 10 Feb 2014 22:21:14 +0000 (17:21 -0500)] 
Fix: add missing urcu wfqueue headers in relayd

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: in lttng_read/write deny count bigger than the possible returned value
David Goulet [Mon, 10 Feb 2014 18:43:08 +0000 (13:43 -0500)] 
Fix: in lttng_read/write deny count bigger than the possible returned value

Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.040064 seconds and 4 git commands to generate.