lttng-tools.git
6 years agoFix: relayd live don't send incomplete stream list
Mathieu Desnoyers [Sun, 23 Aug 2015 19:52:26 +0000 (12:52 -0700)] 
Fix: relayd live don't send incomplete stream list

Sample the "closed" flag with session lock held.
Also, if the session connection is closed while we attach to it, reply
with HUP, because there are risks of attaching to an incomplete session
(e.g. the metadata stream could be already closed).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: consumer timer misses RCU thread registration
Mathieu Desnoyers [Sun, 23 Aug 2015 15:58:50 +0000 (08:58 -0700)] 
Fix: consumer timer misses RCU thread registration

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: sessiond consumer thread should register as RCU thread
Mathieu Desnoyers [Sun, 23 Aug 2015 05:01:36 +0000 (22:01 -0700)] 
Fix: sessiond consumer thread should register as RCU thread

Fixes RCU race where objects are accessed by this thread under RCU
read-side lock after free. Since this thread is not a registered RCU
reader, the read-side lock has no effect.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: don't chain RCU free
Mathieu Desnoyers [Sun, 23 Aug 2015 03:14:44 +0000 (20:14 -0700)] 
Fix: don't chain RCU free

We only do a single rcu_barrier() on teardown of sessiond. Therefore, if
we chain call_rcu, they may not all be executed before exit.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: free metadata cache after grace period in consumer
Mathieu Desnoyers [Sun, 23 Aug 2015 02:58:09 +0000 (19:58 -0700)] 
Fix: free metadata cache after grace period in consumer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: sessiond vs consumerd push/get metadata deadlock
Mathieu Desnoyers [Wed, 19 Aug 2015 21:44:59 +0000 (14:44 -0700)] 
Fix: sessiond vs consumerd push/get metadata deadlock

We need to unlock the registry while we push metadata to break a
circular dependency between the consumerd metadata lock and the sessiond
registry lock. Indeed, pushing metadata to the consumerd awaits that it
gets pushed all the way to relayd, but doing so requires grabbing the
metadata lock. If a concurrent metadata request is being performed by
consumerd, this can try to grab the registry lock on the sessiond while
holding the metadata lock on the consumer daemon. Those push and pull
schemes are performed on two different bidirectionnal communication
sockets.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: streamline ret/errno of run_as()
Mathieu Desnoyers [Wed, 19 Aug 2015 21:13:48 +0000 (14:13 -0700)] 
Fix: streamline ret/errno of run_as()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Double unlock on error path
Mathieu Desnoyers [Thu, 3 Sep 2015 03:01:21 +0000 (23:01 -0400)] 
Fix: Double unlock on error path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoData pending comment clarification in session daemon
Mathieu Desnoyers [Thu, 3 Sep 2015 02:59:20 +0000 (22:59 -0400)] 
Data pending comment clarification in session daemon

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Relay daemon ownership and reference counting
Mathieu Desnoyers [Thu, 3 Sep 2015 02:57:40 +0000 (22:57 -0400)] 
Fix: Relay daemon ownership and reference counting

The ownership and reference counting of the relay daemon is unclear and
buggy in many ways. It is the cause of memory corruptions, double-free,
leaks, segmentation faults, observed in various conditions.

Fix this situation by introducing a clear ownership and reference
counting scheme for this daemon.

See doc/relayd-architecture.txt for details.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoAccept uid and gid parameters in utils_mkdir()/utils_mkdir_recursive()
Jérémie Galarneau [Thu, 3 Sep 2015 19:09:00 +0000 (15:09 -0400)] 
Accept uid and gid parameters in utils_mkdir()/utils_mkdir_recursive()

utils_mkdir* utils may now be use in immediate or "run_as" mode.

This is done since some of the code shared between daemons calls
run_as directly, which doesn't support negative uid/gid (which we use
to mean "run as current user").

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: reference counting of consumer output
Mathieu Desnoyers [Wed, 19 Aug 2015 07:29:52 +0000 (00:29 -0700)] 
Fix: reference counting of consumer output

The UST app session has a reference on the consumer output object, but
it belongs to the UST session. Implement a refcounting scheme to ensure
it is not freed before all users are done using it.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: sessiond add missing socket close
Mathieu Desnoyers [Tue, 18 Aug 2015 01:47:53 +0000 (18:47 -0700)] 
Fix: sessiond add missing socket close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: sessiond should not error on channel creation vs app exit
Mathieu Desnoyers [Sun, 16 Aug 2015 21:56:57 +0000 (17:56 -0400)] 
Fix: sessiond should not error on channel creation vs app exit

We should not report an error when creating a channel if the application
is exiting concurrently.

Also, remove an inappropriate assert() in ust_app_create_event_glb: it
is possible to have a channel lookup fail if channel/event creation
occurs concurrently with an application exit.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: sessiond ust-app session teardown race
Mathieu Desnoyers [Sun, 16 Aug 2015 21:10:22 +0000 (17:10 -0400)] 
Fix: sessiond ust-app session teardown race

Add a deleted flag within the ust app session which is raised (with ust
app session lock held) at delete, and checked within each RCU traversal,
again with ust app session lock held.

This takes care of races between teardown of an application (unregister)
and execution of commands which are accessing the app session
concurrently.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoOnly display agent loglevel if the loglevel type is not ALL
Jérémie Galarneau [Tue, 1 Sep 2015 15:58:38 +0000 (11:58 -0400)] 
Only display agent loglevel if the loglevel type is not ALL

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoInitialize default log level of events on load
Jérémie Galarneau [Mon, 31 Aug 2015 22:53:51 +0000 (18:53 -0400)] 
Initialize default log level of events on load

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDon't assume that Log4j and JUL share the same log level mappings
Jérémie Galarneau [Mon, 31 Aug 2015 22:32:16 +0000 (18:32 -0400)] 
Don't assume that Log4j and JUL share the same log level mappings

We explicitly set the log level of Log4j events to
LTTNG_LOGLEVEL_LOG4J_ALL instead of relying on the fact that
LTTNG_LOGLEVEL_LOG4J_ALL and LTTNG_LOGLEVEL_JUL_ALL are mapped to the
same value.

The resulting additional branch does not seem to incur a significant
performance penalty and, as such, is deemed acceptable.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoAllow the creation of JUL, Log4j and Python channels
Jérémie Galarneau [Mon, 31 Aug 2015 20:00:22 +0000 (16:00 -0400)] 
Allow the creation of JUL, Log4j and Python channels

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Save tracker as part of UST and Kernel domains only
Jérémie Galarneau [Sun, 30 Aug 2015 22:55:52 +0000 (18:55 -0400)] 
Fix: Save tracker as part of UST and Kernel domains only

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Memory leak of agent
Jérémie Galarneau [Sun, 30 Aug 2015 22:50:39 +0000 (18:50 -0400)] 
Fix: Memory leak of agent

agent_destroy() has a comment which indicates that it does _not_
destroy the pointer passed to it and it seems that agents are
never realeased under any code path whatsoever.

There does not seem to be an instance where an agent is allocated on
the stack.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Memory leak of agent event internals
Jérémie Galarneau [Sun, 30 Aug 2015 22:32:47 +0000 (18:32 -0400)] 
Fix: Memory leak of agent event internals

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSave filter expression as part of agent events and save them
Jérémie Galarneau [Sun, 30 Aug 2015 21:44:41 +0000 (17:44 -0400)] 
Save filter expression as part of agent events and save them

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: UTF-8 characters may be stored on up to 4 bytes
Jérémie Galarneau [Sun, 30 Aug 2015 21:43:45 +0000 (17:43 -0400)] 
Fix: UTF-8 characters may be stored on up to 4 bytes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove unneeded hash table existence check in agent_destroy
Jérémie Galarneau [Sun, 30 Aug 2015 21:39:58 +0000 (17:39 -0400)] 
Remove unneeded hash table existence check in agent_destroy

This function can never be called if the agent failed to initialize
its hash table. If such a failure occurs, the agent constructor will
return NULL and its caller should handle the error.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove unnecessary RCU read lock
Jérémie Galarneau [Sun, 30 Aug 2015 21:39:23 +0000 (17:39 -0400)] 
Remove unnecessary RCU read lock

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUse type directly in sizeof instead of a dereferenced pointer
Jérémie Galarneau [Sun, 30 Aug 2015 21:38:25 +0000 (17:38 -0400)] 
Use type directly in sizeof instead of a dereferenced pointer

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoPrevent the addition of UST events to agent channels
Jérémie Galarneau [Sun, 30 Aug 2015 21:37:41 +0000 (17:37 -0400)] 
Prevent the addition of UST events to agent channels

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDon't save log level in session configuration when unneeded
Jérémie Galarneau [Fri, 28 Aug 2015 18:53:26 +0000 (14:53 -0400)] 
Don't save log level in session configuration when unneeded

Saving the log level of events in session configurations when "ALL" log
levels are enabled may confuse both users and programs working with
session configurations.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove unneeded RCU lock
Jérémie Galarneau [Thu, 27 Aug 2015 21:30:37 +0000 (17:30 -0400)] 
Remove unneeded RCU lock

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove unneeded RCU lock
Jérémie Galarneau [Thu, 27 Aug 2015 21:30:21 +0000 (17:30 -0400)] 
Remove unneeded RCU lock

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Propagate filter status of kernel events to client
Jérémie Galarneau [Thu, 27 Aug 2015 21:26:58 +0000 (17:26 -0400)] 
Fix: Propagate filter status of kernel events to client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Save kernel event filter when saving session configuration
Jérémie Galarneau [Thu, 27 Aug 2015 20:53:24 +0000 (16:53 -0400)] 
Fix: Save kernel event filter when saving session configuration

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocs: there is no need to SHOUT in comments
Jérémie Galarneau [Thu, 27 Aug 2015 16:55:04 +0000 (12:55 -0400)] 
Docs: there is no need to SHOUT in comments

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Mention Python as part of enable-event's usage()
Jérémie Galarneau [Thu, 27 Aug 2015 15:52:34 +0000 (11:52 -0400)] 
Fix: Mention Python as part of enable-event's usage()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoGrammar fix in comment
Jérémie Galarneau [Wed, 26 Aug 2015 16:05:03 +0000 (12:05 -0400)] 
Grammar fix in comment

give -> given

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: typo in error message
Jérémie Galarneau [Wed, 26 Aug 2015 16:04:12 +0000 (12:04 -0400)] 
Fix: typo in error message

writting -> writing

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoAdd agent domains to lttng enable-event usage()
Jérémie Galarneau [Wed, 26 Aug 2015 16:03:38 +0000 (12:03 -0400)] 
Add agent domains to lttng enable-event usage()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocs: Add documentation explaining the meaning of "internal" events
Jérémie Galarneau [Wed, 26 Aug 2015 16:02:50 +0000 (12:02 -0400)] 
Docs: Add documentation explaining the meaning of "internal" events

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoReport memory allocation failure when copying filter bytecode
Jérémie Galarneau [Wed, 26 Aug 2015 16:00:30 +0000 (12:00 -0400)] 
Report memory allocation failure when copying filter bytecode

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: cmd_enable_event must return positive error codes
Jérémie Galarneau [Wed, 26 Aug 2015 16:00:05 +0000 (12:00 -0400)] 
Fix: cmd_enable_event must return positive error codes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoEnsure that a filter is always passed with its filter expression
Jérémie Galarneau [Wed, 26 Aug 2015 15:58:56 +0000 (11:58 -0400)] 
Ensure that a filter is always passed with its filter expression

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSave filter expressions as part of agent events
Jérémie Galarneau [Wed, 26 Aug 2015 15:37:48 +0000 (11:37 -0400)] 
Save filter expressions as part of agent events

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoAdd agent domains to the enable-event section of LTTNG(1)
Jérémie Galarneau [Wed, 26 Aug 2015 15:31:45 +0000 (11:31 -0400)] 
Add agent domains to the enable-event section of LTTNG(1)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUse lttng_domain_type enumeration instead of bare integers
Jérémie Galarneau [Mon, 24 Aug 2015 23:24:37 +0000 (19:24 -0400)] 
Use lttng_domain_type enumeration instead of bare integers

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoPrevent disable event on internal UST events
Jérémie Galarneau [Mon, 24 Aug 2015 16:24:18 +0000 (12:24 -0400)] 
Prevent disable event on internal UST events

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove unneeded RCU read lock
Jérémie Galarneau [Mon, 24 Aug 2015 16:17:46 +0000 (12:17 -0400)] 
Remove unneeded RCU read lock

lttng_ht_get_count() now takes the RCU read lock automatically.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSkip internal events when saving a session configuration
Jérémie Galarneau [Mon, 24 Aug 2015 16:17:01 +0000 (12:17 -0400)] 
Skip internal events when saving a session configuration

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Coding-style conformance adjustments
Jérémie Galarneau [Sun, 23 Aug 2015 04:28:57 +0000 (00:28 -0400)] 
Clean-up: Coding-style conformance adjustments

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocs: Clarify ominous comment wording
Jérémie Galarneau [Sun, 23 Aug 2015 04:28:24 +0000 (00:28 -0400)] 
Docs: Clarify ominous comment wording

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoHide internal events from session daemon clients
Jérémie Galarneau [Sun, 23 Aug 2015 03:43:21 +0000 (23:43 -0400)] 
Hide internal events from session daemon clients

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoPrevent the use of reserved UST event names
Jérémie Galarneau [Sun, 23 Aug 2015 04:27:34 +0000 (00:27 -0400)] 
Prevent the use of reserved UST event names

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTag events created as side-effect of agent events as internal
Jérémie Galarneau [Sun, 23 Aug 2015 04:26:28 +0000 (00:26 -0400)] 
Tag events created as side-effect of agent events as internal

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove unneeded RCU lock
Jérémie Galarneau [Sun, 23 Aug 2015 03:35:22 +0000 (23:35 -0400)] 
Remove unneeded RCU lock

lttng_ht_get_count() already holds the RCU read lock.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRemove dead code in lttng-sessiond
Jérémie Galarneau [Sun, 23 Aug 2015 03:24:17 +0000 (23:24 -0400)] 
Remove dead code in lttng-sessiond

event_ust_enable_all_tracepoints and event_ust_disable_all_tracepoints
are both never used by the session daemon.

6 years agoEnsure event names are NULL terminated during validation
Jérémie Galarneau [Sun, 23 Aug 2015 04:22:45 +0000 (00:22 -0400)] 
Ensure event names are NULL terminated during validation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: assert(0) when listing Python events with MI
Philippe Proulx [Wed, 19 Aug 2015 18:17:40 +0000 (14:17 -0400)] 
Fix: assert(0) when listing Python events with MI

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: set GLOBAL buffer type for kernel domain in list
Philippe Proulx [Fri, 21 Aug 2015 15:44:28 +0000 (11:44 -0400)] 
Fix: set GLOBAL buffer type for kernel domain in list

MI is using the list command reponse's buffer type, even when listing
the kernel domain. Not setting .buf_type here results in MI reporting a
wrong buffer type for the kernel domain.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: take RCU read-side lock within hash table functions
Mathieu Desnoyers [Thu, 6 Aug 2015 22:02:21 +0000 (18:02 -0400)] 
Fix: take RCU read-side lock within hash table functions

After review, a great deal of caller sites miss the RCU read-side lock
when using the hash table modification functions. This is a case where
having a slight performance degradation might be worthwhile if we can be
a bit more stability. So instead of playing whack-a-mole, add the RCU
read-side lock in the hash table modification functions to ensure
protection from ABA.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: Adapt MI test to change in track/untrack behaviour
Jérémie Galarneau [Thu, 13 Aug 2015 21:45:40 +0000 (17:45 -0400)] 
Tests: Adapt MI test to change in track/untrack behaviour

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Rename lib_func to cmd_func
Jérémie Galarneau [Thu, 13 Aug 2015 19:38:24 +0000 (15:38 -0400)] 
Clean-up: Rename lib_func to cmd_func

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Improve the error reporting of the track/untrack command
Michael Jeanson [Wed, 12 Aug 2015 20:08:16 +0000 (16:08 -0400)] 
Fix: Improve the error reporting of the track/untrack command

This patch adds feedback when a track/untrack command is successful and
specific messages on errors. It also changes the behavior when tracking
an already tracked PID or untracking a PID that is not tracked from an
error to a warning with a successful exit code.

Fixes: #898
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: Fix flacky clock-plugin test
Jérémie Galarneau [Thu, 13 Aug 2015 18:37:14 +0000 (14:37 -0400)] 
Tests: Fix flacky clock-plugin test

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoBuild: look for python >= 3.0 when building python bindings
Jonathan Rajotte [Thu, 6 Aug 2015 23:00:15 +0000 (19:00 -0400)] 
Build: look for python >= 3.0 when building python bindings

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoBuild: rename use_python to python_binding
Jonathan Rajotte [Thu, 6 Aug 2015 23:00:14 +0000 (19:00 -0400)] 
Build: rename use_python to python_binding

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: regression tests
Mathieu Desnoyers [Thu, 6 Aug 2015 21:15:45 +0000 (17:15 -0400)] 
Fix: regression tests

Fix racy session/relayd wait-after-kill scheme.
Fix racy live test where application may not have generated events yet
when we attach to the live trace.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: tests: stderr not correctly redirected
Jonathan Rajotte [Wed, 29 Jul 2015 21:57:52 +0000 (17:57 -0400)] 
Fix: tests: stderr not correctly redirected

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: TimeoutExpired in Python tests not defined globally
Antoine Busque [Tue, 11 Aug 2015 20:29:30 +0000 (16:29 -0400)] 
Fix: TimeoutExpired in Python tests not defined globally

The `TimeoutExpired` exception is used in multiple locations
throughout the Python tests. However, it needs to be used as
`subprocess.TimeoutExpired` given that it is only defined in that
module.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: ust: clock override plugin
Jonathan Rajotte [Thu, 23 Jul 2015 01:49:21 +0000 (21:49 -0400)] 
Tests: ust: clock override plugin

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoCleanup: reuse tracker* element from config
Jonathan Rajotte [Fri, 10 Apr 2015 17:17:25 +0000 (13:17 -0400)] 
Cleanup: reuse tracker* element from config

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTest: save/load: pid_tracker basic test
Jonathan Rajotte [Thu, 9 Apr 2015 20:38:24 +0000 (16:38 -0400)] 
Test: save/load: pid_tracker basic test

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Remove statement which has no side-effect
Jérémie Galarneau [Wed, 12 Aug 2015 16:24:53 +0000 (12:24 -0400)] 
Clean-up: Remove statement which has no side-effect

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSave/load: pid_tracker feature.
Jonathan Rajotte [Tue, 31 Mar 2015 21:15:36 +0000 (17:15 -0400)] 
Save/load: pid_tracker feature.

Xml schema updated

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTest: mi: track/untrack feature
Jonathan Rajotte [Sat, 28 Mar 2015 22:00:09 +0000 (18:00 -0400)] 
Test: mi: track/untrack feature

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoUtil: xml_extract: add node_exist option
Jonathan Rajotte [Fri, 3 Apr 2015 21:15:43 +0000 (17:15 -0400)] 
Util: xml_extract: add node_exist option

The node_exist argument permit a more flexible way to extract informations
within test suites. We can check the presence of a node and not only list
the content of a final node.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMi: track/untrack: validation
Jérémie Galarneau [Tue, 11 Aug 2015 19:15:27 +0000 (15:15 -0400)] 
Mi: track/untrack: validation

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: Grammar fixes in mi_lttng.xsd
Jérémie Galarneau [Tue, 11 Aug 2015 16:53:49 +0000 (12:53 -0400)] 
Docs: Grammar fixes in mi_lttng.xsd

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Ensure a valid command error code is returned by track/untrack
Jérémie Galarneau [Tue, 11 Aug 2015 16:44:06 +0000 (12:44 -0400)] 
Fix: Ensure a valid command error code is returned by track/untrack

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoClean-up: Remove java-doc annotations from function header
Jérémie Galarneau [Tue, 11 Aug 2015 16:23:28 +0000 (12:23 -0400)] 
Clean-up: Remove java-doc annotations from function header

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMi: track/untrack/listing
Jonathan Rajotte [Tue, 11 Aug 2015 19:14:11 +0000 (15:14 -0400)] 
Mi: track/untrack/listing

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: intialization of ust_metadata_poll_pipe to garbage value
Jérémie Galarneau [Fri, 7 Aug 2015 21:01:37 +0000 (17:01 -0400)] 
Fix: intialization of ust_metadata_poll_pipe to garbage value

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix "allocator sizeof operand mismatch" warning
Jérémie Galarneau [Fri, 7 Aug 2015 20:17:02 +0000 (16:17 -0400)] 
Fix "allocator sizeof operand mismatch" warning

Addresses benign scan-build waring:
Result of 'realloc' is converted to a pointer of type 'char *',
which is incompatible with sizeof operand type 'char **'

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoClean-up: Remove java-doc style function header from session.h
Jérémie Galarneau [Fri, 7 Aug 2015 19:10:18 +0000 (15:10 -0400)] 
Clean-up: Remove java-doc style function header from session.h

While we should move to a consistent API documentation style,
this function's documentation is inconsistent with the rest
of the public LTTng API.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoClean-up: remove extra space in comment
Jérémie Galarneau [Fri, 7 Aug 2015 19:08:14 +0000 (15:08 -0400)] 
Clean-up: remove extra space in comment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: test_mi test
Mathieu Desnoyers [Thu, 6 Aug 2015 19:52:37 +0000 (15:52 -0400)] 
Fix: test_mi test

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTests: Java agent: Add configure switches to enable tests
Michael Jeanson [Thu, 6 Aug 2015 16:39:13 +0000 (12:39 -0400)] 
Tests: Java agent: Add configure switches to enable tests

This patch adds the switches --enable-test-java-agent-(jul|log4j|all) to
the configure script, the tests now need to be explicitly enabled and
their dependencies are only checked if so.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: incorrect script name in python logging test
Antoine Busque [Tue, 4 Aug 2015 22:29:35 +0000 (18:29 -0400)] 
Fix: incorrect script name in python logging test

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: Document Agent reply codes
Jérémie Galarneau [Thu, 6 Aug 2015 19:05:07 +0000 (15:05 -0400)] 
Docs: Document Agent reply codes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: Remove Java-specific comments from agent.h
Jérémie Galarneau [Thu, 6 Aug 2015 19:04:45 +0000 (15:04 -0400)] 
Docs: Remove Java-specific comments from agent.h

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: Grammar fix in agent header
Jérémie Galarneau [Thu, 6 Aug 2015 19:02:31 +0000 (15:02 -0400)] 
Docs: Grammar fix in agent header

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoReturn "Unknown" error instead of "Fatal" on unhandled agent replies
Jérémie Galarneau [Thu, 6 Aug 2015 19:01:50 +0000 (15:01 -0400)] 
Return "Unknown" error instead of "Fatal" on unhandled agent replies

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoLog agent reply in disable_event()
Jérémie Galarneau [Thu, 6 Aug 2015 19:01:12 +0000 (15:01 -0400)] 
Log agent reply in disable_event()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoLog agent reply in enable_event()
Jérémie Galarneau [Thu, 6 Aug 2015 19:00:45 +0000 (15:00 -0400)] 
Log agent reply in enable_event()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoLog agent reply in list_events()
Jérémie Galarneau [Thu, 6 Aug 2015 18:59:58 +0000 (14:59 -0400)] 
Log agent reply in list_events()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoAdd agent reply code logging helpers
Jérémie Galarneau [Thu, 6 Aug 2015 18:58:57 +0000 (14:58 -0400)] 
Add agent reply code logging helpers

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoAdd a LOG() macro which handles dynamic severity levels
Jérémie Galarneau [Thu, 6 Aug 2015 18:57:17 +0000 (14:57 -0400)] 
Add a LOG() macro which handles dynamic severity levels

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Discard disable event command filter payload
Jérémie Galarneau [Thu, 6 Aug 2015 02:03:29 +0000 (22:03 -0400)] 
Fix: Discard disable event command filter payload

liblttng-ctl sends both the filter expression and filter bytecode
whenever lttng_disable_event_ext() is used _or_ when it is used
implicitly by lttng_disable_event() on an Agent domain (Log4j,
JUL or Python).

As of now, the session daemon ignores this filter payload.
However, on some rare occasions (the frequency of which depends
on the system's configuration and load), the second call to
sendmsg() done by liblttng-ctl could block and return an error
when the session daemon closed the socket (EPIPE).

This fix ensures the payload is received and discarded by the
session daemon, which in turn allows the client to handle the
session daemon's reply to the command.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Use MSG_NOSIGNAL when calling sendmsg()
Jérémie Galarneau [Thu, 6 Aug 2015 01:26:34 +0000 (21:26 -0400)] 
Fix: Use MSG_NOSIGNAL when calling sendmsg()

Applications using the liblttng-ctl library are most probably
not expecting the SIGPIPE signal which can be triggered by
sendmsg() on a closed socket. Use the MSG_NOSIGNAL flag to
handle such cases gracefully.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoSend data pending status as part of payload instead of an invalid error
Jérémie Galarneau [Wed, 5 Aug 2015 18:57:36 +0000 (14:57 -0400)] 
Send data pending status as part of payload instead of an invalid error

This ensures that the session daemon's logs don't contain false
positives every time a data pending command is replied-to.

The use of invalid error codes 0 and 1 causes the log to contain
misleading entries of the form:

Sending response (size: 16, retcode: Unknown error code (0)) [...]

This commit also proves that it is possible, contrary to what the
previous comment indicated, to send a boolean value over a socket
without using undocumented error codes.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoLog error code's value when sessiond replies to a client
Jérémie Galarneau [Wed, 5 Aug 2015 18:09:27 +0000 (14:09 -0400)] 
Log error code's value when sessiond replies to a client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.064645 seconds and 4 git commands to generate.