Mathieu Desnoyers [Tue, 16 Jul 2013 17:29:30 +0000 (13:29 -0400)] 
Fix: use per-uid buffer registry for UID buffer snapshots
Fixes empty traces when doing a snapshot after killing a single traced
application.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 16:44:08 +0000 (12:44 -0400)]
cmd.c: fix typos in snapshot commands
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Tue, 16 Jul 2013 15:07:01 +0000 (11:07 -0400)] 
Test snapshot per-uid post-mortem
Test to check if we can take a snapshot after a traced application
exited when using per-uid buffers.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 14:50:34 +0000 (10:50 -0400)]
Remove leftover fprintf
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 13:53:33 +0000 (09:53 -0400)]
Fix deadlock: don't take channel lock in timer
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 13:36:59 +0000 (09:36 -0400)]
Introduce channel timer lock
Currently a shadow of the channel lock. Will eventually be used to
protect channel timer handler from concurrent channel updates without
being held when the timer is stopped (future commit).
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:47:21 +0000 (21:47 -0400)]
document lttng_ustconsumer_request_metadata locking constraints
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:28:23 +0000 (21:28 -0400)]
consumer: remove unused lttng_ustconsumer_push_metadata
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:19:19 +0000 (21:19 -0400)]
Document metadata_socket_lock nesting
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:17:06 +0000 (21:17 -0400)]
lttng_ustconsumer_recv_metadata does not need all those locks
Since lttng_ustconsumer_recv_metadata() does not push data into the
stream anymore, it only needs the metadata cache lock.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:15:05 +0000 (21:15 -0400)]
document metadata_switch_timer() deadlock
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:06:07 +0000 (21:06 -0400)]
Fix: add missing metadata socket lock
Protect metadata socket, which can be accessed concurrently by the
metadata timer and by snapshot.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:56:51 +0000 (20:56 -0400)]
document metadata_switch_timer() locking constraints
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:53:04 +0000 (20:53 -0400)]
consumer: remove timeout for UST metadata
Remove time out for UST metadata by generating metadata packets whenever
they are about to be read from the ring buffer rather than filling them
when the metadata cache is updated, which requires a time out, and
therefore may fail.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:22:48 +0000 (20:22 -0400)]
Introduce pipe for UST metadata cache and stream
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:18:13 +0000 (20:18 -0400)]
consumer: replace DBG2() instances by DBG()
The consumer daemon does not currently support DBG2() printout.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:16:07 +0000 (20:16 -0400)]
Introduce utils_create_pipe_cloexec_nonblock()
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:14:07 +0000 (20:14 -0400)]
ust consumer: data_pending check is endpoint active
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:12:30 +0000 (20:12 -0400)]
Fix: kernel consumer: data_pending check if endpoint active
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:07:36 +0000 (20:07 -0400)]
consumer: explicitly set endpoint status to active at init
Ensures we explicitly set active at init for channels that don't
interact with a relayd.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:03:15 +0000 (20:03 -0400)]
document consumer_metadata_cache_flushed use of consumer_data.lock
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 15 Jul 2013 23:45:24 +0000 (19:45 -0400)]
consumer: introduce channel lock
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Sun, 14 Jul 2013 19:29:41 +0000 (15:29 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Sun, 14 Jul 2013 19:27:45 +0000 (15:27 -0400)]
Fix: update lttng snapshot help output
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Sun, 14 Jul 2013 19:24:15 +0000 (15:24 -0400)]
Man: fix part of snapshot documentation
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 21:16:41 +0000 (17:16 -0400)]
Fix: set tracefile size test with PID buffers
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Fri, 12 Jul 2013 20:39:02 +0000 (16:39 -0400)] 
Fix: Babelstats fail to parse output with no process name or pid
The process name and pid are optionnal components in the babeltrace
text output.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Mathieu Desnoyers [Fri, 12 Jul 2013 15:41:08 +0000 (11:41 -0400)]
Missing NULL pointer init in tap.c
Could lead to free() of unitialized pointer.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Fri, 12 Jul 2013 16:38:56 +0000 (12:38 -0400)] 
Fix: Unchecked asprintf/vasprintf return values
strp may be modified even in case of failure according to the
ASPRINTF(3) man page.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 17:57:55 +0000 (13:57 -0400)]
Add snapshots test to fast regression
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 17:47:12 +0000 (13:47 -0400)]
Fix: kernel data unit test
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 15:01:09 +0000 (11:01 -0400)]
Fix: snapshot returned valid LTTNG_ERR code
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 14:53:59 +0000 (10:53 -0400)]
Add the number of snapshot taken to the output path
This number of snapshots is per session.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 14:23:28 +0000 (10:23 -0400)]
Fix: RCU read side lock unbalanced
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 12 Jul 2013 14:16:26 +0000 (10:16 -0400)]
Fix: zeroed snapshot output at init
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 11 Jul 2013 20:57:53 +0000 (16:57 -0400)]
Support del-output with an output name
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 11 Jul 2013 20:46:14 +0000 (16:46 -0400)]
Update man page with snapshot command
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 11 Jul 2013 19:30:49 +0000 (15:30 -0400)]
New UST default buffers is now per UID
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 11 Jul 2013 19:20:21 +0000 (15:20 -0400)]
Bump UST ABI major version for 2.3 release
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 11 Jul 2013 19:13:23 +0000 (15:13 -0400)]
Add snapshot mode to lttng list session
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 11 Jul 2013 18:51:35 +0000 (14:51 -0400)]
Fix: support temporary snapshot max size and name
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Wed, 10 Jul 2013 02:42:13 +0000 (22:42 -0400)]
Support snapshot max-size limitation
This features allows the user to specify a maximum size for the snapshot
collected. The maximum stream size is split equally by the total number
of streams active at the time of the snapshot record across all the
domains. The metadata is not limited and its size is not taken into
account in the maximum stream size computation.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 8 Jul 2013 15:46:37 +0000 (11:46 -0400)]
Tests: per-UID UST snapshot
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 9 Jul 2013 14:50:25 +0000 (10:50 -0400)]
Fix: snapshot support for UST and kernel in same session
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 8 Jul 2013 19:19:28 +0000 (15:19 -0400)]
Implement lttng create --snapshot command
This is to ease the life of the user creating a session in snapshot
mode using the new API call.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 8 Jul 2013 19:19:12 +0000 (15:19 -0400)]
Add create session snapshot API in lttng-sessiond
This commit adds the "lttng_create_session_snapshot()" call to the API
which will create on the session daemon a session in snapshot mode
meaning that all channel will be in overwrite mode and mmap output.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 8 Jul 2013 16:15:19 +0000 (12:15 -0400)]
Add snapshot output init call that uses URIs
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Wed, 10 Jul 2013 19:39:54 +0000 (15:39 -0400)]
Fix: consumer err_sock cloexec
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Woegerer, Paul [Wed, 10 Jul 2013 09:06:45 +0000 (11:06 +0200)] 
Callsite: add "ip" context
Support ip context in lttng add-context -t.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 9 Jul 2013 16:28:41 +0000 (12:28 -0400)]
Fix: possible consumer sockets double close on cleanup
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mohamad Gebai [Mon, 8 Jul 2013 19:26:27 +0000 (15:26 -0400)] 
Automatically load kvm-x86 and kvm-x86-mmu probes.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mohamad Gebai <mohamad.gebai@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 28 Jun 2013 16:18:35 +0000 (12:18 -0400)]
Fix: consumer: use uint64_t for all sessiond_id
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Mon, 8 Jul 2013 15:25:52 +0000 (11:25 -0400)]
Fix: add gpl and lgpl files to tarball
Fixes #581
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 8 Jul 2013 15:23:44 +0000 (11:23 -0400)]
Fix: don't install libtap system wide
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 5 Jul 2013 20:03:50 +0000 (16:03 -0400)]
Fix: close consumer sockets in sessiond cleanup
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 5 Jul 2013 19:39:21 +0000 (15:39 -0400)]
Fix: set globally visible flag to kernel stream
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 4 Jul 2013 22:14:33 +0000 (18:14 -0400)]
Fix: lttng: memory leak in snapshot record command
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 4 Jul 2013 22:06:44 +0000 (18:06 -0400)]
Fix: kernel-consumer: double-close
check for -1 out_fd
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 4 Jul 2013 21:53:50 +0000 (17:53 -0400)]
Fix: consumer: incorrect size zmalloc
Also, check return value.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 5 Jul 2013 18:41:58 +0000 (14:41 -0400)]
Fix: don't try to send stream to relayd if not in streaming
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 20:25:27 +0000 (16:25 -0400)]
Fix: relayd refcount updates for stream
Increment refcount only when the stream was successfully sent to the
relayd and set the new stream's flag "sent_to_relayd" which is used
before the refcount update when closing the relayd. A stream that was
unable to be sent, the close relayd code path does not decrement the
refcount anymore.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 20:31:27 +0000 (16:31 -0400)]
Fix: don't send error to sessiond on orderly shutdown
The send always fail if the sessiond has closed the socket so no point
of trying to send an error.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 20:14:46 +0000 (16:14 -0400)]
Fix: bad pathname used when sending kernel stream to relayd
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 19:35:21 +0000 (15:35 -0400)]
Fix: add globally visible flag in stream
This flag is added so we can destroy it correctly with the
consumer-stream API.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 18:57:06 +0000 (14:57 -0400)]
Fix: destroy metadata stream on setup metadata error path
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 18:07:04 +0000 (14:07 -0400)]
Fix: send kernel stream to relayd only if needed
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Fri, 5 Jul 2013 17:37:01 +0000 (13:37 -0400)]
Fix: destroy streams for kernel snapshot sessions as well
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Fri, 5 Jul 2013 17:37:00 +0000 (13:37 -0400)]
Fix: close and destroy metadata stream after a kernel snapshot
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 5 Jul 2013 16:01:10 +0000 (12:01 -0400)]
Fix: print errno message on connect() error
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 4 Jul 2013 22:37:35 +0000 (18:37 -0400)]
Fix: possible double-close on stream out_fd
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 4 Jul 2013 19:54:38 +0000 (15:54 -0400)]
Fix: session ID signess to uin64_t in sessiond
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Thu, 4 Jul 2013 15:56:47 +0000 (11:56 -0400)]
Tests: fix validation trace path in kernel snapshot
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Thu, 4 Jul 2013 02:29:41 +0000 (22:29 -0400)]
Tests: Add UST snapshot local and streaming
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Tue, 18 Jun 2013 19:25:53 +0000 (15:25 -0400)]
Add UST snapshot support
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Tue, 2 Jul 2013 19:14:02 +0000 (15:14 -0400)]
Fix: consumer_add_relayd_socket() report errors to sessiond
Wait until the side-effect to relayd is actually performed before
replying that "all is fine" to sessiond.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 2 Jul 2013 19:12:42 +0000 (15:12 -0400)]
Fix: add missing enum lttcomm_return_code entries
Those should not appear as unknown.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 2 Jul 2013 20:20:33 +0000 (16:20 -0400)]
Fix: UST per-UID channels persist across application teardown
Fixes #582
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 28 Jun 2013 20:13:53 +0000 (16:13 -0400)]
Fix: kernel snapshot metadata handling and error paths
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 19:44:14 +0000 (15:44 -0400)]
Fix: coding style and debug statement
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 19:30:25 +0000 (15:30 -0400)]
Fix: put subbuffer back in kernel snapshot error path
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Wed, 12 Jun 2013 18:59:05 +0000 (14:59 -0400)]
Fix: overflow in uri_to_str_url
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 18:35:09 +0000 (14:35 -0400)]
Fix: detect the correct version of LTTng-UST
Fixes #580
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 28 Jun 2013 16:19:51 +0000 (12:19 -0400)]
Fix: sessiond: use uint64_t for all session ids
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 18:23:23 +0000 (14:23 -0400)]
Tests: add kernel snapshot streaming to root regression
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 18:22:00 +0000 (14:22 -0400)]
Tests: remove debug output from test
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 18:17:34 +0000 (14:17 -0400)]
Tests: Add kernel snapshot streaming
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 18:16:15 +0000 (14:16 -0400)]
Fix: use snapshot consumer output for kernel
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 16:07:17 +0000 (12:07 -0400)]
Fix: periodical flush check trace before stop
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 28 Jun 2013 15:26:04 +0000 (11:26 -0400)]
Fix: consumer: 64-bit index for relayd rather than 32-bit (v2)
Relayd "unique" ids wrap every 32-bit, and in some cases, negative
values are considered as error.
Change this to make the error value specifically -1ULL, use a direct
comparison (since we use an unsigned 64-bit integer, comparison with 0
becomes incorrect).
Since we now use a 64-bit ID, it is assumed to _never_ wrap-around
(remember, value -1ULL is an _error_). Therefore,
consumer_add_relayd_socket() can become much more strict than it was:
instead of accepting re-use of net_seq_idx, we can now assert that upon
LTTNG_STREAM_CONTROL socket, we have indeed allocated a relayd object,
and upon LTTNG_STREAM_DATA, we have found a relayd object.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Tue, 18 Jun 2013 22:07:21 +0000 (18:07 -0400)]
Fix UST channel/stream output assignation
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Thu, 27 Jun 2013 21:57:06 +0000 (17:57 -0400)]
Fix: send per-pid session id in channel creation
The registry indexing for per-pid sessions is done with a per-pid
session id. So for per-pid buffers, we need to send the per-pid session
id as well as the global session id to the consumer in order to give it
enough information if it needs to request metadata later.
This patch adds the session_id_per_pid to the channel creation message
and to the consumer. When the sessiond receives a metadata_request,
depending on the buffer type (per-pid or per-uid), it selects the right
id to do the registry lookup.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Conflicts:
src/bin/lttng-sessiond/consumer.c
src/bin/lttng-sessiond/consumer.h
src/bin/lttng-sessiond/ust-consumer.c
src/common/consumer.c
src/common/consumer.h
src/common/kernel-consumer/kernel-consumer.c
src/common/sessiond-comm/sessiond-comm.h
src/common/ust-consumer/ust-consumer.c
Mathieu Desnoyers [Thu, 27 Jun 2013 21:32:37 +0000 (17:32 -0400)]
Fix: consumer double-close on error
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Thu, 27 Jun 2013 21:03:29 +0000 (17:03 -0400)] 
Update URCU detection to correctly check for a 0.7 version
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
David Goulet [Fri, 28 Jun 2013 14:54:44 +0000 (10:54 -0400)]
Fix: snapshot path
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 14:39:30 +0000 (10:39 -0400)]
Add utils function to format current time as a string
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Jun 2013 14:30:18 +0000 (10:30 -0400)]
Fix: set hidden attribute to utils_* calls
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Fri, 14 Jun 2013 18:55:23 +0000 (14:55 -0400)]
Fix: consumer handling of metadata for relayd
This patch sends the metadata stream to relayd and close it once done.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 6 May 2013 19:57:24 +0000 (15:57 -0400)]
Add kernel snapshot support
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 1 May 2013 19:18:50 +0000 (15:18 -0400)]
Support flight recorder mode for a session
This adds the --no-output option to the lttng UI which will flag a
session to not set an output destination meaning that tracing will be in
overwrite mode in the buffers.
This is also the only way for now to snapshot a session, it's to put it
in no output mode.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 16 Apr 2013 17:44:09 +0000 (13:44 -0400)]
Implement snapshot commands in lttng-sessiond
Basic functionalities are implemented in the session daemon so handle
snapshots and send the command to the consumer but note that at this
commit the consumer does not handle snapshot.
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.039872 seconds and 4 git commands to generate.
projects / lttng-tools.git / log
