lttng-tools.git
3 years agoDocs: adapt the rotation client example to the API changes
Jérémie Galarneau [Wed, 15 Aug 2018 20:42:43 +0000 (16:42 -0400)] 
Docs: adapt the rotation client example to the API changes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoRemove generic error reporting from the lttng client
Jérémie Galarneau [Wed, 8 Aug 2018 21:48:24 +0000 (17:48 -0400)] 
Remove generic error reporting from the lttng client

Unsuccessful command results are reported by the lttng client
which often results in strange error messages of the form:

Error: Could not rotate ...
Error: Command error

Considering that most commands correctly report their errors,
it is safe to remove those generic error reports.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTest: session rotation schedule API
Jérémie Galarneau [Tue, 7 Aug 2018 18:33:27 +0000 (14:33 -0400)] 
Test: session rotation schedule API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agorotation-api: introduce rotation schedule descriptors
Jérémie Galarneau [Mon, 6 Aug 2018 20:36:12 +0000 (16:36 -0400)] 
rotation-api: introduce rotation schedule descriptors

The current rotation API is limited in that it imposes two types
of automatic rotation. This change introduces rotation schedules,
a more generic concept, that will eventually allow an arbitrary
number of rotation schedules to be set on a session.

Moreover, the API's design is now more aligned with the APIs
that were recently added (i.e. use of opaque descriptors for
commands that may require more parameters at some point).

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agorotation-api: pass session name explicitly
Jérémie Galarneau [Wed, 1 Aug 2018 20:49:46 +0000 (16:49 -0400)] 
rotation-api: pass session name explicitly

The session name is currently passed to the rotation API commands
through the attribute descriptors. However, the session name is
an attribute that is always required and passing it explicitly
allows users to perform immediate rotations without allocating
an immediate rotation attribute descriptor.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoSet consumer's verbosity to the max level on --verbose-consumer
Jérémie Galarneau [Fri, 20 Jul 2018 22:41:49 +0000 (18:41 -0400)] 
Set consumer's verbosity to the max level on --verbose-consumer

The consumer's verbosity is set to '1' when --verbose-consumer
is used when launching the session daemon. This means that all
DBG2/3() statements are ignored.

This commit always sets the consumer's verbosity to the maximal
level.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: Tests: use -no-pie linker option only when available
Francis Deslauriers [Tue, 10 Jul 2018 18:36:44 +0000 (14:36 -0400)] 
Fix: Tests: use -no-pie linker option only when available

Issue
=====
To keep the userspace callstack tests simple, we want to prevent the
testapp to be linked as a Position Independent Execution (PIE) binary as
it is simpler to resolve the addresses of functions. Some distributions
now ship GCC built with the --enable-default-pie option which turns on
PIE by default. To prevent that, we use the -no-pie linker flag when
building the gen-syscall-events-callstack testapp. The issue is that
this flag is not available on older version of GCC thus triggering an
error when building the project.

    gcc: error: unrecognized command line option ‘-no-pie’

Solution
========
Test for the availability of the -no-pie option at the configure time
and enable it only when found. If the option is unavailable we assume
that the -pie option is not enabled by default thus removing the need to
prevent its usage with -no-pie in the first place.

Known drawbacks
===============
None

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: check for removal of session's shm_path in destroy()
Jérémie Galarneau [Wed, 13 Jun 2018 00:13:48 +0000 (20:13 -0400)] 
Fix: check for removal of session's shm_path in destroy()

When a session is created with an explicit shm_path,
the consumer daemon will create its shared memory files
at that location and will *not* unlink them. This is normal
as the intention of that feature is to make it possible
to retrieve the content of those files should a crash occur.

To ensure the content of those files can be used, the
sessiond daemon will replicate the content of the metadata
cache in a metadata file.

On clean-up, it is expected that the consumer daemon will
unlink the shared memory files and that the session daemon
will unlink the metadata file. Then, the session's directory
in the shm path can be removed.

Unfortunately, a flaw in the design of the sessiond's and
consumerd's tear down of channels makes it impossible to
determine when the sessiond _and_ the consumerd have both
destroyed their representation of a channel. For one, the
unlinking, close, and rmdir happen in deferred 'call_rcu'
callbacks in both daemons.

However, it is also impossible for the sessiond to know when
the consumer daemon is done destroying its channel(s) since
it occurs as a reaction to the closing of the channel's file
descriptor. There is no resulting communication initiated
from the consumerd to the sessiond to confirm that the
operation is completed (and was successful).

Until this is all fixed, the session daemon checks for the
removal of the session's shm path which makes it possible
to safely advertise a session as having been destroyed.

Prior to this fix, it was not possible to reliably save
a session making use of the --shm-path option, destroy it,
and load it again. This is because the creation of the
session would fail upon seeing the session's shm path
already in existence.

Note that none of the error paths in the check for the
directory's existence return an error. This is normal
as there isn't much that can be done. The session will
be destroyed properly, except that we can't offer the
guarantee that the same session can be re-created.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoDocument the contents of the shm_path fields of the ust session registry
Jérémie Galarneau [Tue, 12 Jun 2018 21:16:32 +0000 (17:16 -0400)] 
Document the contents of the shm_path fields of the ust session registry

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoImplement MI and save/load support for callstack contexts
Francis Deslauriers [Tue, 5 Jun 2018 16:06:53 +0000 (12:06 -0400)] 
Implement MI and save/load support for callstack contexts

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTests: Add callstack contexts tests
Francis Deslauriers [Thu, 8 Jun 2017 21:15:06 +0000 (17:15 -0400)] 
Tests: Add callstack contexts tests

Tests callstack-user and callstack-kernel contexts by tracing with those
contexts an application that calls multiple functions in chain before
executing a system call.

callstack-user addresses are tested against the output of coreutils'
addr2line.
callstack-kernel addresses are tested against the addresses of kernel
symbols available in the /proc/kallsyms procfile.

Both these tests need to be run by root because those contexts are made
available by the kernel tracer. The callstack-kernel test also need to
access /proc/kallsyms.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoAdd kernel and userspace callstack event context
Francis Giraldeau [Wed, 17 Jul 2013 21:06:23 +0000 (17:06 -0400)] 
Add kernel and userspace callstack event context

LTTng callstack context. The callstack context can be added to any kernel
channel. It records either the kernel or the userspace callstack, up to a
max depth. The context is a CTF sequence, such that it uses only the space
required for the number of callstack entries.

The symbol name resolution is left to the trace reader.

Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: missing context enum values in session xml schema
Francis Deslauriers [Tue, 5 Jun 2018 14:57:48 +0000 (10:57 -0400)] 
Fix: missing context enum values in session xml schema

    Handling of the following enum are added:
        LTTNG_EVENT_CONTEXT_INTERRUPTIBLE
        LTTNG_EVENT_CONTEXT_PREEMPTIBLE
        LTTNG_EVENT_CONTEXT_NEED_RESCHEDULE
        LTTNG_EVENT_CONTEXT_MIGRATABLE

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agolttng-enable-event(1): update the Filter expression section
Philippe Proulx [Mon, 25 Sep 2017 19:18:41 +0000 (15:18 -0400)] 
lttng-enable-event(1): update the Filter expression section

This patch documents new features of filter expressions:

* Bracket and dot notations to get nested fields.
* New bitwise operators.
* Custom operator precedence table.
* Formal rules for how integers are represented for the sake of
  the evaluation (casted to signed/unsigned 64-bit integers depending
  on the operator).

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilter: document ust app ctx limitation
Mathieu Desnoyers [Mon, 25 Sep 2017 20:22:57 +0000 (16:22 -0400)] 
Filter: document ust app ctx limitation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilter: add FILTER_OP_RETURN_S64 instruction
Mathieu Desnoyers [Mon, 25 Sep 2017 13:50:49 +0000 (09:50 -0400)] 
Filter: add FILTER_OP_RETURN_S64 instruction

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilter: make bitwise and, or, xor higher prio than relational expressions
Mathieu Desnoyers [Fri, 22 Sep 2017 21:38:13 +0000 (17:38 -0400)] 
Filter: make bitwise and, or, xor higher prio than relational expressions

It seems that the usual use-case for bitwise ops are to apply them on
values rather than on the result of equality/inequality. Therefore, move
away from the C operator precedence order, and ensure bitwise and, or,
xor are higher priority than relational expressions (equality and
inequality).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilter: Update shifting tests
Mathieu Desnoyers [Fri, 22 Sep 2017 21:14:16 +0000 (17:14 -0400)] 
Filter: Update shifting tests

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoAdd () for bitwise and comparator tests
Mathieu Desnoyers [Fri, 22 Sep 2017 00:53:01 +0000 (20:53 -0400)] 
Add () for bitwise and comparator tests

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilter: Implement rshift, lshift, bit not operators
Mathieu Desnoyers [Fri, 22 Sep 2017 00:13:17 +0000 (20:13 -0400)] 
Filter: Implement rshift, lshift, bit not operators

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilters: generate backward compatible "get field" and "get context" instructions
Mathieu Desnoyers [Thu, 21 Sep 2017 20:29:10 +0000 (16:29 -0400)] 
Filters: generate backward compatible "get field" and "get context" instructions

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFilter: index array, sequences, implement bitwise binary operators
Mathieu Desnoyers [Tue, 4 Jul 2017 20:28:54 +0000 (16:28 -0400)] 
Filter: index array, sequences, implement bitwise binary operators

Add load expressions, and produce bytecode allowing indexing of array
and sequence of integers, as well as bitwise binary operators &, |, ^.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoImplement support for brackets in filter expressions
Mathieu Desnoyers [Thu, 22 Jun 2017 20:17:54 +0000 (16:17 -0400)] 
Implement support for brackets in filter expressions

Extends the bytecode with new instructions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTests: add session auto-loading test cases
Anders Wallin [Thu, 17 May 2018 20:50:41 +0000 (22:50 +0200)] 
Tests: add session auto-loading test cases

lttng-sessiond can auto load sessions at startup;
- with "--load" option to lttng-sessiond, load one file
  or all sessions files in that directory
- from session files in $LTTNG_HOME/.lttng/sessions/auto/
- from session files in $sysconfdir/lttng/sessions/auto

This test case validates the two first scenarios.

Signed-off-by: Anders Wallin <wallinux@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoReplace deprecated readdir_r() with readdir()
Michael Jeanson [Tue, 5 Jun 2018 16:11:20 +0000 (12:11 -0400)] 
Replace deprecated readdir_r() with readdir()

readdir_r() has been deprecated since glibc 2.24 [1].

We used readdir_r() in load_session_from_path() to be thread-safe
since this function is part of liblttng-ust-ctl. However, according
to readdir()'s man page, it's thread-safe as long as the directory
stream it operates on is not shared across threads :

  In the current POSIX.1 specification (POSIX.1-2008), readdir(3) is
  not required to be thread-safe. However, in modern
  implementations (including the glibc implementation), concurrent
  calls to readdir(3) that specify different directory streams are
  thread-safe. Therefore, the use of readdir_r() is generally
  unnecessary in multithreaded programs. In cases where multiple
  threads must read from the same directory stream, using readdir(3)
  with external synchronization is still preferable to the use of
  readdir_r(), for the reasons given in the points above.

In our use-case where we open the directory stream in the same function,
we know it won't be shared across threads and thus it's safe to use
readdir(). Here is the relevevant bit from the POSIX.1 [2] spec :

  The returned pointer, and pointers within the structure, might be
  invalidated or the structure or the storage areas might be overwritten
  by a subsequent call to readdir() on the same directory stream. They shall
  not be affected by a call to readdir() on a different directory stream.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=19056
[2] http://pubs.opengroup.org/onlinepubs/9699919799/functions/readdir.html

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoBash completion: ignore namespace for xmllint parsing
Jonathan Rajotte [Mon, 28 May 2018 21:31:48 +0000 (17:31 -0400)] 
Bash completion: ignore namespace for xmllint parsing

xmllint cli does not "easily" support namespace.

One can use the local_name() xpath function and other "trick".
The simplest trick for bash completion is to ignore the namespace
altogether.

Replacing "xmlns" by "ignore" does the job.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoUse https in links to the lttng.org website
Jérémie Galarneau [Tue, 5 Jun 2018 15:38:08 +0000 (11:38 -0400)] 
Use https in links to the lttng.org website

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoLog the session to which a ROTATE_PENDING command applies
Jérémie Galarneau [Thu, 10 May 2018 21:31:10 +0000 (17:31 -0400)] 
Log the session to which a ROTATE_PENDING command applies

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoInitialize relay_stream chunk_id to its session's current trace archive id
Jérémie Galarneau [Thu, 10 May 2018 21:14:39 +0000 (17:14 -0400)] 
Initialize relay_stream chunk_id to its session's current trace archive id

Initializing the relayd's streams with a stream_chunk_id allows the
relayd to differentiate between a stream created before the first
rotation (at chunk id == 0) vs. a stream that has been created
after the last (or pending) rotation.

Before this fix, the relayd can fail to identify that a rotation
has been completed.

This is caused by the fact that a stream's chunk id is initialized
to 0 and updated by the RELAYD_ROTATE_STREAM command to the
id of the chunk that is currently being rotated.

The 'stream->current_chunk_id.value < chunk_id' check performed
by the RELAYD_ROTATE_PENDING will cause rotations to never
complete for streams that are created between the launch of a
rotation and the check for its completion.

For example, when the relayd is checking whether the rotation id
'3' is completed, it may see streams with the default value of
their chunk id set to '0' and determine that a rotation is still
pending.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoPass the consumerd stream's trace archive id to the relayd
Jérémie Galarneau [Thu, 10 May 2018 19:00:34 +0000 (15:00 -0400)] 
Pass the consumerd stream's trace archive id to the relayd

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: propagate archive id to the consumer daemon on stream creation
Jérémie Galarneau [Wed, 9 May 2018 01:41:08 +0000 (21:41 -0400)] 
Fix: propagate archive id to the consumer daemon on stream creation

This is the first of a series of fixes addressing a number of problems
with the way session rotation completions handled.

Those issues can result in:
  - A stop never completing,
  - A rotation never completing,
  - A rotation being marked as completed while the consumerd/relayd
      are still writing to the completed chunk's trace archive,
      resulting in a temporarily corrupted trace.

This first commit performs a relatively simple modification
to ensure that the session's current archive id is propagated to the
consumer daemon.

Detailed description of the problems
---

At the core of the problem is the fact that in per-pid buffering, we
are not guaranteed that the sessiond will be able to see an
application's channel(s) if it was torn down before (or even during)
the rotation.

When an application is torn down, it is removed from the ust_app_ht.
That doesn't mean its buffers were received by the relayd or even
consumed by the consumerd. The session daemon issues a "flush channel"
command, but there is no guarantee/synchronization to ensure the
buffers have been consumed.

The current design assumes that the sessiond knows all the channels to
rotate and that we can monitor those channels for the completion of
a rotation. Given that an application can disappear or appear while
we iterate on the ust_app_ht, this assumption does not hold. We also
don't want to prevent/delay applications from registering or exiting
just because a rotation is ongoing.

* Problem 1 *

A rename can happen before the relay has received all data for a given
chunk, leading to the data pending issue explained previously.

Rename should be performed as the last action after the rotation
has been completed since data can still be in-flight,
causing the creation of indexes upon its arrival on the relayd's end.

See: https://github.com/lttng/lttng-tools/blob/cea6c68/src/bin/lttng-sessiond/rotation-thread.c#L392

Currently, the rotation thread waits for all channels (known to the
sessiond at the start of the rotation) to have reached their rotation
point. More specifically, the consumer will write to the
channel_rotation pipe everytime a channel's subbuffers have been read
up to the point of the rotation position. This does not guarantee that
the data has been commited to disk on the relay's end.

At that point, the command to rename the destination folder is sent to
the relayd and the sessiond checks for the pending rotation
periodically (every 200ms) if the output was to a relayd.

That check is assumed not to be needed when tracing locally since
reaching the rotation point implies the contents being written to
disk.

This scheme is not safe. If the sessiond sees no channel to iterate
on, it will issue the rename command immediately. If an application's
buffers were being flushed by the consumerd, the relayd will receive
the data, attempt to create index files, and fail since the folder has
been moved.

From an architectural standpoint, the rename command also leaves the
'path' of streams that were unknown to the sessiond pointing to a path
that does not exist anymore.

* Problem 2 *

In per-pid tracing mode, an application can appear after the rotation
was initiated and cause the rotate pending check to never complete.

A RELAYD_ROTATE_PENDING command is applied to a unique session id and
a chunk id.

When handling a RELAYD_ROTATE_PENDING commands, the relayd will perform
the following check:
- Iterate on every stream known at that point:
- Check if the stream is rotating (stream->rotate_at_seq_num != -1ULL)
- If the stream is not rotating, "stream->chunk_id < chunk_id" is checked.
- If true, the rotation is considered incomplete.

See: https://github.com/lttng/lttng-tools/blob/cea6c68/src/bin/lttng-relayd/main.c#L2850

Given that streams, at their creation, are initialized with their
current "chunk_id" set to 0, the rotation will never be considered
complete if a stream is created between a ROTATE_STREAM and
ROTATE_PENDING command.

This can happen whenever an application is registered during a rotation.

* Problem 3 *

Since the sessiond can't accurately monitor the channels that have to
be rotated, the "rotation completed" notification (and state, if
queried with the lttng_rotation_handle_get_state() interface) is not
reliable.

A client could see that the rotation is marked as completed and
attempt to read a trace archive that has not been completely written.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTypo in ust consumer log message (channek -> channel)
Jérémie Galarneau [Mon, 4 Jun 2018 21:28:56 +0000 (17:28 -0400)] 
Typo in ust consumer log message (channek -> channel)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoUse dynamic payload for the add stream realyd command
Jonathan Rajotte [Thu, 10 May 2018 15:02:25 +0000 (11:02 -0400)] 
Use dynamic payload for the add stream realyd command

Move away from static constant defined char array.

Keep backward compatibility.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoDynamic payload for relayd create session command
Jonathan Rajotte [Thu, 10 May 2018 14:13:22 +0000 (10:13 -0400)] 
Dynamic payload for relayd create session command

Move away from static constant defined char array.

Perform the length check based on constant defined value on reception.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: backward relayd communication compatibility.
Jonathan Rajotte [Tue, 8 May 2018 21:23:48 +0000 (17:23 -0400)] 
Fix: backward relayd communication compatibility.

The size of LTTNG_HOST_NAME_MAX changed from 64 to 256 in commit id
b867041c62b48e89c9f00430cde4c33f13a2da09.

This change result in breaking compatibility with older relayd.

Freeze size of struct used for relayd communication.

Confirmed by lttng-ivc project.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoAdd unused attribute to lttng_to_index_major param
Jérémie Galarneau [Mon, 4 Jun 2018 16:50:51 +0000 (12:50 -0400)] 
Add unused attribute to lttng_to_index_major param

Suppresses an unused variable warning. The parameter is kept
since this does depend on the connection's full version. the
'minor' parameter is unused for now since there is only one
major version to support and only one major index version.

However, this could change in the future and we don't want to
have to modify all the version conversion sites.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoReplace strncpy by lttng_strncpy in lttngctl session configuration API
Jérémie Galarneau [Mon, 4 Jun 2018 15:27:37 +0000 (11:27 -0400)] 
Replace strncpy by lttng_strncpy in lttngctl session configuration API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoReplace strncpy by lttng_strncpy in utils_stream_file_name()
Jérémie Galarneau [Mon, 4 Jun 2018 15:27:08 +0000 (11:27 -0400)] 
Replace strncpy by lttng_strncpy in utils_stream_file_name()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoUse dynamic buffer to build session configuration path
Jérémie Galarneau [Mon, 4 Jun 2018 15:24:26 +0000 (11:24 -0400)] 
Use dynamic buffer to build session configuration path

Re-use the dynamic buffer interface to build the session
configuration path. The main benefit here is silencing a source
string truncation warning emitted by GCC 8. However, this
interface is also simpler to use than manually building the
path.

The LTTNG_PATH_MAX is still enforced, but there is no real
need to restrict paths to that size. This could be removed if
it ever poses a problem.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoReplace strncpy by lttng_strncpy in session config
Jérémie Galarneau [Mon, 4 Jun 2018 15:23:18 +0000 (11:23 -0400)] 
Replace strncpy by lttng_strncpy in session config

This eliminates a warning produced by GCC 8 in that repeated
code pattern (potential truncation of the source string) and
using the lttng_strncpy macro reduces code duplication.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoSilence strncpy warning emitted by GCC 8 in XSD path construction
Jérémie Galarneau [Fri, 1 Jun 2018 17:01:42 +0000 (13:01 -0400)] 
Silence strncpy warning emitted by GCC 8 in XSD path construction

The size of the XSD's path is fully determined in this function
which makes strcpy() safe to use.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoSilence strncpy warning emitted by GCC 8 in lttng_strncpy()
Jérémie Galarneau [Fri, 1 Jun 2018 16:54:00 +0000 (12:54 -0400)] 
Silence strncpy warning emitted by GCC 8 in lttng_strncpy()

GCC 8 warns if the destination's length is passed to strncpy,
since that could cause the destination to not be NULL-terminated.

This is not a concern for the lttng_strncpy since it checks
that the source must not be truncated. Therefore, it is safe
to simply use strcpy().

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoSilence strncpy warning emitted by GCC 8 in ini parser
Jérémie Galarneau [Fri, 1 Jun 2018 16:50:40 +0000 (12:50 -0400)] 
Silence strncpy warning emitted by GCC 8 in ini parser

While copying 'dst len' bytes in strncpy is normally risky
as the dst may not be NULL-terminated, this function ensures
that the last byte of 'dst' is NULL.

Therefore, this change is mostly made to silence GCC.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: use signed variable for refcounting of consumer_relayd_sock_pair
Jonathan Rajotte [Wed, 14 Mar 2018 18:54:21 +0000 (14:54 -0400)] 
Fix: use signed variable for refcounting of consumer_relayd_sock_pair

Otherwise refcount check after decreasing have no meaning as in
consumer_stream_relayd_close function.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: sobjd is never used by reply_ust_register_channel()
Jonathan Rajotte [Wed, 14 Mar 2018 17:46:09 +0000 (13:46 -0400)] 
Cleanup: sobjd is never used by reply_ust_register_channel()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: chan is never used by save_agent_events()
Jonathan Rajotte [Wed, 14 Mar 2018 17:29:56 +0000 (13:29 -0400)] 
Cleanup: chan is never used by save_agent_events()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: open_memstream and close_memstream compat is never used
Jonathan Rajotte [Wed, 14 Mar 2018 17:26:46 +0000 (13:26 -0400)] 
Cleanup: open_memstream and close_memstream compat is never used

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
3 years agoRemove unnecessary inclusions of version.h
Jérémie Galarneau [Fri, 1 Jun 2018 09:31:12 +0000 (05:31 -0400)] 
Remove unnecessary inclusions of version.h

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoAdd multilib test files to .gitignore
Jérémie Galarneau [Fri, 1 Jun 2018 09:28:45 +0000 (05:28 -0400)] 
Add multilib test files to .gitignore

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: ua_sess is never used create_ust_app_channel_context()
Jonathan Rajotte [Tue, 13 Mar 2018 22:23:26 +0000 (18:23 -0400)] 
Cleanup: ua_sess is never used create_ust_app_channel_context()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: consumer_data is never used by update_kernel_stream()
Jonathan Rajotte [Tue, 13 Mar 2018 22:21:14 +0000 (18:21 -0400)] 
Cleanup: consumer_data is never used by update_kernel_stream()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: app is never used by alloc_ust_app_session()
Jonathan Rajotte [Tue, 13 Mar 2018 22:19:48 +0000 (18:19 -0400)] 
Cleanup: app is never used by alloc_ust_app_session()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: ust_session_id unused by buffer_reg_uid_consumer_channel_key
Jonathan Rajotte [Tue, 13 Mar 2018 22:19:32 +0000 (18:19 -0400)] 
Cleanup: ust_session_id unused by buffer_reg_uid_consumer_channel_key

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: wpipe already contain kernel_tracer_fd
Jonathan Rajotte [Tue, 13 Mar 2018 22:13:39 +0000 (18:13 -0400)] 
Cleanup: wpipe already contain kernel_tracer_fd

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: domain type is never used by send_consumer_relayd_socket()
Jonathan Rajotte [Tue, 13 Mar 2018 22:06:57 +0000 (18:06 -0400)] 
Cleanup: domain type is never used by send_consumer_relayd_socket()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: uid and gid are never used by run_as_noworker()
Jonathan Rajotte [Tue, 13 Mar 2018 21:41:34 +0000 (17:41 -0400)] 
Cleanup: uid and gid are never used by run_as_noworker()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: sessiond_id is never used by relayd_create_session_2_*
Jonathan Rajotte [Tue, 13 Mar 2018 21:37:10 +0000 (17:37 -0400)] 
Cleanup: sessiond_id is never used by relayd_create_session_2_*

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: sock is never used by ask_channel()
Jonathan Rajotte [Tue, 13 Mar 2018 19:06:43 +0000 (15:06 -0400)] 
Cleanup: sock is never used by ask_channel()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: ctx is never used by monitor_timer()
Jonathan Rajotte [Tue, 13 Mar 2018 18:40:26 +0000 (14:40 -0400)] 
Cleanup: ctx is never used by monitor_timer()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: signo is never used by metadata_switch_timer
Jonathan Rajotte [Tue, 13 Mar 2018 18:39:00 +0000 (14:39 -0400)] 
Cleanup: signo is never used by metadata_switch_timer

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: channel is never used by metadata_cache_check_version()
Jonathan Rajotte [Tue, 13 Mar 2018 18:27:24 +0000 (14:27 -0400)] 
Cleanup: channel is never used by metadata_cache_check_version()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: relayd id is never used by write_relayd_metadata_id()
Jonathan Rajotte [Tue, 13 Mar 2018 16:56:12 +0000 (12:56 -0400)] 
Cleanup: relayd id is never used by write_relayd_metadata_id()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: attr is not used by open_ust_stream_fd()
Jonathan Rajotte [Tue, 13 Mar 2018 16:48:43 +0000 (12:48 -0400)] 
Cleanup: attr is not used by open_ust_stream_fd()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: *_domain are never used by create_session
Jonathan Rajotte [Tue, 13 Mar 2018 16:48:22 +0000 (12:48 -0400)] 
Cleanup: *_domain are never used by create_session

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agodoc/man: update rotation man pages to follow API's terminology
Philippe Proulx [Thu, 17 May 2018 18:29:17 +0000 (14:29 -0400)] 
doc/man: update rotation man pages to follow API's terminology

"Manual rotation" becomes "immediate rotation".

"Automatic rotation schedule" becomes "rotation schedule". We still
write "automatic rotation" as the result of a rotation schedule being
fulfilled by its condition.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoPrint consumerd32/64/kernel configuration
Jonathan Rajotte [Mon, 28 May 2018 20:51:17 +0000 (16:51 -0400)] 
Print consumerd32/64/kernel configuration

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTest: change use of space for tabs in utils.sh
Jérémie Galarneau [Tue, 29 May 2018 18:10:03 +0000 (14:10 -0400)] 
Test: change use of space for tabs in utils.sh

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTests: add duplicated providers tests
Francis Deslauriers [Fri, 9 Feb 2018 21:56:52 +0000 (16:56 -0500)] 
Tests: add duplicated providers tests

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTests: add function to validate the number of an event name in metadata
Francis Deslauriers [Fri, 9 Feb 2018 21:56:51 +0000 (16:56 -0500)] 
Tests: add function to validate the number of an event name in metadata

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTests: allow the use of regular expressions to match events
Francis Deslauriers [Fri, 9 Feb 2018 21:56:50 +0000 (16:56 -0500)] 
Tests: allow the use of regular expressions to match events

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: calling ht_{hash, match}_enum with wrong argument
Francis Deslauriers [Fri, 9 Feb 2018 21:56:49 +0000 (16:56 -0500)] 
Fix: calling ht_{hash, match}_enum with wrong argument

ht_hash_enum and ht_match_enum are currently called with the address of the
pointer to a ust_registry_enum rather than the expected pointer to a
ust_registry_enum. This means that those function calls would end up
using garbage for hashing and comparing.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: probes should be compared strictly by events metadata
Francis Deslauriers [Fri, 9 Feb 2018 21:56:48 +0000 (16:56 -0500)] 
Fix: probes should be compared strictly by events metadata

Currently, events are compared using names and signatures. Events
with different payloads but identical name and signatures could
lead to corrupted trace because the Session Daemon would consider them
identical and give them the same event ID.

Events should be compared using the name, loglevel, fields and
model_emf_uri to ensure that their respective metadata is the same.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTest for lttng-logger
Julien Desfossez [Wed, 10 Jan 2018 19:49:20 +0000 (14:49 -0500)] 
Test for lttng-logger

Basic test to write in /proc/lttng-logger and /dev/lttng-logger and
ensure we have the right amount of events in the trace resulting trace.
We also test the 1024 characters limit for the payload.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoTest mi: rename sessiond load directory constant
Jérémie Galarneau [Sat, 26 May 2018 09:43:53 +0000 (05:43 -0400)] 
Test mi: rename sessiond load directory constant

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agomi: support "add-context --list"
Jonathan Rajotte [Wed, 28 Feb 2018 21:06:01 +0000 (16:06 -0500)] 
mi: support "add-context --list"

The symbol element is the string passed/to be passed on the cli
for the --type option.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
3 years agoFix: test_ust-dl is generated at configure-time
Francis Deslauriers [Tue, 6 Feb 2018 17:04:27 +0000 (12:04 -0500)] 
Fix: test_ust-dl is generated at configure-time

This file should not be in EXTRA_DIST as it's generated by autoconf and
will thus be available directly in the out-of-tree build directory.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: cmd line options overwrite env variable config options
Jonathan Rajotte [Fri, 18 May 2018 21:45:57 +0000 (17:45 -0400)] 
Fix: cmd line options overwrite env variable config options

The doc is clear about the order of precedence regarding configuration.

The command line options always override any config file or
configuration by environment variables.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: perform the initialization memory barrier out of loop body
Jérémie Galarneau [Fri, 18 May 2018 19:08:14 +0000 (15:08 -0400)] 
Fix: perform the initialization memory barrier out of loop body

The memory barrier used by the client thread should be performed
after the lttng_sessiond_ready counter has been seen to have
reached zero.

This ensures that loads are not speculatively performed before
this point as the thread will interact with data structures
initialized by the support threads for which it was waiting for
the initialization to complete.

See the comment as to why this read barrier is promoted to a
full barrier.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoClean-up: explicit mb before decrementing lttng_sessiond_ready
Jérémie Galarneau [Fri, 18 May 2018 19:03:13 +0000 (15:03 -0400)] 
Clean-up: explicit mb before decrementing lttng_sessiond_ready

This is mostly a documentation fix as there are no thread-safety
implications to this change. uatomic_sub_return() was used since it
performs a full memory barrier before and after the atomic operation
(as per the urcu documentation).

The barrier performed after the substraction is not needed in this
particular case. Moreover, using an explicit cmm_smp_mb() statement
makes the code clearer; see the comment as to why this barrier is
needed.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoClean-up: use a define for support thread count
Jérémie Galarneau [Fri, 18 May 2018 19:02:17 +0000 (15:02 -0400)] 
Clean-up: use a define for support thread count

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoPort: fix format warnings on Cygwin
Michael Jeanson [Tue, 15 May 2018 20:19:49 +0000 (16:19 -0400)] 
Port: fix format warnings on Cygwin

On Cygwin, be64toh() returns a "long long unsigned int" while the
format specifier PRIu64 expects a "long unsigned int". Both types
are 64bits integers, just cast the result to uint64_t to silence
the warnings.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoAdd missing include for ssize_t on Cygwin
Michael Jeanson [Tue, 15 May 2018 20:19:48 +0000 (16:19 -0400)] 
Add missing include for ssize_t on Cygwin

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: sessions with agent channels fail to load
Jérémie Galarneau [Wed, 16 May 2018 22:32:38 +0000 (18:32 -0400)] 
Fix: sessions with agent channels fail to load

Channels of the "agent" types cannot be created directly. They are
meant to be created implicitly through the activation of events in
their domain.

However, a user can override the default channel configuration
attributes by creating the underlying UST channel before enabling an
agent domain event.

Hence, the channel's type is substituted before the creation and
restored by the time events are created.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: don't wait for the load thread before serving client commands
Jérémie Galarneau [Wed, 16 May 2018 21:08:36 +0000 (17:08 -0400)] 
Fix: don't wait for the load thread before serving client commands

Since the session loading thread uses the same communication than
the external clients, it should not be included in the set of
threads that must be launched before the sessiond starts to serve
client commands.

Since the "load session" thread is guaranteed to be the last
essential thread to be initialized, it can explicitly signal
the parents that the sessiond is ready once it is done auto-loading
session configurations.

This commit also adds a lengthy comment explaining the initialization
of the session daemon.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoAdd test_utils_parse_time_suffix to .gitignore
Jérémie Galarneau [Wed, 16 May 2018 15:51:52 +0000 (11:51 -0400)] 
Add test_utils_parse_time_suffix to .gitignore

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoClean-up: kernel_consumer_add_stream() does not need to be public
Jérémie Galarneau [Wed, 9 May 2018 01:38:57 +0000 (21:38 -0400)] 
Clean-up: kernel_consumer_add_stream() does not need to be public

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: sessiond fails to launch on --without-ust configuration
Jérémie Galarneau [Wed, 9 May 2018 01:26:15 +0000 (21:26 -0400)] 
Fix: sessiond fails to launch on --without-ust configuration

The sessiond will never signal that it is ready (in daemonize or
background modes) if it was built without lttng-ust. The fix in
7eac7803 made the main thread wait for the agent thread to be
ready before signalling that the session daemon is ready.

When agent tracing is not possible due to the absence of lttng-ust,
a stub function is used to launch the agent thread. This stub
must call sessiond_notify_ready() in order to unblock the main
thread.

Note that it would be _incorrect_ to not wait for the agent
thread to be launched as users expect all tracing features to
be available as soon as 'lttng-sessiond --daemonize/--background'
returns.

Not waiting for the thread to be ready caused very rare failures
of the agent tracing tests on the CI, especially on ARM and
PowerPC targets.

Reported-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: agent thread poll set creation failure results in deadlock
Jérémie Galarneau [Wed, 9 May 2018 01:23:14 +0000 (21:23 -0400)] 
Fix: agent thread poll set creation failure results in deadlock

Failing to initialize the agent thread's pollset will cause
the thread to exit before calling sessiond_notify_ready().

This will cause the main thread to wait forever for all threads
to be launched when such an error occurs.

The agent thread is not needed for the sessiond to work (except
to enable the tracing of Java and Python applications). Such
a failure should leave the sessiond in a useable state.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoFix: test uses sizeof() on the wrong operand of strncpy
Jérémie Galarneau [Wed, 9 May 2018 01:22:36 +0000 (21:22 -0400)] 
Fix: test uses sizeof() on the wrong operand of strncpy

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoRename kernel_consumer_send_channel_stream()
Jérémie Galarneau [Tue, 8 May 2018 16:11:19 +0000 (12:11 -0400)] 
Rename kernel_consumer_send_channel_stream()

kernel_consumer_send_channel_stream() sends _all_ streams of
a given channel. It is renamed kernel_consumer_send_channel_streams()
to ensure its name is no longer misleading.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoRename consumer_init_channel_comm_msg()
Jérémie Galarneau [Tue, 8 May 2018 16:07:58 +0000 (12:07 -0400)] 
Rename consumer_init_channel_comm_msg()

consumer_init_channel_comm_msg() is only used for the ADD_CHANNEL
command. It is therefore renamed to
consumer_init_add_channel_comm_msg()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: send_fds functions are not const-correct
Jérémie Galarneau [Tue, 8 May 2018 16:00:41 +0000 (12:00 -0400)] 
Cleanup: send_fds functions are not const-correct

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoRemove unused ltt_session look-up result
Jérémie Galarneau [Thu, 3 May 2018 20:06:11 +0000 (16:06 -0400)] 
Remove unused ltt_session look-up result

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoClean-up: reduce indentation level of create_channel_per_uid()
Jérémie Galarneau [Thu, 3 May 2018 18:57:07 +0000 (14:57 -0400)] 
Clean-up: reduce indentation level of create_channel_per_uid()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoEnforce locking assumptions during channel creation
Jérémie Galarneau [Thu, 3 May 2018 18:35:24 +0000 (14:35 -0400)] 
Enforce locking assumptions during channel creation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: misleading create_ust_app_session() name
Jérémie Galarneau [Wed, 2 May 2018 21:43:48 +0000 (17:43 -0400)] 
Cleanup: misleading create_ust_app_session() name

create_ust_app_session() does not necessarily create an
ust_app_session; it will look for an existing one and return it
and only create one if it fails to do so.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoRename rotate_count to current_archive_id
Jérémie Galarneau [Wed, 2 May 2018 19:27:37 +0000 (15:27 -0400)] 
Rename rotate_count to current_archive_id

The ltt_session's rotate count will no longer be used only to
count the number of rotations. It will be used to tag streams
with a "trace archive chunk id" that indicates the epoch of
their creation.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoCleanup: name of send_sessiond_channel() is misleading
Jérémie Galarneau [Wed, 2 May 2018 18:39:14 +0000 (14:39 -0400)] 
Cleanup: name of send_sessiond_channel() is misleading

This function sends a channel to the sessiond _and_ to the
relay daemon (if applicable).

Comments are updated to reflect this change and the publication
of streams towards the relay daemon is now logged.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoPrint the git version used to build from a distribution tarball
Michael Jeanson [Fri, 27 Apr 2018 21:27:29 +0000 (17:27 -0400)] 
Print the git version used to build from a distribution tarball

The git version is omitted when building from a distribution
tarball. This will cause 'lttng version' and 'lttng --version'
to print the state of the git tree which produced the tarball.

git describe is used to produce the description of the tree's
state, along with the "dirty" state (whether or not local
changes were present in the tree).

Note that the 'git version' will not be printed when the
distribution tarball was produced at a release tag (a tag
starting with v[0-9]).

This patch simplifies the generation of the version.h file by
generating a file that is merely included by version.h.

It also ensures that version.tmpl is no longer installed on the
system by the install target.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
3 years agoDocs: lttng-version uses the intransitive form of "broke"
Jérémie Galarneau [Tue, 1 May 2018 19:22:57 +0000 (15:22 -0400)] 
Docs: lttng-version uses the intransitive form of "broke"

To indicate that something is divided, the transitive form
"broken down" is preferred.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.069255 seconds and 4 git commands to generate.