lttng-tools.git
8 years agoAdd core dump snapshot handler script
Christian Babeux [Fri, 19 Jul 2013 20:12:49 +0000 (16:12 -0400)] 
Add core dump snapshot handler script

This is a custom core dump program that will be called when a core dump
occurs.  The program will save the core data in CORE_PATH and also, if a
root session daemon is running, will record a snapshot of tracing data
using the lttng command line utility.

Refer to README for installation and testing instructions.

Sample output of test script:

Setup...
Spawning a session daemon
Session auto-20130626-224838 created.
Kernel channel chan enabled for session auto-20130626-224838
kernel event sched_switch created in channel chan
Tracing started for session auto-20130626-224838
Sleeping...
Crashing...
./test.sh: line 35: 16980 Segmentation fault      (core dumped)
$(dirname $0)/crash
Waiting for data availability
Tracing stopped for session auto-20130626-224838
Session auto-20130626-224838 destroyed
Core dump and snapshot will be available in /tmp/lttng/{core,snapshot}.

/tmp/lttng
|-- core
|   `-- core.16980
`-- snapshot
    `-- snapshot
        |-- chan_0
        |-- chan_1
        |-- chan_2
        |-- chan_3
        |-- chan_4
        |-- chan_5
        |-- chan_6
        |-- chan_7
        `-- metadata

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: sym name len (kernel)
Mathieu Desnoyers [Fri, 19 Jul 2013 18:43:05 +0000 (14:43 -0400)] 
Fix: sym name len (kernel)

Use kernel and not UST sym name len for kernel tracing. Fixed build when
UST is disabled.

Fix bug introduced in 2.3-rc dev cycle by:

commit 850767541647c102a299d7fbc39c97555ac70224
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date:   Fri Jul 19 09:04:29 2013 -0400

    Fix: (slight UI change) refuse missing -c if non-default channel exists

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: tests: provide channel name when a non-default channel exists: per-pid
Mathieu Desnoyers [Fri, 19 Jul 2013 18:06:14 +0000 (14:06 -0400)] 
Fix: tests: provide channel name when a non-default channel exists: per-pid

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: tests: provide channel name when a non-default channel exists
Mathieu Desnoyers [Fri, 19 Jul 2013 17:59:39 +0000 (13:59 -0400)] 
Fix: tests: provide channel name when a non-default channel exists

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: data pending race
Mathieu Desnoyers [Fri, 19 Jul 2013 17:28:13 +0000 (13:28 -0400)] 
Fix: data pending race

There is a data pending race involving late population of the streams in
the stream hash table, and applying flush on streams that are not yet
globally visible.

This is caused by the fact that streams are added to the hash table only
when received by the data-handling consumer thread.

This results in data_pending() incorrectly returning that there is no
data pending in some cases.

This has been discovered by adding 1s delay in read subbuffer function
for testing.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix hang in make check snapshots/test_ust
Julien Desfossez [Fri, 19 Jul 2013 16:36:15 +0000 (12:36 -0400)] 
Fix hang in make check snapshots/test_ust

Missing a kill of the test app at the end of
test_ust_1000_local_snapshots.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoCleanup: ust-consumer: wrong indentation
Mathieu Desnoyers [Fri, 19 Jul 2013 15:29:14 +0000 (11:29 -0400)] 
Cleanup: ust-consumer: wrong indentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: print dots while waiting for data availability
Mathieu Desnoyers [Fri, 19 Jul 2013 14:36:52 +0000 (10:36 -0400)] 
Fix: print dots while waiting for data availability

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: remove sleep(1) added by "Fix: (slight UI change) refuse missing -c if non-defau...
Mathieu Desnoyers [Fri, 19 Jul 2013 14:04:12 +0000 (10:04 -0400)] 
Fix: remove sleep(1) added by "Fix: (slight UI change) refuse missing -c if non-default channel exists"

For debugging, added by mistake.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: (slight UI change) refuse missing -c if non-default channel exists
Mathieu Desnoyers [Fri, 19 Jul 2013 13:04:29 +0000 (09:04 -0400)] 
Fix: (slight UI change) refuse missing -c if non-default channel exists

After a user creates a channel within a session, creating a "default"
channel if a user forgets to put "-c channel_name" in the following
add-context, enable-event, disable-event commands is misleading.  The
natural expected behavior would be that the command would apply the the
last enabled channel (notion of a "current" channel, like we have for
sessions), but certainly not that it creates a new channel with default
attributes behind the user's back.

An intermediate fix that would not require to keep a notion of current
channel is to refuse creation of a default channel if at least one
non-default channel has already been created in the session.

This commit affects enable-event, disable-event and add-context
commands.

This fix belongs to the 2.3-rc cycle, and cannot be backported, since
it:

a) changes the user interface of lttng (returns an error in the case
   where -c name is missing and the session contains an non-default
   channel)
b) changes the ABI between lttng-ctl and sessiond: a default channel is
   now expressed as an empty string ('\0') rather than by "channel0",
   which allows making the difference between an explicit "channel0"
   channel and a default channel in the session daemon.

Fixes #522

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: push metadata on stop for per-UID buffers
Mathieu Desnoyers [Fri, 19 Jul 2013 12:59:12 +0000 (08:59 -0400)] 
Fix: push metadata on stop for per-UID buffers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoREADME: update python documentation
Mathieu Desnoyers [Thu, 18 Jul 2013 15:17:26 +0000 (11:17 -0400)] 
README: update python documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: other layout cleanups
Mathieu Desnoyers [Thu, 18 Jul 2013 14:41:51 +0000 (10:41 -0400)] 
Manpage: other layout cleanups

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of view
Mathieu Desnoyers [Thu, 18 Jul 2013 14:38:31 +0000 (10:38 -0400)] 
Manpage: cleanup layout of view

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of version
Mathieu Desnoyers [Thu, 18 Jul 2013 14:37:01 +0000 (10:37 -0400)] 
Manpage: cleanup layout of version

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of stop
Mathieu Desnoyers [Thu, 18 Jul 2013 14:35:59 +0000 (10:35 -0400)] 
Manpage: cleanup layout of stop

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of start
Mathieu Desnoyers [Thu, 18 Jul 2013 14:34:48 +0000 (10:34 -0400)] 
Manpage: cleanup layout of start

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of snapshot
Mathieu Desnoyers [Thu, 18 Jul 2013 14:33:17 +0000 (10:33 -0400)] 
Manpage: cleanup layout of snapshot

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of set-session
Mathieu Desnoyers [Thu, 18 Jul 2013 14:25:43 +0000 (10:25 -0400)] 
Manpage: cleanup layout of set-session

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of list
Mathieu Desnoyers [Thu, 18 Jul 2013 14:23:47 +0000 (10:23 -0400)] 
Manpage: cleanup layout of list

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of disable-event
Mathieu Desnoyers [Thu, 18 Jul 2013 14:19:38 +0000 (10:19 -0400)] 
Manpage: cleanup layout of disable-event

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of disable-channel
Mathieu Desnoyers [Thu, 18 Jul 2013 14:17:24 +0000 (10:17 -0400)] 
Manpage: cleanup layout of disable-channel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of enable-event
Mathieu Desnoyers [Thu, 18 Jul 2013 14:15:02 +0000 (10:15 -0400)] 
Manpage: cleanup layout of enable-event

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of enable-channel
Mathieu Desnoyers [Thu, 18 Jul 2013 14:05:52 +0000 (10:05 -0400)] 
Manpage: cleanup layout of enable-channel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of destroy
Mathieu Desnoyers [Thu, 18 Jul 2013 13:50:39 +0000 (09:50 -0400)] 
Manpage: cleanup layout of destroy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of create
Mathieu Desnoyers [Thu, 18 Jul 2013 13:44:53 +0000 (09:44 -0400)] 
Manpage: cleanup layout of create

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of calibrate
Mathieu Desnoyers [Thu, 18 Jul 2013 13:34:51 +0000 (09:34 -0400)] 
Manpage: cleanup layout of calibrate

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoManpage: cleanup layout of add-context
Mathieu Desnoyers [Thu, 18 Jul 2013 13:25:33 +0000 (09:25 -0400)] 
Manpage: cleanup layout of add-context

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoDocumentation: create --snapshot in manpage
Mathieu Desnoyers [Thu, 18 Jul 2013 13:11:29 +0000 (09:11 -0400)] 
Documentation: create --snapshot in manpage

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoVersion 2.3.0-rc1 v2.3.0-rc1
Mathieu Desnoyers [Thu, 18 Jul 2013 02:23:27 +0000 (22:23 -0400)] 
Version 2.3.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: add missing snapshot header to dist tarball
Mathieu Desnoyers [Thu, 18 Jul 2013 02:22:51 +0000 (22:22 -0400)] 
Fix: add missing snapshot header to dist tarball

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoDocumentation: fix thread quit pipe comment
Mathieu Desnoyers [Thu, 18 Jul 2013 02:02:02 +0000 (22:02 -0400)] 
Documentation: fix thread quit pipe comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTest for presence of bison and flex when building from git
Yannick Brosseau [Wed, 17 Jul 2013 18:00:34 +0000 (14:00 -0400)] 
Test for presence of bison and flex when building from git

[ Update by Mathieu Desnoyers: handle VPATH build from tarball
  by prefixing path with $srcdir. ]

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTest UST snapshot with large metadata
Julien Desfossez [Wed, 17 Jul 2013 17:44:47 +0000 (13:44 -0400)] 
Test UST snapshot with large metadata

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd test application with large metadata
Julien Desfossez [Wed, 17 Jul 2013 17:43:18 +0000 (13:43 -0400)] 
Add test application with large metadata

This application generates 5 tracepoints with a lot of parameters. The
resulting metadata is >12kB which is useful to test the behaviour of the
UST metadata cache and the flushing mechanism when there is more than
one metadata packet.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoCleanup: remove redundant assignment
Mathieu Desnoyers [Wed, 17 Jul 2013 17:40:15 +0000 (13:40 -0400)] 
Cleanup: remove redundant assignment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: use per-uid buffer registry for UID buffer snapshots
Mathieu Desnoyers [Tue, 16 Jul 2013 17:29:30 +0000 (13:29 -0400)] 
Fix: use per-uid buffer registry for UID buffer snapshots

Fixes empty traces when doing a snapshot after killing a single traced
application.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agocmd.c: fix typos in snapshot commands
Mathieu Desnoyers [Tue, 16 Jul 2013 16:44:08 +0000 (12:44 -0400)] 
cmd.c: fix typos in snapshot commands

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTest snapshot per-uid post-mortem
Julien Desfossez [Tue, 16 Jul 2013 15:07:01 +0000 (11:07 -0400)] 
Test snapshot per-uid post-mortem

Test to check if we can take a snapshot after a traced application
exited when using per-uid buffers.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove leftover fprintf
Mathieu Desnoyers [Tue, 16 Jul 2013 14:50:34 +0000 (10:50 -0400)] 
Remove leftover fprintf

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix deadlock: don't take channel lock in timer
Mathieu Desnoyers [Tue, 16 Jul 2013 13:53:33 +0000 (09:53 -0400)] 
Fix deadlock: don't take channel lock in timer

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoIntroduce channel timer lock
Mathieu Desnoyers [Tue, 16 Jul 2013 13:36:59 +0000 (09:36 -0400)] 
Introduce channel timer lock

Currently a shadow of the channel lock. Will eventually be used to
protect channel timer handler from concurrent channel updates without
being held when the timer is stopped (future commit).

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agodocument lttng_ustconsumer_request_metadata locking constraints
Mathieu Desnoyers [Tue, 16 Jul 2013 01:47:21 +0000 (21:47 -0400)] 
document lttng_ustconsumer_request_metadata locking constraints

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoconsumer: remove unused lttng_ustconsumer_push_metadata
Mathieu Desnoyers [Tue, 16 Jul 2013 01:28:23 +0000 (21:28 -0400)] 
consumer: remove unused lttng_ustconsumer_push_metadata

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoDocument metadata_socket_lock nesting
Mathieu Desnoyers [Tue, 16 Jul 2013 01:19:19 +0000 (21:19 -0400)] 
Document metadata_socket_lock nesting

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agolttng_ustconsumer_recv_metadata does not need all those locks
Mathieu Desnoyers [Tue, 16 Jul 2013 01:17:06 +0000 (21:17 -0400)] 
lttng_ustconsumer_recv_metadata does not need all those locks

Since lttng_ustconsumer_recv_metadata() does not push data into the
stream anymore, it only needs the metadata cache lock.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agodocument metadata_switch_timer() deadlock
Mathieu Desnoyers [Tue, 16 Jul 2013 01:15:05 +0000 (21:15 -0400)] 
document metadata_switch_timer() deadlock

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: add missing metadata socket lock
Mathieu Desnoyers [Tue, 16 Jul 2013 01:06:07 +0000 (21:06 -0400)] 
Fix: add missing metadata socket lock

Protect metadata socket, which can be accessed concurrently by the
metadata timer and by snapshot.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agodocument metadata_switch_timer() locking constraints
Mathieu Desnoyers [Tue, 16 Jul 2013 00:56:51 +0000 (20:56 -0400)] 
document metadata_switch_timer() locking constraints

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoconsumer: remove timeout for UST metadata
Mathieu Desnoyers [Tue, 16 Jul 2013 00:53:04 +0000 (20:53 -0400)] 
consumer: remove timeout for UST metadata

Remove time out for UST metadata by generating metadata packets whenever
they are about to be read from the ring buffer rather than filling them
when the metadata cache is updated, which requires a time out, and
therefore may fail.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoIntroduce pipe for UST metadata cache and stream
Mathieu Desnoyers [Tue, 16 Jul 2013 00:22:48 +0000 (20:22 -0400)] 
Introduce pipe for UST metadata cache and stream

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoconsumer: replace DBG2() instances by DBG()
Mathieu Desnoyers [Tue, 16 Jul 2013 00:18:13 +0000 (20:18 -0400)] 
consumer: replace DBG2() instances by DBG()

The consumer daemon does not currently support DBG2() printout.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoIntroduce utils_create_pipe_cloexec_nonblock()
Mathieu Desnoyers [Tue, 16 Jul 2013 00:16:07 +0000 (20:16 -0400)] 
Introduce utils_create_pipe_cloexec_nonblock()

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoust consumer: data_pending check is endpoint active
Mathieu Desnoyers [Tue, 16 Jul 2013 00:14:07 +0000 (20:14 -0400)] 
ust consumer: data_pending check is endpoint active

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: kernel consumer: data_pending check if endpoint active
Mathieu Desnoyers [Tue, 16 Jul 2013 00:12:30 +0000 (20:12 -0400)] 
Fix: kernel consumer: data_pending check if endpoint active

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoconsumer: explicitly set endpoint status to active at init
Mathieu Desnoyers [Tue, 16 Jul 2013 00:07:36 +0000 (20:07 -0400)] 
consumer: explicitly set endpoint status to active at init

Ensures we explicitly set active at init for channels that don't
interact with a relayd.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agodocument consumer_metadata_cache_flushed use of consumer_data.lock
Mathieu Desnoyers [Tue, 16 Jul 2013 00:03:15 +0000 (20:03 -0400)] 
document consumer_metadata_cache_flushed use of consumer_data.lock

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoconsumer: introduce channel lock
Mathieu Desnoyers [Mon, 15 Jul 2013 23:45:24 +0000 (19:45 -0400)] 
consumer: introduce channel lock

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Sun, 14 Jul 2013 19:29:41 +0000 (15:29 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

8 years agoFix: update lttng snapshot help output
David Goulet [Sun, 14 Jul 2013 19:27:45 +0000 (15:27 -0400)] 
Fix: update lttng snapshot help output

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoMan: fix part of snapshot documentation
David Goulet [Sun, 14 Jul 2013 19:24:15 +0000 (15:24 -0400)] 
Man: fix part of snapshot documentation

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: set tracefile size test with PID buffers
David Goulet [Fri, 12 Jul 2013 21:16:41 +0000 (17:16 -0400)] 
Fix: set tracefile size test with PID buffers

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Babelstats fail to parse output with no process name or pid
Christian Babeux [Fri, 12 Jul 2013 20:39:02 +0000 (16:39 -0400)] 
Fix: Babelstats fail to parse output with no process name or pid

The process name and pid are optionnal components in the babeltrace
text output.

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
8 years agoMissing NULL pointer init in tap.c
Mathieu Desnoyers [Fri, 12 Jul 2013 15:41:08 +0000 (11:41 -0400)] 
Missing NULL pointer init in tap.c

Could lead to free() of unitialized pointer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Unchecked asprintf/vasprintf return values
Jérémie Galarneau [Fri, 12 Jul 2013 16:38:56 +0000 (12:38 -0400)] 
Fix: Unchecked asprintf/vasprintf return values

strp may be modified even in case of failure according to the
ASPRINTF(3) man page.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd snapshots test to fast regression
David Goulet [Fri, 12 Jul 2013 17:57:55 +0000 (13:57 -0400)] 
Add snapshots test to fast regression

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: kernel data unit test
David Goulet [Fri, 12 Jul 2013 17:47:12 +0000 (13:47 -0400)] 
Fix: kernel data unit test

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: snapshot returned valid LTTNG_ERR code
David Goulet [Fri, 12 Jul 2013 15:01:09 +0000 (11:01 -0400)] 
Fix: snapshot returned valid LTTNG_ERR code

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd the number of snapshot taken to the output path
David Goulet [Fri, 12 Jul 2013 14:53:59 +0000 (10:53 -0400)] 
Add the number of snapshot taken to the output path

This number of snapshots is per session.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: RCU read side lock unbalanced
David Goulet [Fri, 12 Jul 2013 14:23:28 +0000 (10:23 -0400)] 
Fix: RCU read side lock unbalanced

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: zeroed snapshot output at init
David Goulet [Fri, 12 Jul 2013 14:16:26 +0000 (10:16 -0400)] 
Fix: zeroed snapshot output at init

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoSupport del-output with an output name
David Goulet [Thu, 11 Jul 2013 20:57:53 +0000 (16:57 -0400)] 
Support del-output with an output name

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUpdate man page with snapshot command
David Goulet [Thu, 11 Jul 2013 20:46:14 +0000 (16:46 -0400)] 
Update man page with snapshot command

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoNew UST default buffers is now per UID
David Goulet [Thu, 11 Jul 2013 19:30:49 +0000 (15:30 -0400)] 
New UST default buffers is now per UID

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoBump UST ABI major version for 2.3 release
David Goulet [Thu, 11 Jul 2013 19:20:21 +0000 (15:20 -0400)] 
Bump UST ABI major version for 2.3 release

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd snapshot mode to lttng list session
David Goulet [Thu, 11 Jul 2013 19:13:23 +0000 (15:13 -0400)] 
Add snapshot mode to lttng list session

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: support temporary snapshot max size and name
David Goulet [Thu, 11 Jul 2013 18:51:35 +0000 (14:51 -0400)] 
Fix: support temporary snapshot max size and name

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoSupport snapshot max-size limitation
Julien Desfossez [Wed, 10 Jul 2013 02:42:13 +0000 (22:42 -0400)] 
Support snapshot max-size limitation

This features allows the user to specify a maximum size for the snapshot
collected. The maximum stream size is split equally by the total number
of streams active at the time of the snapshot record across all the
domains. The metadata is not limited and its size is not taken into
account in the maximum stream size computation.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTests: per-UID UST snapshot
Julien Desfossez [Mon, 8 Jul 2013 15:46:37 +0000 (11:46 -0400)] 
Tests: per-UID UST snapshot

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: snapshot support for UST and kernel in same session
David Goulet [Tue, 9 Jul 2013 14:50:25 +0000 (10:50 -0400)] 
Fix: snapshot support for UST and kernel in same session

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoImplement lttng create --snapshot command
David Goulet [Mon, 8 Jul 2013 19:19:28 +0000 (15:19 -0400)] 
Implement lttng create --snapshot command

This is to ease the life of the user creating a session in snapshot
mode using the new API call.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd create session snapshot API in lttng-sessiond
David Goulet [Mon, 8 Jul 2013 19:19:12 +0000 (15:19 -0400)] 
Add create session snapshot API in lttng-sessiond

This commit adds the "lttng_create_session_snapshot()" call to the API
which will create on the session daemon a session in snapshot mode
meaning that all channel will be in overwrite mode and mmap output.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd snapshot output init call that uses URIs
David Goulet [Mon, 8 Jul 2013 16:15:19 +0000 (12:15 -0400)] 
Add snapshot output init call that uses URIs

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: consumer err_sock cloexec
Mathieu Desnoyers [Wed, 10 Jul 2013 19:39:54 +0000 (15:39 -0400)] 
Fix: consumer err_sock cloexec

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoCallsite: add "ip" context
Woegerer, Paul [Wed, 10 Jul 2013 09:06:45 +0000 (11:06 +0200)] 
Callsite: add "ip" context

Support ip context in lttng add-context -t.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible consumer sockets double close on cleanup
David Goulet [Tue, 9 Jul 2013 16:28:41 +0000 (12:28 -0400)] 
Fix: possible consumer sockets double close on cleanup

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAutomatically load kvm-x86 and kvm-x86-mmu probes.
Mohamad Gebai [Mon, 8 Jul 2013 19:26:27 +0000 (15:26 -0400)] 
Automatically load kvm-x86 and kvm-x86-mmu probes.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mohamad Gebai <mohamad.gebai@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: consumer: use uint64_t for all sessiond_id
Mathieu Desnoyers [Fri, 28 Jun 2013 16:18:35 +0000 (12:18 -0400)] 
Fix: consumer: use uint64_t for all sessiond_id

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: add gpl and lgpl files to tarball
David Goulet [Mon, 8 Jul 2013 15:25:52 +0000 (11:25 -0400)] 
Fix: add gpl and lgpl files to tarball

Fixes #581

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't install libtap system wide
David Goulet [Mon, 8 Jul 2013 15:23:44 +0000 (11:23 -0400)] 
Fix: don't install libtap system wide

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: close consumer sockets in sessiond cleanup
David Goulet [Fri, 5 Jul 2013 20:03:50 +0000 (16:03 -0400)] 
Fix: close consumer sockets in sessiond cleanup

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: set globally visible flag to kernel stream
David Goulet [Fri, 5 Jul 2013 19:39:21 +0000 (15:39 -0400)] 
Fix: set globally visible flag to kernel stream

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: lttng: memory leak in snapshot record command
Mathieu Desnoyers [Thu, 4 Jul 2013 22:14:33 +0000 (18:14 -0400)] 
Fix: lttng: memory leak in snapshot record command

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: kernel-consumer: double-close
Mathieu Desnoyers [Thu, 4 Jul 2013 22:06:44 +0000 (18:06 -0400)] 
Fix: kernel-consumer: double-close

check for -1 out_fd

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: consumer: incorrect size zmalloc
Mathieu Desnoyers [Thu, 4 Jul 2013 21:53:50 +0000 (17:53 -0400)] 
Fix: consumer: incorrect size zmalloc

Also, check return value.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: don't try to send stream to relayd if not in streaming
David Goulet [Fri, 5 Jul 2013 18:41:58 +0000 (14:41 -0400)] 
Fix: don't try to send stream to relayd if not in streaming

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: relayd refcount updates for stream
David Goulet [Thu, 4 Jul 2013 20:25:27 +0000 (16:25 -0400)] 
Fix: relayd refcount updates for stream

Increment refcount only when the stream was successfully sent to the
relayd and set the new stream's flag "sent_to_relayd" which is used
before the refcount update when closing the relayd. A stream that was
unable to be sent, the close relayd code path does not decrement the
refcount anymore.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't send error to sessiond on orderly shutdown
David Goulet [Thu, 4 Jul 2013 20:31:27 +0000 (16:31 -0400)] 
Fix: don't send error to sessiond on orderly shutdown

The send always fail if the sessiond has closed the socket so no point
of trying to send an error.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: bad pathname used when sending kernel stream to relayd
David Goulet [Thu, 4 Jul 2013 20:14:46 +0000 (16:14 -0400)] 
Fix: bad pathname used when sending kernel stream to relayd

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add globally visible flag in stream
David Goulet [Thu, 4 Jul 2013 19:35:21 +0000 (15:35 -0400)] 
Fix: add globally visible flag in stream

This flag is added so we can destroy it correctly with the
consumer-stream API.

Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.061612 seconds and 4 git commands to generate.