lttng-tools.git
4 years agom4/pprint.m4: update with correct quoting
Philippe Proulx [Wed, 2 Nov 2016 07:25:25 +0000 (03:25 -0400)] 
m4/pprint.m4: update with correct quoting

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoconfigure.ac: move warning to end of output for the end user
Philippe Proulx [Fri, 28 Oct 2016 23:01:19 +0000 (19:01 -0400)] 
configure.ac: move warning to end of output for the end user

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agodoc/man: only require asciidoc-attrs.conf when building the man pages
Philippe Proulx [Fri, 28 Oct 2016 22:33:19 +0000 (18:33 -0400)] 
doc/man: only require asciidoc-attrs.conf when building the man pages

Situations:

* If you want to and can build the man pages:
  * If it's a tarball tree:
    * Make the man page destinations depend on asciidoc-attrs.conf.
      Since it's a generated file, its date is greater than the
      date of the prebuilt man pages, therefore the man pages are
      built again, which is a good thing because they include the
      default values of this build.
  * If it's a Git tree:
    * Always build the man pages anyway (no prebuilt man pages here).
* If you want to, but cannot build the man pages:
  * If it's a tarball tree:
    * Make the man page destinations NOT depend on asciidoc-attrs.conf,
      because its recent date would ask said destinations to be rebuilt
      and this is not possible because we don't have the tools.

      However, warn the user at configure time that the prebuilt man
      pages will be installed, which means that they will contain the
      project's default values, not this build's default values.
  * If it's a Git tree:
    * Not valid: error at configure time as usual.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTest fix: increase test count in plan of test_perf_raw
Jérémie Galarneau [Thu, 10 Nov 2016 19:47:14 +0000 (14:47 -0500)] 
Test fix: increase test count in plan of test_perf_raw

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCreate a dedicated test suite for Perf
Julien Desfossez [Mon, 12 Sep 2016 20:57:10 +0000 (16:57 -0400)] 
Create a dedicated test suite for Perf

Introduce the perf_regression test suite that must be run manually to
check if the support for the Perf-related features are available on the
current machine. This test cannot be run automatically since there are
some platforms where it can fail (VMs, some SoCs, etc).

For now, the test only makes sure that we can trace events with perf
contexts enabled by raw ID in kernel and user-space. The test only works
if libpfm is installed on the system and fails if it is not installed.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: accommodate stricter mktemp implementations in tests
Nathan Lynch [Tue, 1 Nov 2016 17:25:47 +0000 (11:25 -0600)] 
Tests: accommodate stricter mktemp implementations in tests

Busybox's mktemp command uses mkstemp(3) which requires the last six
characters of the template to be X's.  Extend the mktemp templates
used in the test scripts.

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoAdd version info to lttng-relayd help
Anders Wallin [Thu, 20 Oct 2016 05:58:55 +0000 (07:58 +0200)] 
Add version info to lttng-relayd help

lttng-relayd man pages states that the option
-V --version is available, but it it's missing in the code

Signed-off-by: Anders Wallin <wallinux@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: stop sessiond threads on health thread error
Jérémie Galarneau [Thu, 20 Oct 2016 21:05:14 +0000 (17:05 -0400)] 
Fix: stop sessiond threads on health thread error

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: stop lttng-relayd threads on health thread error
Jérémie Galarneau [Thu, 20 Oct 2016 19:45:42 +0000 (15:45 -0400)] 
Fix: stop lttng-relayd threads on health thread error

The lttng-relayd health thread may fail to initialize for
a variety of reason (notably, a too long unix domain socket
address), which will cause it to never notify that it is
ready.

In such circumstances, the lttng-relayd command, in background or
daemonize mode, will never return as the daemon's "readyness"
will never be signaled.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: report an error if unix socket address is too long
Jérémie Galarneau [Thu, 20 Oct 2016 19:45:13 +0000 (15:45 -0400)] 
Fix: report an error if unix socket address is too long

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove unmaintained TODO file
Jérémie Galarneau [Thu, 20 Oct 2016 18:58:36 +0000 (14:58 -0400)] 
Remove unmaintained TODO file

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove outdated comment about run_as open being broken
Jérémie Galarneau [Thu, 20 Oct 2016 15:53:57 +0000 (11:53 -0400)] 
Remove outdated comment about run_as open being broken

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove run-as compat wrapper from internal code
Jérémie Galarneau [Thu, 20 Oct 2016 15:38:31 +0000 (11:38 -0400)] 
Remove run-as compat wrapper from internal code

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: save: leak of configuration file fd
Jonathan Rajotte [Tue, 18 Oct 2016 22:09:53 +0000 (18:09 -0400)] 
Fix: save: leak of configuration file fd

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoUpdate master version to 2.10.0-pre
Jérémie Galarneau [Fri, 7 Oct 2016 23:17:08 +0000 (19:17 -0400)] 
Update master version to 2.10.0-pre

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: warn when a loaded session can't be set as the default
Jérémie Galarneau [Fri, 7 Oct 2016 21:03:26 +0000 (17:03 -0400)] 
Fix: warn when a loaded session can't be set as the default

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoWarning fix: forward declare struct lttng_ust_calibrate
Jérémie Galarneau [Fri, 7 Oct 2016 20:39:46 +0000 (16:39 -0400)] 
Warning fix: forward declare struct lttng_ust_calibrate

lttng-ust's ust-ctl.h still refers to struct lttng_ust_calibrate
which causes gcc to emit a "‘struct lttng_ust_calibrate’ is
declared inside a parameter list" warning.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-enable-channel(1): remove redundant --discard from synopsis
Philippe Proulx [Tue, 9 Aug 2016 19:17:25 +0000 (15:17 -0400)] 
lttng-enable-channel(1): remove redundant --discard from synopsis

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agotest: load --override-name
Jonathan Rajotte [Thu, 6 Oct 2016 21:12:38 +0000 (17:12 -0400)] 
test: load --override-name

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoload: introduce --override-name
Jonathan Rajotte [Fri, 7 Oct 2016 16:03:34 +0000 (12:03 -0400)] 
load: introduce --override-name

The --override-name option allow users to override the name of the
session to be loaded using the command-line.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoman: lttng-load fix up
Jonathan Rajotte [Wed, 5 Oct 2016 21:04:33 +0000 (17:04 -0400)] 
man: lttng-load fix up

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDocs: grammar fix in load.h
Jérémie Galarneau [Fri, 7 Oct 2016 19:04:44 +0000 (15:04 -0400)] 
Docs: grammar fix in load.h

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng_ctl: add session_name to load override
Jonathan Rajotte [Mon, 3 Oct 2016 19:18:42 +0000 (15:18 -0400)] 
lttng_ctl: add session_name to load override

Introduce the override of the session name during the loading of a session.

Can only be used when a session name to be loaded is provided.
Renaming of multiple session is ambiguous.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: test presence of override_attr before accessing its member
Jonathan Rajotte [Mon, 3 Oct 2016 18:57:31 +0000 (14:57 -0400)] 
Fix: test presence of override_attr before accessing its member

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoload: objects returned by getters do not need to be freed
Jonathan Rajotte [Fri, 7 Oct 2016 15:38:28 +0000 (11:38 -0400)] 
load: objects returned by getters do not need to be freed

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove lttng_load_session_attr_get_override_path_url
Jérémie Galarneau [Fri, 7 Oct 2016 16:25:47 +0000 (12:25 -0400)] 
Remove lttng_load_session_attr_get_override_path_url

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDocs: change order of set functions in load.h to match get
Jérémie Galarneau [Fri, 7 Oct 2016 16:25:21 +0000 (12:25 -0400)] 
Docs: change order of set functions in load.h to match get

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate documentation
Philippe Proulx [Tue, 14 Jun 2016 23:17:06 +0000 (19:17 -0400)] 
Remove calibrate documentation

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate from liblttng-ctl
Philippe Proulx [Tue, 14 Jun 2016 23:10:30 +0000 (19:10 -0400)] 
Remove calibrate from liblttng-ctl

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate from lttng-sessiond
Philippe Proulx [Tue, 14 Jun 2016 22:50:32 +0000 (18:50 -0400)] 
Remove calibrate from lttng-sessiond

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate from Python bindings
Philippe Proulx [Tue, 14 Jun 2016 22:47:24 +0000 (18:47 -0400)] 
Remove calibrate from Python bindings

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate from Bash completion script
Philippe Proulx [Tue, 14 Jun 2016 22:44:45 +0000 (18:44 -0400)] 
Remove calibrate from Bash completion script

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate tests in Python bindings
Philippe Proulx [Tue, 14 Jun 2016 22:44:08 +0000 (18:44 -0400)] 
Remove calibrate tests in Python bindings

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRemove calibrate command from lttng CLI
Philippe Proulx [Tue, 14 Jun 2016 22:43:02 +0000 (18:43 -0400)] 
Remove calibrate command from lttng CLI

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoBuild fix: remove load-42-stream.lttng from dist target
Jérémie Galarneau [Fri, 7 Oct 2016 14:17:26 +0000 (10:17 -0400)] 
Build fix: remove load-42-stream.lttng from dist target

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest: load --override-url
Jonathan Rajotte [Mon, 19 Sep 2016 17:34:49 +0000 (13:34 -0400)] 
Test: load --override-url

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoAdd --override-url option to load command
Jonathan Rajotte [Tue, 13 Sep 2016 14:54:23 +0000 (10:54 -0400)] 
Add --override-url option to load command

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoApply the overrides attributes during configuration load
Jonathan Rajotte [Mon, 12 Sep 2016 22:09:09 +0000 (18:09 -0400)] 
Apply the overrides attributes during configuration load

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: remove copy-pasted comment from save.c
Jérémie Galarneau [Fri, 7 Oct 2016 03:39:40 +0000 (23:39 -0400)] 
Clean-up: remove copy-pasted comment from save.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-ctl: add override helper to load api
Jonathan Rajotte [Thu, 8 Sep 2016 22:02:51 +0000 (18:02 -0400)] 
lttng-ctl: add override helper to load api

User can provide an url override that will be used during the loading of a
configuration file.

The url format is the same found at lttng-create(1).

This correspond to a --set-url operation on lttng-create.

Note: an url might be invalid for a trace configuration. The override will fail
during the session load (call to lttng_load_session) and simply cancel the
loading.

e.g Loading a live session with a file:// url override will fail.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRename override to overwrite for config_load_session
Jonathan Rajotte [Fri, 9 Sep 2016 16:37:37 +0000 (12:37 -0400)] 
Rename override to overwrite for config_load_session

This rename is to be consistent with the load API doc and interface.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: report truncation on snprintf
Jonathan Rajotte [Wed, 7 Sep 2016 15:54:40 +0000 (11:54 -0400)] 
Fix: report truncation on snprintf

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: check for a session daemon before running load command
Jérémie Galarneau [Thu, 6 Oct 2016 18:52:19 +0000 (14:52 -0400)] 
Fix: check for a session daemon before running load command

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: ignore SIGPIPE
Mathieu Desnoyers [Thu, 6 Oct 2016 16:57:45 +0000 (12:57 -0400)] 
Fix: ignore SIGPIPE

Issuing fprintf() to stderr (thus write() to the standard error file
descriptor) within the SIGPIPE signal handler is bad: it can trigger
SIGPIPE repeatedly if the listening end has closed its end of the pipe.

Set the SIGPIPE action to SIG_IGN in relayd, sessiond, and consumerd.

This was affecting sessiond and relayd. The consumerd did not print
anything to stderr.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoUse lttng api for the load command
Jonathan Rajotte [Wed, 7 Sep 2016 15:53:06 +0000 (11:53 -0400)] 
Use lttng api for the load command

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: use ssize_type for the return value of uri_parse_str_urls
Jonathan Rajotte [Wed, 7 Sep 2016 15:07:52 +0000 (11:07 -0400)] 
Fix: use ssize_type for the return value of uri_parse_str_urls

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDocs: grammar fixes in load.h
Jérémie Galarneau [Thu, 6 Oct 2016 15:24:23 +0000 (11:24 -0400)] 
Docs: grammar fixes in load.h

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: wrong api comments for load.h
Jonathan Rajotte [Tue, 6 Sep 2016 18:21:11 +0000 (14:21 -0400)] 
Fix: wrong api comments for load.h

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: do not overwrite ret if already set and session found
Jonathan Rajotte [Tue, 13 Sep 2016 21:17:50 +0000 (17:17 -0400)] 
Fix: do not overwrite ret if already set and session found

Errors were not propagated correctly otherwise.

e.g:
(No sessiond running)
lttng load --all
-> All sessions have been loaded successfully
lttng list show no sessions

With fix the same command output:
Error: No session daemon is available

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-sessiond: auto-load lttng-probe-i2c module
Simon Marchi [Tue, 4 Oct 2016 22:24:50 +0000 (18:24 -0400)] 
lttng-sessiond: auto-load lttng-probe-i2c module

Automatically load the lttng-probe-i2c kernel module, which was recently
added in lttng-modules, along with the other probe modules.

Signed-off-by: Simon Marchi <simon.marchi@ericsson.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoBump lttng-modules ABI minor version
Mathieu Desnoyers [Wed, 5 Oct 2016 16:54:20 +0000 (12:54 -0400)] 
Bump lttng-modules ABI minor version

Follow lttng-modules upstream.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: handle backward compatibility with lttng-modules 2.7
Mathieu Desnoyers [Wed, 5 Oct 2016 16:54:19 +0000 (12:54 -0400)] 
Fix: handle backward compatibility with lttng-modules 2.7

There is no major version bump between lttng-module 2.7 and 2.8 ABI.
Even though we do not guarantee compatibility, do a best effort to
maintain it when possible.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: remove unnecessary autoconf variable substitution
Jérémie Galarneau [Tue, 4 Oct 2016 21:16:01 +0000 (17:16 -0400)] 
Clean-up: remove unnecessary autoconf variable substitution

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: honor negative (unlimited) app socket timeout
Jérémie Galarneau [Tue, 4 Oct 2016 21:00:17 +0000 (17:00 -0400)] 
Fix: honor negative (unlimited) app socket timeout

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoBuild: Replace use of deprecated AM_PATH_XML2
Jérémie Galarneau [Tue, 4 Oct 2016 18:37:57 +0000 (14:37 -0400)] 
Build: Replace use of deprecated AM_PATH_XML2

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest fix: set app and network socket timeouts to unlimited
Jérémie Galarneau [Thu, 29 Sep 2016 23:35:01 +0000 (19:35 -0400)] 
Test fix: set app and network socket timeouts to unlimited

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest fix: test_fork can hang while waiting for child pids
Jérémie Galarneau [Thu, 29 Sep 2016 04:03:42 +0000 (00:03 -0400)] 
Test fix: test_fork can hang while waiting for child pids

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest fix: test_daemon can hang while waiting for child pids
Jérémie Galarneau [Thu, 29 Sep 2016 04:01:06 +0000 (00:01 -0400)] 
Test fix: test_daemon can hang while waiting for child pids

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest fix: redirect python test subprocess output to /dev/null
Jérémie Galarneau [Thu, 29 Sep 2016 03:13:19 +0000 (23:13 -0400)] 
Test fix: redirect python test subprocess output to /dev/null

Redirecting to subprocess.PIPE can deadlock when subprocess.wait()
is invoked.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoBuild fix: macOS Sierra provides clock_gettime
Jérémie Galarneau [Thu, 29 Sep 2016 00:43:57 +0000 (20:43 -0400)] 
Build fix: macOS Sierra provides clock_gettime

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: time redefinition warnings on macOS builds
Jérémie Galarneau [Wed, 28 Sep 2016 17:26:49 +0000 (13:26 -0400)] 
Fix: time redefinition warnings on macOS builds

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: remove unused variable user
Jérémie Galarneau [Wed, 28 Sep 2016 16:24:50 +0000 (12:24 -0400)] 
Clean-up: remove unused variable user

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoCleanup: Remove fun from code base
Mathieu Desnoyers [Sun, 25 Sep 2016 18:32:27 +0000 (14:32 -0400)] 
Cleanup: Remove fun from code base

It appears choosing the release names provides plenty of enjoyment to
LTTng developers, thus allowing us to remove those easter eggs.

Incidentally, it will allow me to demo the LTTng project without
carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
time I issue a "lttng" command.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: remove in-place backup suffix argument provided to sed
Jérémie Galarneau [Wed, 7 Sep 2016 21:21:22 +0000 (17:21 -0400)] 
Fix: remove in-place backup suffix argument provided to sed

GNU sed complains when an empty suffix argument is provided
as the in-place suffix.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: pass a valid length to accept() on unix domain sockets
Jérémie Galarneau [Wed, 31 Aug 2016 03:00:57 +0000 (23:00 -0400)] 
Fix: pass a valid length to accept() on unix domain sockets

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoLog signals received by run_as worker
Jérémie Galarneau [Fri, 26 Aug 2016 19:47:07 +0000 (15:47 -0400)] 
Log signals received by run_as worker

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoMissing word in worker_sighandler() comment
Jérémie Galarneau [Fri, 26 Aug 2016 19:46:50 +0000 (15:46 -0400)] 
Missing word in worker_sighandler() comment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up snapshot command error reporting
Jérémie Galarneau [Thu, 25 Aug 2016 20:43:13 +0000 (16:43 -0400)] 
Clean-up snapshot command error reporting

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: RCU lock imbalance on error in cmd_snapshot_list_outputs()
Jérémie Galarneau [Thu, 25 Aug 2016 20:20:47 +0000 (16:20 -0400)] 
Fix: RCU lock imbalance on error in cmd_snapshot_list_outputs()

The error path of cmd_snapshot_list_outputs() unlocks the
rcu_read_lock. However, this path can be taken without having
ever locked before.

Fixes #1044

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoUse -M parameter instead of --manpath when invoking man(1)
Ricardo Nabinger Sanchez [Thu, 25 Aug 2016 19:57:46 +0000 (15:57 -0400)] 
Use -M parameter instead of --manpath when invoking man(1)

Older versions of man (and the implementation used in FreeBSD) do
not support the long version of the --manpath/-M option. Use
'-M' in the interest of portability.

Fixes #1043

Signed-off-by: Ricardo Nabinger Sanchez <rnsanchez@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoOOT Build fix: reference the source directory's Python test app
Jérémie Galarneau [Wed, 10 Aug 2016 18:40:24 +0000 (14:40 -0400)] 
OOT Build fix: reference the source directory's Python test app

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: pass NULL to config_load_session instead of an empty string
Jérémie Galarneau [Tue, 9 Aug 2016 17:03:00 +0000 (13:03 -0400)] 
Fix: pass NULL to config_load_session instead of an empty string

The public lttng_load_session wrapper uses empty strings (strings
starting with \0) to express "any" session_name and the default
session load paths.

However, this is not expected by config_load_session which uses
NULLs to express these values.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: don't copy test_python_logging explicitly
Jérémie Galarneau [Fri, 5 Aug 2016 21:55:38 +0000 (17:55 -0400)] 
Tests: don't copy test_python_logging explicitly

cp would fail silently in OOT builds when trying to copy
test_python_logging. This is no longer necessary as it is
generated on configure.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoOOT build fix: Missing include of src directory
Jérémie Galarneau [Fri, 5 Aug 2016 21:35:00 +0000 (17:35 -0400)] 
OOT build fix: Missing include of src directory

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoAccomodate BSD sed in version.h generation
Jérémie Galarneau [Fri, 5 Aug 2016 19:45:19 +0000 (15:45 -0400)] 
Accomodate BSD sed in version.h generation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Detect platforms where librt is required
Michael Jeanson [Wed, 3 Aug 2016 21:59:16 +0000 (17:59 -0400)] 
Port: Detect platforms where librt is required

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX clock_gettime compat
Michael Jeanson [Wed, 3 Aug 2016 20:54:16 +0000 (16:54 -0400)] 
Port: Add OSX clock_gettime compat

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX support to socket compat
Michael Jeanson [Wed, 3 Aug 2016 18:35:27 +0000 (14:35 -0400)] 
Port: Add OSX support to socket compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX support to poll compat
Michael Jeanson [Wed, 3 Aug 2016 18:33:42 +0000 (14:33 -0400)] 
Port: Add OSX support to poll compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX support to fcntl compat
Michael Jeanson [Wed, 3 Aug 2016 18:29:28 +0000 (14:29 -0400)] 
Port: Add OSX support to fcntl compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX compat to sessiond-comm/unix.c
Michael Jeanson [Wed, 3 Aug 2016 18:25:25 +0000 (14:25 -0400)] 
Port: Add OSX compat to sessiond-comm/unix.c

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX endian.h compat
Michael Jeanson [Wed, 3 Aug 2016 18:21:36 +0000 (14:21 -0400)] 
Port: Add OSX endian.h compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPort: Add OSX libuuid compat
Michael Jeanson [Tue, 2 Aug 2016 20:27:59 +0000 (16:27 -0400)] 
Port: Add OSX libuuid compat

OSX has the libuuid symbols built in the system libraries.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: zero-initialize fd_set
Jérémie Galarneau [Wed, 3 Aug 2016 18:14:33 +0000 (14:14 -0400)] 
Fix: zero-initialize fd_set

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: missing cast to fd_set*
Jérémie Galarneau [Wed, 3 Aug 2016 16:42:43 +0000 (12:42 -0400)] 
Clean-up: missing cast to fd_set*

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: usage of FD_SET on fd_set > 1024 results in corruption
Jérémie Galarneau [Wed, 3 Aug 2016 16:36:34 +0000 (12:36 -0400)] 
Fix: usage of FD_SET on fd_set > 1024 results in corruption

fd_set is (typically) defined as an 1024 bit long array.
Therefore, using FD_SET with an fd > 1024 will result in a buffer
overrun.

Reported-by: Coverity Scan
CID 1360535 (#1 of 1): Out-of-bounds write (OVERRUN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: erroneous usage of addr parameter in mmap()
Jérémie Galarneau [Wed, 3 Aug 2016 15:43:13 +0000 (11:43 -0400)] 
Fix: erroneous usage of addr parameter in mmap()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: remove useless assignment
Jérémie Galarneau [Wed, 3 Aug 2016 15:09:21 +0000 (11:09 -0400)] 
Clean-up: remove useless assignment

Reported-by Coverity Scan:
CID 1243014: Unused value (UNUSED_VALUE)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: missing unmap in test error handling
Jérémie Galarneau [Mon, 1 Aug 2016 19:34:31 +0000 (15:34 -0400)] 
Fix: missing unmap in test error handling

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: unchecked pthread_join return value
Jérémie Galarneau [Mon, 1 Aug 2016 19:32:39 +0000 (15:32 -0400)] 
Tests: unchecked pthread_join return value

Reported-by Coverity Scan:
CID 1360530 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: remove negative check against unsigned value
Jérémie Galarneau [Mon, 1 Aug 2016 19:27:33 +0000 (15:27 -0400)] 
Clean-up: remove negative check against unsigned value

Reported-by Coverity Scan:
CID 1360536 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: unchecked init_pipe return value
Jérémie Galarneau [Mon, 1 Aug 2016 19:16:38 +0000 (15:16 -0400)] 
Fix: unchecked init_pipe return value

Reported-by Coverity Scan:
CID 1360533 (#1 of 1): Logically dead code (DEADCODE)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: Unchecked pthread_create return value
Jérémie Galarneau [Mon, 1 Aug 2016 19:07:42 +0000 (15:07 -0400)] 
Tests: Unchecked pthread_create return value

Reported-by Coverity Scan:
CID 1360529 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up: remove useless assignment
Jérémie Galarneau [Mon, 1 Aug 2016 18:39:37 +0000 (14:39 -0400)] 
Clean-up: remove useless assignment

Reported-by Coverity Scan
CID 1243048 (#1 of 1): Unused value (UNUSED_VALUE)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: Add tracepoints to libbar, libfoo and libzzz
Jérémie Galarneau [Fri, 22 Jul 2016 19:10:57 +0000 (15:10 -0400)] 
Tests: Add tracepoints to libbar, libfoo and libzzz

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: Mark ASCIIDOC_ATTRS_CONF as a dependency of man page targets
Jérémie Galarneau [Wed, 20 Jul 2016 17:56:38 +0000 (13:56 -0400)] 
Fix: Mark ASCIIDOC_ATTRS_CONF as a dependency of man page targets

ASCIIDOC_ATTRS_CONF contains the various paths set by autoconf,
such as datadir, syscondif and prefix, and it may be changed
by the user by invoking ./configure with different options. In
such a case, the man pages should be regenerated to take the new
paths into account.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest the parsing of perf raw context
Julien Desfossez [Tue, 5 Jul 2016 15:50:47 +0000 (11:50 -0400)] 
Test the parsing of perf raw context

Only test the parsing of the new option in fast_regression since the
real integration test requires particular hardware and kernel
configuration which might not be available.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoEnable perf PMU counters by raw ID
Julien Desfossez [Tue, 5 Jul 2016 15:50:46 +0000 (11:50 -0400)] 
Enable perf PMU counters by raw ID

Allow enabling perf PMU counters by raw ID in addition to the generic
list already provided. The format for kernel tracing is
"perf:cpu:raw:rNNN:<name>" and "perf:thread:raw:rNNN:<name> for
user-space. The rNNN format is the same as perf-record(1) where NNN is a
hexadecimal event descriptor in the form of umask+eventsel. The <name>
field to associate a clearer name to the counter.

Example usage on Intel i7-3520M to get the unhalted reference cycles
(eventsel: 0x13c) count at privilege level 0 (umask: 0x00):
lttng add-context -k -t perf:cpu:raw:r0013c:x86unhalted

Result in the trace:
sched_switch: { cpu_id = 3 }, {
perf_cpu_raw_r0013c_x86unhalted = 27632578 }, [...]

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRun userspace perf tests on non-x86 platforms
Jérémie Galarneau [Wed, 6 Jul 2016 19:47:18 +0000 (15:47 -0400)] 
Run userspace perf tests on non-x86 platforms

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: adjust ust-dl planned test count
Jérémie Galarneau [Wed, 6 Jul 2016 23:39:10 +0000 (19:39 -0400)] 
Tests: adjust ust-dl planned test count

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.063754 seconds and 4 git commands to generate.