lttng-tools.git
4 years agoCleanup: app is never used by alloc_ust_app_session()
Jonathan Rajotte [Tue, 13 Mar 2018 22:19:48 +0000 (18:19 -0400)] 
Cleanup: app is never used by alloc_ust_app_session()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: ust_session_id unused by buffer_reg_uid_consumer_channel_key
Jonathan Rajotte [Tue, 13 Mar 2018 22:19:32 +0000 (18:19 -0400)] 
Cleanup: ust_session_id unused by buffer_reg_uid_consumer_channel_key

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: wpipe already contain kernel_tracer_fd
Jonathan Rajotte [Tue, 13 Mar 2018 22:13:39 +0000 (18:13 -0400)] 
Cleanup: wpipe already contain kernel_tracer_fd

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: domain type is never used by send_consumer_relayd_socket()
Jonathan Rajotte [Tue, 13 Mar 2018 22:06:57 +0000 (18:06 -0400)] 
Cleanup: domain type is never used by send_consumer_relayd_socket()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: uid and gid are never used by run_as_noworker()
Jonathan Rajotte [Tue, 13 Mar 2018 21:41:34 +0000 (17:41 -0400)] 
Cleanup: uid and gid are never used by run_as_noworker()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: sessiond_id is never used by relayd_create_session_2_*
Jonathan Rajotte [Tue, 13 Mar 2018 21:37:10 +0000 (17:37 -0400)] 
Cleanup: sessiond_id is never used by relayd_create_session_2_*

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: sock is never used by ask_channel()
Jonathan Rajotte [Tue, 13 Mar 2018 19:06:43 +0000 (15:06 -0400)] 
Cleanup: sock is never used by ask_channel()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: ctx is never used by monitor_timer()
Jonathan Rajotte [Tue, 13 Mar 2018 18:40:26 +0000 (14:40 -0400)] 
Cleanup: ctx is never used by monitor_timer()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: signo is never used by metadata_switch_timer
Jonathan Rajotte [Tue, 13 Mar 2018 18:39:00 +0000 (14:39 -0400)] 
Cleanup: signo is never used by metadata_switch_timer

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: channel is never used by metadata_cache_check_version()
Jonathan Rajotte [Tue, 13 Mar 2018 18:27:24 +0000 (14:27 -0400)] 
Cleanup: channel is never used by metadata_cache_check_version()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: relayd id is never used by write_relayd_metadata_id()
Jonathan Rajotte [Tue, 13 Mar 2018 16:56:12 +0000 (12:56 -0400)] 
Cleanup: relayd id is never used by write_relayd_metadata_id()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: attr is not used by open_ust_stream_fd()
Jonathan Rajotte [Tue, 13 Mar 2018 16:48:43 +0000 (12:48 -0400)] 
Cleanup: attr is not used by open_ust_stream_fd()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: *_domain are never used by create_session
Jonathan Rajotte [Tue, 13 Mar 2018 16:48:22 +0000 (12:48 -0400)] 
Cleanup: *_domain are never used by create_session

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agodoc/man: update rotation man pages to follow API's terminology
Philippe Proulx [Thu, 17 May 2018 18:29:17 +0000 (14:29 -0400)] 
doc/man: update rotation man pages to follow API's terminology

"Manual rotation" becomes "immediate rotation".

"Automatic rotation schedule" becomes "rotation schedule". We still
write "automatic rotation" as the result of a rotation schedule being
fulfilled by its condition.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoPrint consumerd32/64/kernel configuration
Jonathan Rajotte [Mon, 28 May 2018 20:51:17 +0000 (16:51 -0400)] 
Print consumerd32/64/kernel configuration

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTest: change use of space for tabs in utils.sh
Jérémie Galarneau [Tue, 29 May 2018 18:10:03 +0000 (14:10 -0400)] 
Test: change use of space for tabs in utils.sh

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: add duplicated providers tests
Francis Deslauriers [Fri, 9 Feb 2018 21:56:52 +0000 (16:56 -0500)] 
Tests: add duplicated providers tests

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: add function to validate the number of an event name in metadata
Francis Deslauriers [Fri, 9 Feb 2018 21:56:51 +0000 (16:56 -0500)] 
Tests: add function to validate the number of an event name in metadata

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: allow the use of regular expressions to match events
Francis Deslauriers [Fri, 9 Feb 2018 21:56:50 +0000 (16:56 -0500)] 
Tests: allow the use of regular expressions to match events

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: calling ht_{hash, match}_enum with wrong argument
Francis Deslauriers [Fri, 9 Feb 2018 21:56:49 +0000 (16:56 -0500)] 
Fix: calling ht_{hash, match}_enum with wrong argument

ht_hash_enum and ht_match_enum are currently called with the address of the
pointer to a ust_registry_enum rather than the expected pointer to a
ust_registry_enum. This means that those function calls would end up
using garbage for hashing and comparing.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: probes should be compared strictly by events metadata
Francis Deslauriers [Fri, 9 Feb 2018 21:56:48 +0000 (16:56 -0500)] 
Fix: probes should be compared strictly by events metadata

Currently, events are compared using names and signatures. Events
with different payloads but identical name and signatures could
lead to corrupted trace because the Session Daemon would consider them
identical and give them the same event ID.

Events should be compared using the name, loglevel, fields and
model_emf_uri to ensure that their respective metadata is the same.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTest for lttng-logger
Julien Desfossez [Wed, 10 Jan 2018 19:49:20 +0000 (14:49 -0500)] 
Test for lttng-logger

Basic test to write in /proc/lttng-logger and /dev/lttng-logger and
ensure we have the right amount of events in the trace resulting trace.
We also test the 1024 characters limit for the payload.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTest mi: rename sessiond load directory constant
Jérémie Galarneau [Sat, 26 May 2018 09:43:53 +0000 (05:43 -0400)] 
Test mi: rename sessiond load directory constant

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agomi: support "add-context --list"
Jonathan Rajotte [Wed, 28 Feb 2018 21:06:01 +0000 (16:06 -0500)] 
mi: support "add-context --list"

The symbol element is the string passed/to be passed on the cli
for the --type option.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
4 years agoFix: test_ust-dl is generated at configure-time
Francis Deslauriers [Tue, 6 Feb 2018 17:04:27 +0000 (12:04 -0500)] 
Fix: test_ust-dl is generated at configure-time

This file should not be in EXTRA_DIST as it's generated by autoconf and
will thus be available directly in the out-of-tree build directory.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: cmd line options overwrite env variable config options
Jonathan Rajotte [Fri, 18 May 2018 21:45:57 +0000 (17:45 -0400)] 
Fix: cmd line options overwrite env variable config options

The doc is clear about the order of precedence regarding configuration.

The command line options always override any config file or
configuration by environment variables.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: perform the initialization memory barrier out of loop body
Jérémie Galarneau [Fri, 18 May 2018 19:08:14 +0000 (15:08 -0400)] 
Fix: perform the initialization memory barrier out of loop body

The memory barrier used by the client thread should be performed
after the lttng_sessiond_ready counter has been seen to have
reached zero.

This ensures that loads are not speculatively performed before
this point as the thread will interact with data structures
initialized by the support threads for which it was waiting for
the initialization to complete.

See the comment as to why this read barrier is promoted to a
full barrier.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoClean-up: explicit mb before decrementing lttng_sessiond_ready
Jérémie Galarneau [Fri, 18 May 2018 19:03:13 +0000 (15:03 -0400)] 
Clean-up: explicit mb before decrementing lttng_sessiond_ready

This is mostly a documentation fix as there are no thread-safety
implications to this change. uatomic_sub_return() was used since it
performs a full memory barrier before and after the atomic operation
(as per the urcu documentation).

The barrier performed after the substraction is not needed in this
particular case. Moreover, using an explicit cmm_smp_mb() statement
makes the code clearer; see the comment as to why this barrier is
needed.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoClean-up: use a define for support thread count
Jérémie Galarneau [Fri, 18 May 2018 19:02:17 +0000 (15:02 -0400)] 
Clean-up: use a define for support thread count

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoPort: fix format warnings on Cygwin
Michael Jeanson [Tue, 15 May 2018 20:19:49 +0000 (16:19 -0400)] 
Port: fix format warnings on Cygwin

On Cygwin, be64toh() returns a "long long unsigned int" while the
format specifier PRIu64 expects a "long unsigned int". Both types
are 64bits integers, just cast the result to uint64_t to silence
the warnings.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoAdd missing include for ssize_t on Cygwin
Michael Jeanson [Tue, 15 May 2018 20:19:48 +0000 (16:19 -0400)] 
Add missing include for ssize_t on Cygwin

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: sessions with agent channels fail to load
Jérémie Galarneau [Wed, 16 May 2018 22:32:38 +0000 (18:32 -0400)] 
Fix: sessions with agent channels fail to load

Channels of the "agent" types cannot be created directly. They are
meant to be created implicitly through the activation of events in
their domain.

However, a user can override the default channel configuration
attributes by creating the underlying UST channel before enabling an
agent domain event.

Hence, the channel's type is substituted before the creation and
restored by the time events are created.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: don't wait for the load thread before serving client commands
Jérémie Galarneau [Wed, 16 May 2018 21:08:36 +0000 (17:08 -0400)] 
Fix: don't wait for the load thread before serving client commands

Since the session loading thread uses the same communication than
the external clients, it should not be included in the set of
threads that must be launched before the sessiond starts to serve
client commands.

Since the "load session" thread is guaranteed to be the last
essential thread to be initialized, it can explicitly signal
the parents that the sessiond is ready once it is done auto-loading
session configurations.

This commit also adds a lengthy comment explaining the initialization
of the session daemon.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoAdd test_utils_parse_time_suffix to .gitignore
Jérémie Galarneau [Wed, 16 May 2018 15:51:52 +0000 (11:51 -0400)] 
Add test_utils_parse_time_suffix to .gitignore

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoClean-up: kernel_consumer_add_stream() does not need to be public
Jérémie Galarneau [Wed, 9 May 2018 01:38:57 +0000 (21:38 -0400)] 
Clean-up: kernel_consumer_add_stream() does not need to be public

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: sessiond fails to launch on --without-ust configuration
Jérémie Galarneau [Wed, 9 May 2018 01:26:15 +0000 (21:26 -0400)] 
Fix: sessiond fails to launch on --without-ust configuration

The sessiond will never signal that it is ready (in daemonize or
background modes) if it was built without lttng-ust. The fix in
7eac7803 made the main thread wait for the agent thread to be
ready before signalling that the session daemon is ready.

When agent tracing is not possible due to the absence of lttng-ust,
a stub function is used to launch the agent thread. This stub
must call sessiond_notify_ready() in order to unblock the main
thread.

Note that it would be _incorrect_ to not wait for the agent
thread to be launched as users expect all tracing features to
be available as soon as 'lttng-sessiond --daemonize/--background'
returns.

Not waiting for the thread to be ready caused very rare failures
of the agent tracing tests on the CI, especially on ARM and
PowerPC targets.

Reported-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: agent thread poll set creation failure results in deadlock
Jérémie Galarneau [Wed, 9 May 2018 01:23:14 +0000 (21:23 -0400)] 
Fix: agent thread poll set creation failure results in deadlock

Failing to initialize the agent thread's pollset will cause
the thread to exit before calling sessiond_notify_ready().

This will cause the main thread to wait forever for all threads
to be launched when such an error occurs.

The agent thread is not needed for the sessiond to work (except
to enable the tracing of Java and Python applications). Such
a failure should leave the sessiond in a useable state.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: test uses sizeof() on the wrong operand of strncpy
Jérémie Galarneau [Wed, 9 May 2018 01:22:36 +0000 (21:22 -0400)] 
Fix: test uses sizeof() on the wrong operand of strncpy

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoRename kernel_consumer_send_channel_stream()
Jérémie Galarneau [Tue, 8 May 2018 16:11:19 +0000 (12:11 -0400)] 
Rename kernel_consumer_send_channel_stream()

kernel_consumer_send_channel_stream() sends _all_ streams of
a given channel. It is renamed kernel_consumer_send_channel_streams()
to ensure its name is no longer misleading.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoRename consumer_init_channel_comm_msg()
Jérémie Galarneau [Tue, 8 May 2018 16:07:58 +0000 (12:07 -0400)] 
Rename consumer_init_channel_comm_msg()

consumer_init_channel_comm_msg() is only used for the ADD_CHANNEL
command. It is therefore renamed to
consumer_init_add_channel_comm_msg()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: send_fds functions are not const-correct
Jérémie Galarneau [Tue, 8 May 2018 16:00:41 +0000 (12:00 -0400)] 
Cleanup: send_fds functions are not const-correct

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoRemove unused ltt_session look-up result
Jérémie Galarneau [Thu, 3 May 2018 20:06:11 +0000 (16:06 -0400)] 
Remove unused ltt_session look-up result

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoClean-up: reduce indentation level of create_channel_per_uid()
Jérémie Galarneau [Thu, 3 May 2018 18:57:07 +0000 (14:57 -0400)] 
Clean-up: reduce indentation level of create_channel_per_uid()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoEnforce locking assumptions during channel creation
Jérémie Galarneau [Thu, 3 May 2018 18:35:24 +0000 (14:35 -0400)] 
Enforce locking assumptions during channel creation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: misleading create_ust_app_session() name
Jérémie Galarneau [Wed, 2 May 2018 21:43:48 +0000 (17:43 -0400)] 
Cleanup: misleading create_ust_app_session() name

create_ust_app_session() does not necessarily create an
ust_app_session; it will look for an existing one and return it
and only create one if it fails to do so.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoRename rotate_count to current_archive_id
Jérémie Galarneau [Wed, 2 May 2018 19:27:37 +0000 (15:27 -0400)] 
Rename rotate_count to current_archive_id

The ltt_session's rotate count will no longer be used only to
count the number of rotations. It will be used to tag streams
with a "trace archive chunk id" that indicates the epoch of
their creation.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: name of send_sessiond_channel() is misleading
Jérémie Galarneau [Wed, 2 May 2018 18:39:14 +0000 (14:39 -0400)] 
Cleanup: name of send_sessiond_channel() is misleading

This function sends a channel to the sessiond _and_ to the
relay daemon (if applicable).

Comments are updated to reflect this change and the publication
of streams towards the relay daemon is now logged.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoPrint the git version used to build from a distribution tarball
Michael Jeanson [Fri, 27 Apr 2018 21:27:29 +0000 (17:27 -0400)] 
Print the git version used to build from a distribution tarball

The git version is omitted when building from a distribution
tarball. This will cause 'lttng version' and 'lttng --version'
to print the state of the git tree which produced the tarball.

git describe is used to produce the description of the tree's
state, along with the "dirty" state (whether or not local
changes were present in the tree).

Note that the 'git version' will not be printed when the
distribution tarball was produced at a release tag (a tag
starting with v[0-9]).

This patch simplifies the generation of the version.h file by
generating a file that is merely included by version.h.

It also ensures that version.tmpl is no longer installed on the
system by the install target.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoDocs: lttng-version uses the intransitive form of "broke"
Jérémie Galarneau [Tue, 1 May 2018 19:22:57 +0000 (15:22 -0400)] 
Docs: lttng-version uses the intransitive form of "broke"

To indicate that something is divided, the transitive form
"broken down" is preferred.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: relayd streams can be leaked on connection error
Jonathan Rajotte [Sat, 28 Apr 2018 00:06:08 +0000 (20:06 -0400)] 
Fix: relayd streams can be leaked on connection error

There are cases where a connection error can cause streams to be
leaked.

For instance, the control connection could receive an index and
close. Since a packet is in-flight, the stream corresponding to
that index will not close. However, nothing guarantees that
the data connection will be able to receive the packet's data.

If the protocol is respected, this is not a problem. However,
a buggy consumerd or network errors can cause the streams to
remain in the "data in-flight" state and never close.

To mitigate a case observed in the field where a consumerd
would be forcibly closed (network interface brought down) and
cause leaks on the relay daemon, the session is aborted whenever
the control or data connection encounters an error. Aborting
a session causes the streams to be closed regardless of the
fact that data is in-flight.

Currently, only the control connection holds an ownership of
the session object. This can cause the following scenario to leak
streams:

1) Control connection receives an index
  - Stream is put in "in-flight data" mode
2) Control connection is closed/shutdown cleanly
  - try_stream_close refuses to close the stream as data is in-flight,
    but it puts the stream in "closed" mode. When the data is
    received, the stream will be closed as soon as possible.
3) Data connection closes cleanly or due to an error
  - The stream "closing" condition will never be re-evaluated.

Since the data connection has no ownership of the session, it can
never clean-up the streams that are waiting for "in-flight" data to
arrive before closing.

This patch lazily associates the data connection to its session
so that the session can be aborted whenever an error happens on
either the data or control connection.

Note that this leaves the relayd vulnerable to a case which will
still leak. If the control connection receives an index and closes
cleanly, the data connection could have never been established
with the consumer daemon and result in a leak.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: fix typo in relayd comment
Jérémie Galarneau [Tue, 1 May 2018 15:58:15 +0000 (11:58 -0400)] 
Cleanup: fix typo in relayd comment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: ret may be used uninitialized in sample_channel_positions()
Jonathan Rajotte [Mon, 30 Apr 2018 18:27:35 +0000 (14:27 -0400)] 
Fix: ret may be used uninitialized in sample_channel_positions()

sample_channel_positions() returns garbage if
cds_lfht_is_node_deleted(&stream->node.node) on first and "possibly"
only iteration of the consumer_data.stream_per_chan_id_ht hash table.

Found by scan-build.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: ret is unused in relay_process_data_receive_header()
Jonathan Rajotte [Fri, 27 Apr 2018 21:20:21 +0000 (17:20 -0400)] 
Cleanup: ret is unused in relay_process_data_receive_header()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix build: in_git_repo is used before being set
Jérémie Galarneau [Fri, 27 Apr 2018 22:23:26 +0000 (18:23 -0400)] 
Fix build: in_git_repo is used before being set

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: partial writes of padding are not checked
Jérémie Galarneau [Fri, 27 Apr 2018 21:30:50 +0000 (17:30 -0400)] 
Fix: partial writes of padding are not checked

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoPropagate whether a connection was closed cleanly or after an error
Jérémie Galarneau [Fri, 27 Apr 2018 20:47:04 +0000 (16:47 -0400)] 
Propagate whether a connection was closed cleanly or after an error

This allows a follow-up fix that requires this distinction to
decide whether a session must be closed or aborted.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: relayd protocol field present from minor 8 is not checked
Jonathan Rajotte [Fri, 27 Apr 2018 19:44:19 +0000 (15:44 -0400)] 
Fix: relayd protocol field present from minor 8 is not checked

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoAdd DBG statement for TCP keep-alive options
Jonathan Rajotte [Mon, 9 Apr 2018 14:23:33 +0000 (10:23 -0400)] 
Add DBG statement for TCP keep-alive options

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: relay_recv_metadata does not check for partial write
Jérémie Galarneau [Wed, 25 Apr 2018 18:57:29 +0000 (14:57 -0400)] 
Fix: relay_recv_metadata does not check for partial write

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoUse non-blocking recvmsg() for data/ctrl connections of lttng-relayd
Jérémie Galarneau [Wed, 21 Feb 2018 05:57:26 +0000 (00:57 -0500)] 
Use non-blocking recvmsg() for data/ctrl connections of lttng-relayd

The relay daemon's use of blocking network I/O can cause severe
performance degradation when interacting with unresponsive peers.

This patch changes the recvmsg() calls to use the MSG_DONTWAIT flag
which makes the call non-blocking. The connection classes are modified
to handle the partial reception of buffers.

The sendmsg() calls are still blocking, but this is assumed to
represent a fairly minimal risk of actually blocking given that
the control protocol's replies consist of 4-byte status codes.

A similar approach could be used to make the live connections
non-blocking as that side may also suffer from the same resiliancy
problems. So far, no users have reported this problem so it is
not prioritised.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: unprivilieged sessiond agent port clashes with root sessiond
Jérémie Galarneau [Tue, 24 Apr 2018 19:58:41 +0000 (15:58 -0400)] 
Fix: unprivilieged sessiond agent port clashes with root sessiond

This fix addresses the same problem as reported in f28f9e44.

The session daemon now tries to bind the agent TCP socket to a
port within a range (10 ports by default). The session daemon
will use the first available TCP port within that range when
binding to "localhost". It is still possible to restrict the
session daemon to the broken behaviour by specifying an agent
port using the --agent-tcp-port PORT. If that option is used,
the session daemon will attempt to bind to that part. If it
fails, agent tracing will be marked as disabled.

This fix is backported since the current logic of binding to a
set port means that the default configuration on Ubuntu, Debian,
and other distributions that launch an lttng-sessiond on boot does
not allow the tracing of agent domains (Java Util Logging, log4j,
and Python logging back-ends).

By default, users are not part of the tracing group and it is
not reasonable to expect users to be part of that group for
userspace tracing.

The behaviour of the "system" lttng-sessiond does not change
as it will bind on the first available port within the range.
The non-privilieged session daemons that will be launched after
will be able to bind on other ports available within the range.

Reported-by: Deborah Barnard <starfallprojects@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: erroneous use of extern keyword
Jérémie Galarneau [Tue, 24 Apr 2018 15:21:37 +0000 (11:21 -0400)] 
Fix: erroneous use of extern keyword

The extern keyword is errneously (or at least, uselessly) used
for an internal API where LTTNG_HIDDEN is meant to be used.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: failure to launch agent thread is not reported
Jérémie Galarneau [Mon, 23 Apr 2018 23:03:16 +0000 (19:03 -0400)] 
Fix: failure to launch agent thread is not reported

A session daemon may fail to launch its agent thread. In such
a case, the tracing of agent domains fails silently as events
never get enabled through the agent.

The problem that was reported was caused by a second session
daemon being already bound on the agent TCP socket port, which
prevented the launch of the agent thread.

While in this situation tracing is still not possible, the user
will at least get an error indicating as such when enabling
an event in those domains.

Reported-by: Deborah Barnard <starfallprojects@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: agent may not be ready on launch
Jérémie Galarneau [Mon, 23 Apr 2018 20:36:25 +0000 (16:36 -0400)] 
Fix: agent may not be ready on launch

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoCleanup: misleading variable name
Jérémie Galarneau [Mon, 23 Apr 2018 19:45:12 +0000 (15:45 -0400)] 
Cleanup: misleading variable name

Using "running" implies that the thread is guaranteed to be
functional/ready. The intention of those "running" flags is only
to indicate that the underlying pthread was created. The thread
may not be running anymore and these flags should not be used
to check if the thread is "ready" to process anything.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: checking for existing session daemon is done after daemonizing
Jérémie Galarneau [Mon, 23 Apr 2018 19:29:39 +0000 (15:29 -0400)] 
Fix: checking for existing session daemon is done after daemonizing

The session daemon checks that no other session daemons are
running only after daemonizing. This means that launching the
deamon in background or daemon modes will appear to succeed even
if the launch failed due to an already present daemon.

The check is performed using both the client socket and the lock
file. This fix also addresses another problem that would cause
the pid file to be overwritten and deleted even if the session daemon
failed to launch.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: null pointer dereference in lttng_rotation_handle_destroy
Jonathan Rajotte [Tue, 10 Apr 2018 20:33:32 +0000 (16:33 -0400)] 
Fix: null pointer dereference in lttng_rotation_handle_destroy

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agosessiond: rename syscall.h so it does not conflict with system
Geneviève Bastien [Thu, 1 Mar 2018 22:11:41 +0000 (17:11 -0500)] 
sessiond: rename syscall.h so it does not conflict with system

Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: Handle rotations happening on two separate days during testing
Jonathan Rajotte [Wed, 4 Apr 2018 19:32:27 +0000 (15:32 -0400)] 
Tests: Handle rotations happening on two separate days during testing

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: Clean trace_path after each subtest
Jonathan Rajotte [Tue, 3 Apr 2018 20:45:23 +0000 (16:45 -0400)] 
Tests: Clean trace_path after each subtest

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: Use for loop for identical validation
Jonathan Rajotte [Tue, 3 Apr 2018 20:36:42 +0000 (16:36 -0400)] 
Tests: Use for loop for identical validation

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: Count number of chunk using ls
Jonathan Rajotte [Tue, 3 Apr 2018 20:01:18 +0000 (16:01 -0400)] 
Tests: Count number of chunk using ls

Instead on removing validated chunk and validate that the directory is
empty, count the number of chunk present at the beginning and validate
that the count is equal to three.

Let the caller take care of cleaning up the generated files.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: quiet option is not set in sessiond-config
Jérémie Galarneau [Tue, 10 Apr 2018 18:40:32 +0000 (14:40 -0400)] 
Fix: quiet option is not set in sessiond-config

The quiet option is currently set directly while parsing the
command line options of the lttng-sessiond. Since it is not
set in the sessiond configuration object, its default value
(false) overwrites the lttng_opt_quiet option when the
configuration is applied.

Reported-by: Stanislav Vovk <stanislav.vovk@windriver.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: hold consumer socket lock for consumer_send_msg
Jonathan Rajotte [Tue, 10 Apr 2018 17:56:47 +0000 (13:56 -0400)] 
Fix: hold consumer socket lock for consumer_send_msg

The lock is held and released during the recv() section, but not
during the send section for a failure to lookup the PID registry.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: use signed member to transport enum value
Jérémie Galarneau [Mon, 9 Apr 2018 19:15:35 +0000 (15:15 -0400)] 
Fix: use signed member to transport enum value

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: use off_t type for lseek function return value to avoid overflow
Gregory LEOCADIE [Thu, 29 Mar 2018 10:52:30 +0000 (12:52 +0200)] 
Fix: use off_t type for lseek function return value to avoid overflow

Context: LTTng is configured in live mode with only one channel, getting
traces for a long-running application (days of uptime)

The trace file gets bigger (many GBs), so the offset (bigger than
int.MaxValue). When getting a packet for such offset, the lseek returns
bigger than int.MaxValue. This value is stored in a variable "ret" of
type int. We have an overflow which leads to sending an error to the
viewer (babeltrace), which stops.
[error] get_data_packet: error.
[error] get_data_packet failed
[error] Unknown return code 0

Signed-off-by: Gregory LEOCADIE <g.leocadie@criteo.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoExtend the rotation API to provide network trace archive locations
Jérémie Galarneau [Sat, 7 Apr 2018 20:07:56 +0000 (16:07 -0400)] 
Extend the rotation API to provide network trace archive locations

The current lttng-ctl rotation API does not allow a user to
differentiate between a network or local trace archive location.

The API currently only provides a "path" which is absolute when
a local rotation is completed, and relative (to an unknown location)
when the trace is streamed to a relay daemon.

This change introduces the lttng_trace_archive_location interface
to express these locations unambiguously. It is currently only
used by the rotation control API, but the intention is to also use
it for future interfaces which need to express a location description.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoIncrease LTTNG_HOST_NAME_MAX from 64 to 255
Jérémie Galarneau [Sat, 7 Apr 2018 20:04:51 +0000 (16:04 -0400)] 
Increase LTTNG_HOST_NAME_MAX from 64 to 255

POSIX guarantees that a host name will not exceed 255 characters.
Moreover, RFC 1035 limits the length of a fully qualified domain name (FQDN)
to 255 characters.

This limit will be used as part of the lttngctl communication
protocol.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoAdd lttng_trace_archive_location lttng-ctl API
Jérémie Galarneau [Thu, 5 Apr 2018 03:21:02 +0000 (23:21 -0400)] 
Add lttng_trace_archive_location lttng-ctl API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoClarify notification channel info ht destruction error log
Jérémie Galarneau [Wed, 4 Apr 2018 18:29:46 +0000 (14:29 -0400)] 
Clarify notification channel info ht destruction error log

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: goto end after end label
Jonathan Rajotte [Wed, 4 Apr 2018 16:20:30 +0000 (12:20 -0400)] 
Fix: goto end after end label

This check was most probably for the previous call and was but after the
end label by mistake. The check is not needed since the end label is
following the call.

CID 1388094 (#1 of 1): Double free (USE_AFTER_FREE)

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
4 years agoCheck return value of cds_lfht_destroy
Jonathan Rajotte [Wed, 4 Apr 2018 16:20:28 +0000 (12:20 -0400)] 
Check return value of cds_lfht_destroy

Bubbling up the error is not an option here. Print and error an move on.

CID 1388096:  Error handling issues  (CHECKED_RETURN)

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
4 years agoFix: destroy schedule attr
Jonathan Rajotte [Wed, 4 Apr 2018 16:20:29 +0000 (12:20 -0400)] 
Fix: destroy schedule attr

CID 1388095 (#9-14 of 14): Resource leak (RESOURCE_LEAK)

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
4 years agoTests: fix oot and dist for rotation tests
Jonathan Rajotte [Tue, 3 Apr 2018 23:09:40 +0000 (19:09 -0400)] 
Tests: fix oot and dist for rotation tests

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: add rotation tests scripts to noinst_SCRIPTS and EXTRA_DIST
Jérémie Galarneau [Tue, 3 Apr 2018 22:21:28 +0000 (18:21 -0400)] 
Tests: add rotation tests scripts to noinst_SCRIPTS and EXTRA_DIST

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: SESSION_NAME defined on each iteration of kernel rotation test
Jonathan Rajotte [Wed, 28 Mar 2018 19:53:56 +0000 (15:53 -0400)] 
Tests: SESSION_NAME defined on each iteration of kernel rotation test

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: Reduce scope of TRACE_PATH to a function
Jonathan Rajotte [Wed, 28 Mar 2018 19:47:31 +0000 (15:47 -0400)] 
Tests: Reduce scope of TRACE_PATH to a function

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: PID_RELAYD is never used
Jonathan Rajotte [Wed, 28 Mar 2018 19:30:25 +0000 (15:30 -0400)] 
Tests: PID_RELAYD is never used

Irrelevant since before 1c362dc78cf2e28c8935efcb5d4a85ef5d5967ba

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: use functions from utils.sh in rotation tests
Jonathan Rajotte [Wed, 28 Mar 2018 16:05:11 +0000 (12:05 -0400)] 
Tests: use functions from utils.sh in rotation tests

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: consolidate session creation with a uri parameter in utils.sh
Jonathan Rajotte [Wed, 28 Mar 2018 17:56:27 +0000 (13:56 -0400)] 
Tests: consolidate session creation with a uri parameter in utils.sh

Introduce a new create_lttng_session_uri test helper.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: use modprobe to test for the presence of lttng-modules
Jonathan Rajotte [Wed, 28 Mar 2018 19:21:26 +0000 (15:21 -0400)] 
Tests: use modprobe to test for the presence of lttng-modules

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: missing license header in rotation utils
Jonathan Rajotte [Wed, 28 Mar 2018 19:21:00 +0000 (15:21 -0400)] 
Tests: missing license header in rotation utils

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: missing parenthesis in userspace rotation test
Jonathan Rajotte [Thu, 22 Mar 2018 20:15:25 +0000 (16:15 -0400)] 
Tests: missing parenthesis in userspace rotation test

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: use enable_ust_lttng_channel_ok instead of a custom lttng invocation
Jonathan Rajotte [Thu, 22 Mar 2018 20:14:53 +0000 (16:14 -0400)] 
Tests: use enable_ust_lttng_channel_ok instead of a custom lttng invocation

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: remove TRACE_PATH at the end of the rotation test only
Jonathan Rajotte [Thu, 22 Mar 2018 20:13:35 +0000 (16:13 -0400)] 
Tests: remove TRACE_PATH at the end of the rotation test only

Clean the inside of TRACE_PATH directory between each test but do not
delete the actual directory.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: exit $out gets overridden by EXIT trap from tap/tap.sh
Jonathan Rajotte [Wed, 21 Mar 2018 18:29:58 +0000 (14:29 -0400)] 
Tests: exit $out gets overridden by EXIT trap from tap/tap.sh

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: Use SIGTERM instead of SIGKILL
Jonathan Rajotte [Thu, 29 Mar 2018 20:19:39 +0000 (16:19 -0400)] 
Tests: Use SIGTERM instead of SIGKILL

The use of SIGKILL does not guarantee the immediate termination of sub
background task. Using SIGTERM allows the generator to finish cleanly.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoAdd --post-script to tap-driver.sh
Jonathan Rajotte [Thu, 29 Mar 2018 20:16:26 +0000 (16:16 -0400)] 
Add --post-script to tap-driver.sh

Allow warn_process.sh to be run between each test to validate that a
test does not leave ghost processes.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoTests: add rotation tests to the "check" target
Jérémie Galarneau [Tue, 3 Apr 2018 16:01:33 +0000 (12:01 -0400)] 
Tests: add rotation tests to the "check" target

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
4 years agoFix: fail on truncation of kernel channel path
Jérémie Galarneau [Wed, 28 Feb 2018 21:32:26 +0000 (16:32 -0500)] 
Fix: fail on truncation of kernel channel path

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.069613 seconds and 4 git commands to generate.