lttng-tools.git
7 years agoFix: test: java-jul:missing static test files for dist and out of tree build
Jonathan Rajotte [Fri, 30 Jan 2015 22:04:56 +0000 (17:04 -0500)] 
Fix: test: java-jul:missing static test files for dist and out of tree build

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
7 years agoFix: out-of-tree build: missing xsd file for mi test execution
Jonathan Rajotte [Fri, 30 Jan 2015 18:30:11 +0000 (13:30 -0500)] 
Fix: out-of-tree build: missing xsd file for mi test execution

This need to be backported to stable 2.6.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: out-of-tree build: missing xsd file for save-load test execution
Jonathan Rajotte [Fri, 30 Jan 2015 18:30:10 +0000 (13:30 -0500)] 
Fix: out-of-tree build: missing xsd file for save-load test execution

This need to be backported to stable 2.6 and stable 2.5

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove unused end_no_session label in ust_app_flush_session()
Jérémie Galarneau [Fri, 30 Jan 2015 06:47:56 +0000 (01:47 -0500)] 
Cleanup: remove unused end_no_session label in ust_app_flush_session()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Remove unused "end" label in push_metadata()
Jérémie Galarneau [Fri, 30 Jan 2015 06:47:11 +0000 (01:47 -0500)] 
Cleanup: Remove unused "end" label in push_metadata()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTests: Run health check test_thread_ok as part of root_regression
Jérémie Galarneau [Mon, 26 Jan 2015 17:14:13 +0000 (12:14 -0500)] 
Tests: Run health check test_thread_ok as part of root_regression

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: deadlock between UST registry lock and consumer lock
Mathieu Desnoyers [Fri, 23 Jan 2015 16:29:00 +0000 (11:29 -0500)] 
Fix: deadlock between UST registry lock and consumer lock

Reorganize locking of ust registry and consumer socket communication.

commit ce34fcd0 "Fix: per-uid flush and ust registry locking" attempted
to fix locking related to the UST registry, but doing so introduced a
deadlock. The actual solution is to reverse the order in which the UST
registry and the consumer lock nest: the UST registry will now to
responsible for serializing the registry content, and the consumer lock
will only protect communication with the consumer, as it should. This
deals with a TODO in the code.

The reason why this was not done from the beginning is that there was
originally an intent to make sure the ust registry lock is not held for
a long time, thus not while communicating with the consumer daemon.
However, when live has been implemented, it required communication with
the consumer daemon while the ust registry is held anyway. Therefore,
there is not much point anymore in trying to make sure this lock is not
held across the communication with consumerd in push_metadata. This
allows us to greatly simplify locking of the UST registry.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: uninitialized return value
Mathieu Desnoyers [Fri, 23 Jan 2015 16:28:59 +0000 (11:28 -0500)] 
Fix: uninitialized return value

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: build failure using disable-lttng-ust configure option
Jérémie Galarneau [Thu, 22 Jan 2015 20:17:34 +0000 (15:17 -0500)] 
Fix: build failure using disable-lttng-ust configure option

A stub for ust_app_get_size_one_more_packet_per_stream() is missing
which causes the build to fail when using the --disable-lttng-ust
configuration option.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Remove unused variable
Jérémie Galarneau [Thu, 22 Jan 2015 20:04:35 +0000 (15:04 -0500)] 
Cleanup: Remove unused variable

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: setuid/setgid daemons should not get sensitive env. var./args
Mathieu Desnoyers [Fri, 16 Jan 2015 17:48:20 +0000 (12:48 -0500)] 
Fix: setuid/setgid daemons should not get sensitive env. var./args

Also, don't allow lttng command line interface to run as setuid/setgid
binary.

Fixes #780

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: grab more than one packet for snapshots
Mathieu Desnoyers [Thu, 15 Jan 2015 22:24:27 +0000 (17:24 -0500)] 
Fix: grab more than one packet for snapshots

There are a few issues with snapshot size: when taking a snapshot
without specifying any "max size" (should be unlimited), only a single
packet from each stream is saved. We expect all stream available content
to be saved. There is a similar issue when a max size is specified.

Also, trying to make all streams save as much data has unexpected
corner-cases: for instance, if we have this configuration:
- kernel channels: 2 subbuffers of 1MB x 8 CPUs
- per-PID UST channels: 16 subbuffers of 4kB x 8 CPUs x 100 apps

would require the user to have a very large max size, since it would try
to fit (8 + (100 * 8)) * 1MB = 808MB of sub-buffers, else it would fail.
This issue here is using the largest subbuffer size as the criterion
applied to all channels.

We fix those issues by simplifying the algorithm used to calculate how
much data to grab. Rather than calculating the size to grab from each
stream, we calculate a number of packets to grab. It fails if we cannot
grab at least one packet from each stream in the session. Then checks if
it can grab 2 packets from each stream, and so on, until there is no
more space available (based on max size). This is not a perfect
solution, but has the merit of being simple to understand, and has no
(or few) unexpected corner-cases.

Fixes #860

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: per-uid flush and ust registry locking
Mathieu Desnoyers [Thu, 15 Jan 2015 22:24:26 +0000 (17:24 -0500)] 
Fix: per-uid flush and ust registry locking

Commit c4b88406 "Fix: ust-app: per-PID app unregister vs tracing stop
races" introduces a regression for per-UID flush. It can be triggered by
the test_high_throughput_limits (root regression) test. For per-UID
tracing, we need to use the registry channel ID, not the per-application
channel ID, when asking the consumer daemon to flush.

When doing this fix, we notice that the locking rules of push_metadata()
are weird. A per-ust app session lock is protecting registry data, which
makes it impossible to call push_metadata from a ust session level (for
the entire session) in the case of per-UID tracing. Moreover, it's
unclear how holding a per-application lock can protect a registry shared
across applications in per-UID tracing. Therefore, we move all accesses
to the registry metadata_key and metadata_closed fields into the
registry lock critical section. We now only rely on RCU to ensure
existance of registry across push_metadata(), rather than relying on the
per-application session lock.

It also takes care of a documentation vs code mismatch: push_metadata()
documents that "The session lock MUST be acquired here before calling
this.", but in reality, it's the application session lock which is held
across those calls. Removing this requirement, and relying on RCU
instead, fixes this mismatch.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: Missing optional dependency on lttng-ust in README.md
Jérémie Galarneau [Thu, 15 Jan 2015 20:39:20 +0000 (15:39 -0500)] 
Docs: Missing optional dependency on lttng-ust in README.md

Reported-by: Jonathan Rajotte <jonathan.rajotte@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: Grammar fixes in the lttng manpage
Jérémie Galarneau [Wed, 14 Jan 2015 23:41:10 +0000 (18:41 -0500)] 
Docs: Grammar fixes in the lttng manpage

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: add missing UST perf counter support check
Mathieu Desnoyers [Mon, 12 Jan 2015 22:14:52 +0000 (17:14 -0500)] 
Fix: add missing UST perf counter support check

Report whether performance counters are supported by UST on the
architecture as soon as the user try to enable a perf counter context.

Fixes #851

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: tests: integer too large for long type
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:12 +0000 (17:21 -0500)] 
Fix: tests: integer too large for long type

Compiler warns on 32-bit builds.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: undefined operation on last_relay_viewer_session_id
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:11 +0000 (17:21 -0500)] 
Fix: undefined operation on last_relay_viewer_session_id

Triggers compiler warning on 32-bit build.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: print format type mismatch
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:10 +0000 (17:21 -0500)] 
Fix: print format type mismatch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: print format type mismatch
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:09 +0000 (17:21 -0500)] 
Fix: print format type mismatch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Remove structurally dead code from relayd
Jérémie Galarneau [Thu, 8 Jan 2015 23:06:20 +0000 (18:06 -0500)] 
Fix: Remove structurally dead code from relayd

CID 1262070:  Structurally dead code  (UNREACHABLE)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Remove logically dead code
Jérémie Galarneau [Thu, 8 Jan 2015 22:57:11 +0000 (17:57 -0500)] 
Cleanup: Remove logically dead code

*** CID 1262071:  Logically dead code  (DEADCODE)
/src/bin/lttng-sessiond/ht-cleanup.c: 130 in thread_ht_cleanup()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Remove unused label
Jérémie Galarneau [Thu, 8 Jan 2015 21:02:13 +0000 (16:02 -0500)] 
Cleanup: Remove unused label

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Remove unused argument in debug statement
Jérémie Galarneau [Thu, 8 Jan 2015 20:43:24 +0000 (15:43 -0500)] 
Fix: Remove unused argument in debug statement

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: exit threads not only on goto restart
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:08 +0000 (16:43 -0500)] 
Fix: exit threads not only on goto restart

Exit threads as soon as number of FD is 0, on every loop (no need for
goto restart special case). Number of FD being 0 is a sufficient
condition for exiting the thread: it means the quit pipe has been
removed from the poll set.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: poll: show the correct number of fds
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:07 +0000 (16:43 -0500)] 
Fix: poll: show the correct number of fds

LTTNG_POLL_GETNB() uses wait nb_fd, which is only updated after
lttng_poll_wait returns.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: call lttng_poll_set_max_size before start threads
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:06 +0000 (16:43 -0500)] 
Fix: call lttng_poll_set_max_size before start threads

This changes the location of lttng_poll_set_max_size() call within
sessiond main() to call it before creating the ht_cleanup thread. This
fix is only needed on top of the main refactoring patch.

This fix also adds checks for lttng_poll_set_max_size() error values.

Fixes #747

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: compat poll: add missing empty revents checks
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:05 +0000 (16:43 -0500)] 
Fix: compat poll: add missing empty revents checks

Poll returns the entire array, including entries that have no activity.
We need to check them explicitly.

Fixes #747

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: various compat poll/epoll issues
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:04 +0000 (16:43 -0500)] 
Fix: various compat poll/epoll issues

poll:
- fix two nb_fd off by one in "add",
- simplify array size calculation,
- add error checking,
- compress the content of array before resizing it on "del"
  (out-of-bound memory access issue),
- set wait.nb_fd = 0 when no FD are present in array on wait,
- remove need_realloc flag: this can be checked internally by comparing
  current->alloc_size and wait->alloc_size. Minimize the number of
  duplicated state.

epoll:
- add error checking,
- simplify array size calculation (make it similar to poll),
- Set default size when poll_max_size is 0 within
  compat_epoll_set_max_size(), which allow better error checking
  elsewhere in epoll compat code.

Fixes #747

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoAdd debugging output to ht-cleanup thread
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:03 +0000 (16:43 -0500)] 
Add debugging output to ht-cleanup thread

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: mi: snapshot: missing error handling for session name
Jonathan Rajotte [Tue, 6 Jan 2015 15:59:47 +0000 (10:59 -0500)] 
Fix: mi: snapshot: missing error handling for session name

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ust-app: per-PID app unregister vs tracing stop races
Mathieu Desnoyers [Mon, 5 Jan 2015 02:25:09 +0000 (21:25 -0500)] 
Fix: ust-app: per-PID app unregister vs tracing stop races

There are various races with UST application unregister performed
concurrently with tracing stop operation when tracing with per-pid
buffers. This randomly affects availability of data shortly after the
data pending check returns that no more data is available.

ust_app_stop_trace_all() iterates on all applications in the ust_app_ht
hash table to issue a flush on all buffers. This is needed to ensure
that the sub-buffers being written to are made available to the
consumer, for both data consumption, and for the data pending check.
Failure to execute the sub-buffer flush makes following data pending
check return that there is no data in the buffers too early, thus
resulting in an incomplete trace.

It is therefore important that an application flushes all its buffers
before it is removed from the ust_app_ht.

This is where ust_app_unregister() needs to be fixed. Note that
ust_app_unregister() executes concurrently with
ust_app_stop_trace_all(), only taking the per-session lock. The order of
flush vs hash table removal therefore matters:

We need to push the metadata before removing application from
ust_app_ht. We also need to issue a flush for all application buffers
before removing the application from ust_app_ht.

Once this is fixed, there is yet another race, this time in
ust_app_flush_trace() (now renamed ust_app_flush_session()). It is
caused by the use of ustctl_sock_flush_buffer() which asks the
application to perform the buffer flush. Unfortunately, if the
application vanishes (not reachable anymore), but its unregistration has
not yet been processed by sessiond, then ust_app_stop_trace_all() will
fail to flush the application buffers, because
ustctl_sock_flush_buffer() will fail.

This final issue is fixed by asking the consumer daemon to flush the
associated channel rather than relying on the application.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: data pending: allow empty streams
Mathieu Desnoyers [Mon, 5 Jan 2015 02:25:08 +0000 (21:25 -0500)] 
Fix: data pending: allow empty streams

There are cases where a stream can be completely empty (no packet to
write) with UST: for instance, if a traced application is either
preempted for a long time, terminated, or stopped, between reserve and
commit. This will make the consumer consider that this stream has no
data ready. If this situation occurs in the first sub-buffer of a
stream, this stream will have no data at all (0 bytes).

Therefore, we need to let the data pending check consider that no data
is pending in this situation, otherwise it can make the data pending
check always return that there is data pending.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ust snapshot: cleanup after error
Mathieu Desnoyers [Mon, 5 Jan 2015 02:25:07 +0000 (21:25 -0500)] 
Fix: ust snapshot: cleanup after error

The "break" statement on error skips the rest of the functions, thus
leaving test applications running after the end of the test, which is a
side-effect on the following tests.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Mismatching return type in ust_app_ht_alloc() stub
Jérémie Galarneau [Wed, 7 Jan 2015 21:46:53 +0000 (16:46 -0500)] 
Fix: Mismatching return type in ust_app_ht_alloc() stub

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: lock file already taken is error, not warning
Mathieu Desnoyers [Mon, 5 Jan 2015 20:58:49 +0000 (15:58 -0500)] 
Cleanup: lock file already taken is error, not warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ust-app null pointer check needed for main refactoring
Mathieu Desnoyers [Mon, 5 Jan 2015 20:05:22 +0000 (15:05 -0500)] 
Fix: ust-app null pointer check needed for main refactoring

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: relayd: centralize thread stopping function
Mathieu Desnoyers [Thu, 18 Dec 2014 18:02:07 +0000 (13:02 -0500)] 
Cleanup: relayd: centralize thread stopping function

Rather than relying on having main.c and live.c threads both using the
same notification pipe from different stop_thread implementations,
centralize thread stop in one central function exposed to both main.c
and live.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Replace all perror() uses by the PERROR macro
Jérémie Galarneau [Mon, 5 Jan 2015 21:30:41 +0000 (16:30 -0500)] 
Cleanup: Replace all perror() uses by the PERROR macro

PERROR prints the perror() message in our own logging format rather
than going straight to stderr.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoRefactor relayd main/set_options/cleanup
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:24 +0000 (20:45 -0500)] 
Refactor relayd main/set_options/cleanup

- Enforce symmetry between allocation and teardown,
- Handle all errors,
- Return all errors as EXIT_FAILURE,
- Standardize on zero being success, nonzero being error,
  (rather than < 0 being error),
- Fix pthread PERROR: we need to store ret into errno before
  calling PERROR, since pthread API does not set errno,
- Join errors now fall-through, rather than rely on the OS
  to teardown the rest.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoRefactor consumerd main/cleanup
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:23 +0000 (20:45 -0500)] 
Refactor consumerd main/cleanup

- Enforce symmetry between allocation and teardown,
- Handle all errors,
- Return all errors as EXIT_FAILURE,
- Standardize on zero being success, nonzero being error,
  (rather than < 0 being error),
- Fix pthread PERROR: we need to store ret into errno before
  calling PERROR, since pthread API does not set errno,
- Join errors now fall-through, rather than rely on the OS
  to teardown the rest.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoRefactor sessiond main/cleanup/ht-cleanup
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:22 +0000 (20:45 -0500)] 
Refactor sessiond main/cleanup/ht-cleanup

Main reason for this entire patchset: move teardown of ht-cleanup thread
_after_ the sessiond cleanup which needs to destroy hash tables. This
fixes leaks at sessiond teardown that makes the valgrind output hard to
use. As this has been done, various other issues with error handling,
leaks, and symmetry of allocation and teardown have been fixed, which
makes this a refactoring.

- Enforce symmetry between allocation and teardown,
- Handle all errors,
- Return all errors as EXIT_FAILURE,
- Standardize on zero being success, nonzero being error,
  (rather than < 0 being error),
- Fix pthread PERROR: we need to store ret into errno before
  calling PERROR, since pthread API does not set errno,
- Join errors now fall-through, rather than rely on the OS
  to teardown the rest.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMissing error handling: consumer_signal_init should return its error status
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:21 +0000 (20:45 -0500)] 
Missing error handling: consumer_signal_init should return its error status

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: consumerd: lines over 80 columns
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:20 +0000 (20:45 -0500)] 
Cleanup: consumerd: lines over 80 columns

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: consumerd: use PERROR rather than perror
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:19 +0000 (20:45 -0500)] 
Cleanup: consumerd: use PERROR rather than perror

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoCleanup: lttng-consumerd: remove stale TODO comment
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:18 +0000 (20:45 -0500)] 
Cleanup: lttng-consumerd: remove stale TODO comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMisleading error handling: utils_create_pid_file() should return 0 on success
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:17 +0000 (20:45 -0500)] 
Misleading error handling: utils_create_pid_file() should return 0 on success

fprintf returns a positive value on success, which is used as return
value for utils_create_pid_file(), which is odd. This is in preparation
for main() refactoring.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMissing error handling: consumerd parse_args should return errors to caller
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:16 +0000 (20:45 -0500)] 
Missing error handling: consumerd parse_args should return errors to caller

In preparation for having main() handle the return value.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMissing error handling: ust_app_ht_alloc should return error status
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:15 +0000 (20:45 -0500)] 
Missing error handling: ust_app_ht_alloc should return error status

In preparation for having sessiond main() handle the error.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ust app leak on UST buffer creation error
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:14 +0000 (20:45 -0500)] 
Fix: ust app leak on UST buffer creation error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: leak on UST buffer registry creation error
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:13 +0000 (20:45 -0500)] 
Fix: leak on UST buffer registry creation error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: agents ht leaks on destroy session
Mathieu Desnoyers [Thu, 18 Dec 2014 01:45:12 +0000 (20:45 -0500)] 
Fix: agents ht leaks on destroy session

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: add missing RCU read unlock
Mathieu Desnoyers [Wed, 24 Dec 2014 17:10:01 +0000 (12:10 -0500)] 
Fix: add missing RCU read unlock

Master commit 24eb8569dc841f318d7964ca9a0ad0a4f9508a8e
"Fix: Missing RCU read locks in syscall_list_channel()"

Introduces unbalanced RCU read-side lock/unlock. Should be applied to
master and stable-2.6.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: help message for Python agent mentions Java
Julien Desfossez [Fri, 12 Dec 2014 14:53:40 +0000 (09:53 -0500)] 
Fix: help message for Python agent mentions Java

Bad copy/paste.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: don't destroy the sockets if the snapshot was successful
Julien Desfossez [Tue, 9 Dec 2014 21:38:05 +0000 (16:38 -0500)] 
Fix: don't destroy the sockets if the snapshot was successful

Missing a goto to skip the error condition that was destroying the
relayd sockets even if a snapshot was successful. We want to keep them
open to reuse them for the next snapshots.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Missing RCU read locks in syscall_list_channel()
Jérémie Galarneau [Tue, 2 Dec 2014 03:07:03 +0000 (22:07 -0500)] 
Fix: Missing RCU read locks in syscall_list_channel()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Missing RCU read lock in kernel_destroy_session()
Jérémie Galarneau [Tue, 2 Dec 2014 03:06:23 +0000 (22:06 -0500)] 
Fix: Missing RCU read lock in kernel_destroy_session()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: channel names are not validated
Philippe Proulx [Thu, 27 Nov 2014 22:35:32 +0000 (17:35 -0500)] 
Fix: channel names are not validated

This patch ensures:

  1. A channel name does not contain any '/' character, since
     relative paths may be injected in the channel name
     otherwise (knowing that the channel name is eventually
     part of a file name)
  2. A channel name does not start with a '.' character, since
     trace readers (Babeltrace is one of them) could interpret
     files starting with a dot as hidden files and ignore
     them when opening the CTF trace

Fixes: #751
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Missing whitespace
Jérémie Galarneau [Mon, 1 Dec 2014 21:16:16 +0000 (16:16 -0500)] 
Cleanup: Missing whitespace

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Apply consumer URI changes to all domains
Jérémie Galarneau [Mon, 1 Dec 2014 21:15:49 +0000 (16:15 -0500)] 
Fix: Apply consumer URI changes to all domains

See the associated bug report for a lenghty explanation of the issue
and of this fix. It fixes an issue when saving a live session's
configuration that was created by loading an .lttng file.

Fixes #866

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Fix a typo in the MI tests
Jérémie Galarneau [Mon, 1 Dec 2014 03:07:44 +0000 (22:07 -0500)] 
Cleanup: Fix a typo in the MI tests

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTest fix: Don't invoke the system's lttng client
Jérémie Galarneau [Mon, 1 Dec 2014 03:06:47 +0000 (22:06 -0500)] 
Test fix: Don't invoke the system's lttng client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTests: Add a test to check disabled events are loaded in the correct state
Jérémie Galarneau [Fri, 28 Nov 2014 16:51:49 +0000 (11:51 -0500)] 
Tests: Add a test to check disabled events are loaded in the correct state

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Don't leave events enabled if they were saved in a disabled state
Jérémie Galarneau [Fri, 28 Nov 2014 16:07:17 +0000 (11:07 -0500)] 
Fix: Don't leave events enabled if they were saved in a disabled state

Events are enabled by default on creation. The session configuration
loader must make sure to disable them after creation when restoring an
event that was saved in the "disabled" state.

Reported-by: Marcel Hamer <marcel.hamer@ericsson.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: "Any" loglevel's value is -1 and not 0
Jérémie Galarneau [Fri, 28 Nov 2014 23:08:30 +0000 (18:08 -0500)] 
Fix: "Any" loglevel's value is -1 and not 0

lttng_disable_event_ext() was erroring-out on loglevel != 0.
loglevel 0 is a valid level whereas "-1" is used an unknown/unspecified
in the rest of the code.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTest fix: LTTNG_SESSION_CONFIG_XSD_PATH expects an absolute path
Jérémie Galarneau [Fri, 28 Nov 2014 16:58:32 +0000 (11:58 -0500)] 
Test fix: LTTNG_SESSION_CONFIG_XSD_PATH expects an absolute path

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Memory leak on error in alloc_argv_from_user_opts()
Jérémie Galarneau [Thu, 27 Nov 2014 22:23:48 +0000 (17:23 -0500)] 
Fix: Memory leak on error in alloc_argv_from_user_opts()

*** CID 1256181:  Resource leak  (RESOURCE_LEAK)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Unchecked close() return value in utils_create_lock_file()
Jérémie Galarneau [Wed, 26 Nov 2014 23:02:22 +0000 (18:02 -0500)] 
Cleanup: Unchecked close() return value in utils_create_lock_file()

*** CID 1226188:  Unchecked return value  (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: No check of the return value of lttng_ht_del()
Jérémie Galarneau [Wed, 26 Nov 2014 23:01:45 +0000 (18:01 -0500)] 
Cleanup: No check of the return value of lttng_ht_del()

*** CID 1230590:  Unchecked return value  (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Mixed enums used for return code in send_sessiond_channel()
Jérémie Galarneau [Wed, 26 Nov 2014 22:34:21 +0000 (17:34 -0500)] 
Cleanup: Mixed enums used for return code in send_sessiond_channel()

*** CID 1132649:  Inferred misuse of enum  (MIXED_ENUMS)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: Cast poll() return value to void
Jérémie Galarneau [Wed, 26 Nov 2014 22:29:16 +0000 (17:29 -0500)] 
Cleanup: Cast poll() return value to void

*** CID 1019969:  Unchecked return value from library  (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Unreachable error logging in set_option()
Jérémie Galarneau [Wed, 26 Nov 2014 21:20:21 +0000 (16:20 -0500)] 
Fix: Unreachable error logging in set_option()

*** CID 1256136:  Logically dead code  (DEADCODE)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: OOM leaks in sessiond modprobe.c
Mathieu Desnoyers [Wed, 26 Nov 2014 18:00:03 +0000 (13:00 -0500)] 
Fix: OOM leaks in sessiond modprobe.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: sessiond modprobe.c: coding style
Mathieu Desnoyers [Wed, 26 Nov 2014 17:44:51 +0000 (12:44 -0500)] 
Cleanup: sessiond modprobe.c: coding style

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: test_utils_expand_path.c prototypes
Mathieu Desnoyers [Wed, 26 Nov 2014 17:43:54 +0000 (12:43 -0500)] 
Cleanup: test_utils_expand_path.c prototypes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: test_utils_expand_path.c: out of memory error handling
Mathieu Desnoyers [Wed, 26 Nov 2014 17:43:32 +0000 (12:43 -0500)] 
Fix: test_utils_expand_path.c: out of memory error handling

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: test test_ust_data.c: check OOM
Mathieu Desnoyers [Wed, 26 Nov 2014 17:39:13 +0000 (12:39 -0500)] 
Fix: test test_ust_data.c: check OOM

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: test libc-wrapper: check malloc OOM
Mathieu Desnoyers [Wed, 26 Nov 2014 17:38:21 +0000 (12:38 -0500)] 
Fix: test libc-wrapper: check malloc OOM

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: test libc-wrapper: main parameters
Mathieu Desnoyers [Wed, 26 Nov 2014 17:37:54 +0000 (12:37 -0500)] 
Cleanup: test libc-wrapper: main parameters

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lttng-ctl: use zmalloc(), missing OOM check
Mathieu Desnoyers [Wed, 26 Nov 2014 17:37:21 +0000 (12:37 -0500)] 
Fix: lttng-ctl: use zmalloc(), missing OOM check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: filter-parser.y: use zmalloc(), missing OOM check
Mathieu Desnoyers [Wed, 26 Nov 2014 17:36:37 +0000 (12:36 -0500)] 
Fix: filter-parser.y: use zmalloc(), missing OOM check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: utils.c: check str*dup OOM
Mathieu Desnoyers [Wed, 26 Nov 2014 17:36:03 +0000 (12:36 -0500)] 
Fix: utils.c: check str*dup OOM

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: implement zmalloc as static inline
Mathieu Desnoyers [Wed, 26 Nov 2014 17:34:56 +0000 (12:34 -0500)] 
Cleanup: implement zmalloc as static inline

Whenever we can implement as static inline rather than macro, it's
better (type checking of arguments, less chances of hitting preprocessor
aweful semantic corner-cases....).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: rculfhash: use zmalloc()
Mathieu Desnoyers [Wed, 26 Nov 2014 17:34:26 +0000 (12:34 -0500)] 
Fix: rculfhash: use zmalloc()

Follow lttng-tools rules.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ini.c: use zmalloc()
Mathieu Desnoyers [Wed, 26 Nov 2014 17:34:01 +0000 (12:34 -0500)] 
Fix: ini.c: use zmalloc()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lttng lttng.c: check strdup OOM
Mathieu Desnoyers [Wed, 26 Nov 2014 17:33:34 +0000 (12:33 -0500)] 
Fix: lttng lttng.c: check strdup OOM

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lttng conf.c: use zmalloc()
Mathieu Desnoyers [Wed, 26 Nov 2014 17:33:09 +0000 (12:33 -0500)] 
Fix: lttng conf.c: use zmalloc()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lttng view.c missing strdup OOM check
Mathieu Desnoyers [Wed, 26 Nov 2014 17:32:28 +0000 (12:32 -0500)] 
Fix: lttng view.c missing strdup OOM check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: use zmalloc() in lttng view.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:32:13 +0000 (12:32 -0500)] 
Fix: use zmalloc() in lttng view.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: use zmalloc() in lttng list.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:31:52 +0000 (12:31 -0500)] 
Fix: use zmalloc() in lttng list.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: oom error check, realloc oom leak
Mathieu Desnoyers [Wed, 26 Nov 2014 17:30:18 +0000 (12:30 -0500)] 
Fix: oom error check, realloc oom leak

print_exclusions can return a NULL pointer on OOM, should be checked.
Also, realloc always need to store result in a different variable than
its input in case it fails (and its returned pointer needs to be checked
for NULL).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: use zmalloc in lttng enable_events.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:29:43 +0000 (12:29 -0500)] 
Fix: use zmalloc in lttng enable_events.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: missing strdup oom check in lttng create.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:27:29 +0000 (12:27 -0500)] 
Fix: missing strdup oom check in lttng create.c

Introduce tmp_path to ensure that no code path can possibly try to free
the return value of utils_get_home_dir(). Re-using alloc_path for both
static and dynamically allocated pointer is error-prone.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lttng add_context.c: use zmalloc
Mathieu Desnoyers [Wed, 26 Nov 2014 17:25:55 +0000 (12:25 -0500)] 
Fix: lttng add_context.c: use zmalloc

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: add missing static to function modprobe_remove_lttng()
Mathieu Desnoyers [Wed, 26 Nov 2014 17:18:40 +0000 (12:18 -0500)] 
Cleanup: add missing static to function modprobe_remove_lttng()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: add missing str*dup oom check in sessiond main.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:18:07 +0000 (12:18 -0500)] 
Fix: add missing str*dup oom check in sessiond main.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: add missing sessiond kernel-consumer missing str*dup oom checks
Mathieu Desnoyers [Wed, 26 Nov 2014 17:17:26 +0000 (12:17 -0500)] 
Fix: add missing sessiond kernel-consumer missing str*dup oom checks

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: add missing strdup OOM check
Mathieu Desnoyers [Wed, 26 Nov 2014 17:16:19 +0000 (12:16 -0500)] 
Fix: add missing strdup OOM check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: add missing synchronization point for before app test case
Mathieu Desnoyers [Thu, 20 Nov 2014 06:40:41 +0000 (07:40 +0100)] 
Fix: add missing synchronization point for before app test case

Fixes a race where the application could generate all its events before
trace start.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: tests: wait output hide Terminate errors
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:31 +0000 (22:40 +0100)] 
Fix: tests: wait output hide Terminate errors

Also: Don't hide kill errors.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.068304 seconds and 4 git commands to generate.