lttng-tools.git
7 years agoUpdate changelog with stable 2.3 and 2.4 branch
David Goulet [Tue, 25 Feb 2014 17:01:59 +0000 (12:01 -0500)] 
Update changelog with stable 2.3 and 2.4 branch

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: only create UST metadata on start trace
David Goulet [Tue, 25 Feb 2014 16:03:35 +0000 (11:03 -0500)] 
Fix: only create UST metadata on start trace

Fixes #739

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoRevert "Fix: wrong condition on startup for low-activity streams"
David Goulet [Mon, 24 Feb 2014 19:35:05 +0000 (14:35 -0500)] 
Revert "Fix: wrong condition on startup for low-activity streams"

This reverts commit d3aac146d0800fe9820d51e5b9fa52e7543c1237.

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: missing big endian conversion for one index field
Julien Desfossez [Mon, 24 Feb 2014 18:34:00 +0000 (13:34 -0500)] 
Fix: missing big endian conversion for one index field

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: wrong condition on startup for low-activity streams
Julien Desfossez [Mon, 24 Feb 2014 18:02:19 +0000 (13:02 -0500)] 
Fix: wrong condition on startup for low-activity streams

If we only received and sent one index, we should not be in the retry
condition.
The rstream->total_index_received == vstream->last_sent_index is checked
before.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: perror on index directory creation error
Julien Desfossez [Mon, 24 Feb 2014 18:02:18 +0000 (13:02 -0500)] 
Fix: perror on index directory creation error

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoComments fix: lttngerr.h -> error.h (./Changelog:754)
Jonathan Rajotte [Mon, 24 Feb 2014 00:50:52 +0000 (19:50 -0500)] 
Comments fix: lttngerr.h -> error.h (./Changelog:754)

Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: consumerd errors on exit
Mathieu Desnoyers [Fri, 21 Feb 2014 15:14:46 +0000 (10:14 -0500)] 
Fix: consumerd errors on exit

- The LTTNG_CONSUMER_STOP command is not used by sessiond anymore, so
  deprecate it,
- Ensure that the normal teardown (with signal handler) does not trigger
  a health error in consumer daemon by distinguishing between errors and
  "should exit" with different lttng_consumer_poll_socket() return values.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: scanf unbounded input
Mathieu Desnoyers [Fri, 21 Feb 2014 03:53:04 +0000 (22:53 -0500)] 
Fix: scanf unbounded input

Awaiting a proper cleanup (introducing nscanf), do what we can to
validate the scanf input using its utterly broken API.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: miscellaneous memory handling fixes
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:46 +0000 (10:23 -0500)] 
Fix: miscellaneous memory handling fixes

Issues found with Valgrind:

- Uninitialized memory sent through sendmsg,
- Uninitialized realloc memory,
- Erroneous pointer arithmetic in jul_list_events(),
- Memory leaks in kernel_consumer_add_channel(),
  kernel_consumer_add_metadata(),
- Memory leak (snapshot_destroy missing hash table cleanup),
- Uninitialized poll/epoll memory on realloc.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: add missing VALGRIND ifdef checks and documentation
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:45 +0000 (10:23 -0500)] 
Fix: add missing VALGRIND ifdef checks and documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: race with index file creation
Julien Desfossez [Fri, 14 Feb 2014 19:25:26 +0000 (14:25 -0500)] 
Fix: race with index file creation

Only the data thread should create the index file since it is
responsible of filling the FD field of the index struct in memory.
When the control thread is ready to write the index, the FD is already
set.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: deadlock during rotation
Julien Desfossez [Fri, 14 Feb 2014 20:51:34 +0000 (15:51 -0500)] 
Fix: deadlock during rotation

The overwrite_lock is nested inside the viewer_stream_rotation_lock.
And the viewer_stream_rotate function is always called with the
viewer_stream_rotation_lock held.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: simplify get next index in live
David Goulet [Thu, 13 Feb 2014 18:58:19 +0000 (13:58 -0500)] 
Fix: simplify get next index in live

This fixes some case of unitialized status, use of bad ret value and
help modularize the get next index function.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: steal channel key in the consumer to avoid race
David Goulet [Wed, 12 Feb 2014 20:17:57 +0000 (15:17 -0500)] 
Fix: steal channel key in the consumer to avoid race

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: change ERR statement to DBG in kernel read subbuffer
David Goulet [Thu, 13 Feb 2014 15:55:47 +0000 (10:55 -0500)] 
Fix: change ERR statement to DBG in kernel read subbuffer

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: handle snapshot ENODATA in live timer
David Goulet [Thu, 13 Feb 2014 15:42:58 +0000 (10:42 -0500)] 
Fix: handle snapshot ENODATA in live timer

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: relayd leak on error in consumer splice()
David Goulet [Wed, 12 Feb 2014 16:19:43 +0000 (11:19 -0500)] 
Fix: relayd leak on error in consumer splice()

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: protect close_write_flag with the rotation lock
David Goulet [Tue, 11 Feb 2014 21:27:57 +0000 (16:27 -0500)] 
Fix: protect close_write_flag with the rotation lock

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoMan: clarify loglevel for JUL domain
David Goulet [Wed, 12 Feb 2014 19:46:08 +0000 (14:46 -0500)] 
Man: clarify loglevel for JUL domain

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: Define __STDC_LIMIT_MACROS to fix C++ builds
Jérémie Galarneau [Mon, 10 Feb 2014 16:04:22 +0000 (11:04 -0500)] 
Fix: Define __STDC_LIMIT_MACROS to fix C++ builds

Necessary to include the fixed-width type limits on glibc versions
older than 2.18 when building with a C++ compiler.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: wrong data structure used in commit df41f83
David Goulet [Tue, 11 Feb 2014 21:36:30 +0000 (16:36 -0500)] 
Fix: wrong data structure used in commit df41f83

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: add missing optional dependency to babeltrace in README
Christian Babeux [Fri, 7 Feb 2014 17:43:38 +0000 (12:43 -0500)] 
Fix: add missing optional dependency to babeltrace in README

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: cleanup inconsistent use of spaces/tabs in README
Christian Babeux [Fri, 7 Feb 2014 17:48:51 +0000 (12:48 -0500)] 
Fix: cleanup inconsistent use of spaces/tabs in README

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: only set the new_streams flag if a viewer is attached
Julien Desfossez [Mon, 10 Feb 2014 23:52:29 +0000 (18:52 -0500)] 
Fix: only set the new_streams flag if a viewer is attached

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: lttng-live documentation
Julien Desfossez [Mon, 10 Feb 2014 23:52:28 +0000 (18:52 -0500)] 
Fix: lttng-live documentation

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: remove dead code in relayd live code
David Goulet [Tue, 11 Feb 2014 21:08:43 +0000 (16:08 -0500)] 
Fix: remove dead code in relayd live code

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: use after free error code path
David Goulet [Tue, 11 Feb 2014 21:04:15 +0000 (16:04 -0500)] 
Fix: use after free error code path

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: wrong sizeof argument in live viewer create session
David Goulet [Tue, 11 Feb 2014 20:58:52 +0000 (15:58 -0500)] 
Fix: wrong sizeof argument in live viewer create session

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: zero out the reply structure in viewer_connect
David Goulet [Tue, 11 Feb 2014 20:16:34 +0000 (15:16 -0500)] 
Fix: zero out the reply structure in viewer_connect

Fixes #728

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: write index only if fd is valid
David Goulet [Tue, 11 Feb 2014 19:13:01 +0000 (14:13 -0500)] 
Fix: write index only if fd is valid

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: cleanup relayd on any I/O error in read subbuffer mmap
David Goulet [Tue, 11 Feb 2014 18:21:59 +0000 (13:21 -0500)] 
Fix: cleanup relayd on any I/O error in read subbuffer mmap

Any I/O operation that triggers an error now cleans the relayd since
there is no way we can recover from that in any cases and streams
associated to that relayd need to be cleaned up.

This commit also removes the "written" variable that is simply not
needed and was a bit confusing as a returned value.

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: memory/fd leak when cleaning streams in channel
David Goulet [Tue, 11 Feb 2014 18:16:45 +0000 (13:16 -0500)] 
Fix: memory/fd leak when cleaning streams in channel

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: destroy streams in consumer del channel
David Goulet [Mon, 10 Feb 2014 22:23:20 +0000 (17:23 -0500)] 
Fix: destroy streams in consumer del channel

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: add missing urcu wfqueue headers in relayd
David Goulet [Mon, 10 Feb 2014 22:21:14 +0000 (17:21 -0500)] 
Fix: add missing urcu wfqueue headers in relayd

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: in lttng_read/write deny count bigger than the possible returned value
David Goulet [Mon, 10 Feb 2014 18:43:08 +0000 (13:43 -0500)] 
Fix: in lttng_read/write deny count bigger than the possible returned value

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: fd leak when closing metadata stream
David Goulet [Thu, 6 Feb 2014 21:49:37 +0000 (16:49 -0500)] 
Fix: fd leak when closing metadata stream

Make sure to close the metadata poll pipe when the endpoint of the
stream dies out (ex: relayd stops unexpectedly). That was causing a fd
leak when we were destroying a metadata stream without using the close
metadata code path.

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: read subbuffer mmap/splice signedness issue
David Goulet [Thu, 6 Feb 2014 19:16:06 +0000 (14:16 -0500)] 
Fix: read subbuffer mmap/splice signedness issue

Signed and unsigned values were compared thus making the code path where
ret = -1 being interpreted as ret > len == true thus not cleaning up the
relayd.

This patch simplifies the read subbuffer mmap operation since
lttng_write() now provides a guarantee that the return data is either
equal to the count passed or less which the later means the endpoint has
stop working.

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoDoc: live protocol clarifications
Julien Desfossez [Thu, 6 Feb 2014 15:50:56 +0000 (10:50 -0500)] 
Doc: live protocol clarifications

Updates about the get_new_stream, the attach procedure, the create
viewer_session and the multiple attach.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: remove unused create_viewer_session option
Julien Desfossez [Thu, 6 Feb 2014 15:21:21 +0000 (10:21 -0500)] 
Fix: remove unused create_viewer_session option

Since it is unused for now, don't bloat the ABI with that.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: don't sleep(1) on the consumer ready flag
David Goulet [Wed, 5 Feb 2014 22:40:59 +0000 (17:40 -0500)] 
Fix: don't sleep(1) on the consumer ready flag

This is way too long on especially when the first command that spawn the
consumer as to wait a full second on powerful system.

Bring this down to 0.1 sec sleep by using usleep().

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: free viewer session in connection_free()
David Goulet [Wed, 5 Feb 2014 21:37:46 +0000 (16:37 -0500)] 
Fix: free viewer session in connection_free()

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: add missing ctf trace delete before destroy
David Goulet [Wed, 5 Feb 2014 21:26:43 +0000 (16:26 -0500)] 
Fix: add missing ctf trace delete before destroy

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: don't delete ctf trace while in snapshot mode
David Goulet [Wed, 5 Feb 2014 21:03:35 +0000 (16:03 -0500)] 
Fix: don't delete ctf trace while in snapshot mode

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: add flag to create session command and fix tests
Julien Desfossez [Wed, 5 Feb 2014 19:55:11 +0000 (14:55 -0500)] 
Fix: add flag to create session command and fix tests

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: cleanup indef guards following the rename
Julien Desfossez [Wed, 5 Feb 2014 19:55:10 +0000 (14:55 -0500)] 
Fix: cleanup indef guards following the rename

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: merge issue with thread quit pipe
David Goulet [Wed, 5 Feb 2014 17:18:04 +0000 (12:18 -0500)] 
Fix: merge issue with thread quit pipe

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: use uint32_t for metadata_flag in viewer's ABI
Marc-Andre Laperle [Tue, 4 Feb 2014 19:40:50 +0000 (14:40 -0500)] 
Fix: use uint32_t for metadata_flag in viewer's ABI

This struct is meant to be sent over the network so members should be
of exact-width.

Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: check for new streams in all attached sessions
Julien Desfossez [Tue, 4 Feb 2014 02:08:07 +0000 (21:08 -0500)] 
Fix: check for new streams in all attached sessions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: Move static functions up in the code
Julien Desfossez [Fri, 31 Jan 2014 20:17:06 +0000 (15:17 -0500)] 
Fix: Move static functions up in the code

When we detect that the viewer is trying to get new streams for a
session closed and for which it already got all the streams, we can
delete and destroy the session, we know it won't be useful anymore.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: allow attach command to multiple sessions
Julien Desfossez [Thu, 30 Jan 2014 23:36:28 +0000 (18:36 -0500)] 
Fix: allow attach command to multiple sessions

The attach session command can now attach to multiple session using an
ID list.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: handle session hang up in get_new_streams
Julien Desfossez [Thu, 30 Jan 2014 22:08:31 +0000 (17:08 -0500)] 
Fix: handle session hang up in get_new_streams

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: force the client to create a viewer session before attaching
Julien Desfossez [Thu, 30 Jan 2014 20:44:20 +0000 (15:44 -0500)] 
Fix: force the client to create a viewer session before attaching

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: Namespace lttng-viewer-abi
Julien Desfossez [Thu, 30 Jan 2014 16:11:44 +0000 (11:11 -0500)] 
Fix: Namespace lttng-viewer-abi

This header is copied to all the viewers that implement the lttng-live
protocol, we need to make sure it is properly namespaced.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: relayd connection object refactor
David Goulet [Thu, 23 Jan 2014 19:57:05 +0000 (14:57 -0500)] 
Fix: relayd connection object refactor

Mostly rename and move the connection data structure to its own C
file/header along with functions handling the object.

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: big relayd cleanup and refactor
David Goulet [Wed, 22 Jan 2014 17:32:56 +0000 (12:32 -0500)] 
Fix: big relayd cleanup and refactor

Due to a number of race conditions between the live feature and the data
threads, we had to refactor the relayd which mostly splits the different
objects in their own files creating APIs for each of them.

That done, we are able to remove duplicate code, centralize code path
to help with cleanup and having a flow that makes more sense when
handling multiple objects.

This commits adds a lot of fixes with the live feature and cleanup code
path of a session since some objects are shared between threads like
ctf-trace and stream.

So yeah, this is quite a BIG commit and unfortunately this work was
essential in order to fix a lof of issues and have a way more
maintainable code base for the relayd.

Signed-off-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: code refactoring of viewer streams in relayd
David Goulet [Mon, 20 Jan 2014 17:24:26 +0000 (12:24 -0500)] 
Fix: code refactoring of viewer streams in relayd

This also renames the lttng-viewer.h to lttng-viewer-abi.h which
represents the live reading ABI.

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: handle new streams in live mode in relayd
Julien Desfossez [Wed, 15 Jan 2014 15:32:44 +0000 (10:32 -0500)] 
Fix: handle new streams in live mode in relayd

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: notify the viewer if new streams got added
Julien Desfossez [Wed, 15 Jan 2014 16:54:38 +0000 (11:54 -0500)] 
Fix: notify the viewer if new streams got added

As soon as new streams are available, the viewer must start reading
them, otherwise we risk to ignore complete streams.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: send the streams sent message after metadata
Julien Desfossez [Wed, 15 Jan 2014 16:29:36 +0000 (11:29 -0500)] 
Fix: send the streams sent message after metadata

We now make sure that we only sent the streams_sent message to the relay
when all the streams (including the metadata) are sent.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoAdd extern C to the health-check header
Jérémie Galarneau [Thu, 6 Feb 2014 19:13:56 +0000 (14:13 -0500)] 
Add extern C to the health-check header

This makes it possible to include health.h in a C++ program.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: memory leak in unit test
David Goulet [Wed, 5 Feb 2014 16:48:48 +0000 (11:48 -0500)] 
Fix: memory leak in unit test

Fixes coverity issue #1128896

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoMan: add JUL DOMAIN section to lttng.1
David Goulet [Wed, 5 Feb 2014 16:44:16 +0000 (11:44 -0500)] 
Man: add JUL DOMAIN section to lttng.1

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: bad indentation of lttng list in man page
David Goulet [Tue, 4 Feb 2014 20:32:52 +0000 (15:32 -0500)] 
Fix: bad indentation of lttng list in man page

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: handle invalid URL passed to lttng_create_session_live
David Goulet [Tue, 4 Feb 2014 19:52:49 +0000 (14:52 -0500)] 
Fix: handle invalid URL passed to lttng_create_session_live

uri_parse_str_urls() returns 0 if the URL passed is NULL thus using
lttng_create_session_live() without an URL is invalid.

Reported-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: add --jul-tcp-port to sessiond man page
David Goulet [Tue, 4 Feb 2014 19:51:50 +0000 (14:51 -0500)] 
Fix: add --jul-tcp-port to sessiond man page

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: measure UST clock offset with best sample (v2)
Mathieu Desnoyers [Thu, 30 Jan 2014 22:06:30 +0000 (17:06 -0500)] 
Fix: measure UST clock offset with best sample (v2)

Fixes #729

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: remove free in unit test not needed anymore
Zifei Tong [Tue, 4 Feb 2014 18:55:11 +0000 (13:55 -0500)] 
Fix: remove free in unit test not needed anymore

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: relay create session for version before 2.4
Julien Desfossez [Mon, 27 Jan 2014 20:27:51 +0000 (15:27 -0500)] 
Fix: relay create session for version before 2.4

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: memory leak when UST events are enabled with exclusions
Jérémie Galarneau [Mon, 20 Jan 2014 17:51:12 +0000 (12:51 -0500)] 
Fix: memory leak when UST events are enabled with exclusions

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agohealth check tests: test relayd and consumerd
Mathieu Desnoyers [Mon, 27 Jan 2014 04:53:21 +0000 (23:53 -0500)] 
health check tests: test relayd and consumerd

- Cover relayd and consumerd,
- Add a test_thread_ok test (no issue found by test) to fast_regression,
- Merge duplicated code into test_health.sh.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agotests: Add stop_lttng_relayd_nocheck
Mathieu Desnoyers [Wed, 29 Jan 2014 15:47:37 +0000 (10:47 -0500)] 
tests: Add stop_lttng_relayd_nocheck

Used in cases where the relay daemon might not be running.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: add missing JUL loglevel handling
David Goulet [Fri, 24 Jan 2014 17:36:44 +0000 (12:36 -0500)] 
Fix: add missing JUL loglevel handling

JUL loglevels are directly mapped to the Level class from the JUL
interface. A complete listing has been added to the enable-event help
command and to the lttng.h ABI as lttng_loglevel_jul.

Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agorelayd: add testpoints
Mathieu Desnoyers [Mon, 27 Jan 2014 04:51:55 +0000 (23:51 -0500)] 
relayd: add testpoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agorelayd: use same pipe for live and main
Mathieu Desnoyers [Mon, 27 Jan 2014 04:34:17 +0000 (23:34 -0500)] 
relayd: use same pipe for live and main

Don't use a duplicate of file descriptors. Ownership is easier to track
without a copy.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoCleanup relayd live comment
Mathieu Desnoyers [Mon, 27 Jan 2014 04:28:06 +0000 (23:28 -0500)] 
Cleanup relayd live comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: relayd: add LPOLLERR to events
Mathieu Desnoyers [Mon, 27 Jan 2014 04:26:53 +0000 (23:26 -0500)] 
Fix: relayd: add LPOLLERR to events

Same as session daemon.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: relayd: notify parent of readiness when all threads ready
Mathieu Desnoyers [Mon, 27 Jan 2014 04:23:36 +0000 (23:23 -0500)] 
Fix: relayd: notify parent of readiness when all threads ready

- relayd start using daemonize common lib,
- wait for health check thread, listener and live listener threads to be
  ready before letting the parent know it is ready (in daemon and
  background modes).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoFix: tests: start relayd in background mode (-b)
Mathieu Desnoyers [Mon, 27 Jan 2014 03:16:47 +0000 (22:16 -0500)] 
Fix: tests: start relayd in background mode (-b)

Ensure that relayd health check is ready to receive queries by starting
relayd in background mode with '-b' rather than putting it in background
by the shell (&).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agolttng-relayd: implement background cmd line option
Mathieu Desnoyers [Mon, 27 Jan 2014 04:09:41 +0000 (23:09 -0500)] 
lttng-relayd: implement background cmd line option

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agosessiond: add missing testpoints
Mathieu Desnoyers [Mon, 27 Jan 2014 04:01:06 +0000 (23:01 -0500)] 
sessiond: add missing testpoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agotests: use --background for session daemon
Mathieu Desnoyers [Mon, 27 Jan 2014 03:32:35 +0000 (22:32 -0500)] 
tests: use --background for session daemon

Will now show errors when they happen.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agosessiond: add --background argument
Mathieu Desnoyers [Mon, 27 Jan 2014 03:59:31 +0000 (22:59 -0500)] 
sessiond: add --background argument

Allow starting sessiond like --daemonize, but keeps console open.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoUse lib common daemonize
Mathieu Desnoyers [Mon, 27 Jan 2014 03:55:43 +0000 (22:55 -0500)] 
Use lib common daemonize

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: sessiond: wait for health check readiness
Mathieu Desnoyers [Mon, 27 Jan 2014 03:54:15 +0000 (22:54 -0500)] 
Fix: sessiond: wait for health check readiness

Wait for health check readiness before notifying the parent.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: relayd: initialize lttcomm inet
Mathieu Desnoyers [Mon, 27 Jan 2014 03:45:10 +0000 (22:45 -0500)] 
Fix: relayd: initialize lttcomm inet

Not doing so does not take into account env. var. timeouts.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoConsumer: add testpoints
Mathieu Desnoyers [Mon, 27 Jan 2014 03:43:13 +0000 (22:43 -0500)] 
Consumer: add testpoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: consumerd: HT init/teardown with program
Mathieu Desnoyers [Mon, 27 Jan 2014 03:39:44 +0000 (22:39 -0500)] 
Fix: consumerd: HT init/teardown with program

Hash tables shared between threads should not be initialized by a
specific thread, because the other threads could start using it before
it is initialized.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agoCleanup: lttng-ctl-health comment
Mathieu Desnoyers [Mon, 27 Jan 2014 03:31:40 +0000 (22:31 -0500)] 
Cleanup: lttng-ctl-health comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoAdd daemonize() to libcommon
Mathieu Desnoyers [Mon, 27 Jan 2014 03:23:09 +0000 (22:23 -0500)] 
Add daemonize() to libcommon

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: tests: wait for consumerd to complete
Mathieu Desnoyers [Mon, 27 Jan 2014 03:15:56 +0000 (22:15 -0500)] 
Fix: tests: wait for consumerd to complete

Wait for consumerd to complete when stopping sessiond.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: consumerd: use DBG rather than DBG2
Mathieu Desnoyers [Mon, 27 Jan 2014 03:11:55 +0000 (22:11 -0500)] 
Fix: consumerd: use DBG rather than DBG2

DBG2 is never visible.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: consumerd: only return readiness when health is ready
Mathieu Desnoyers [Mon, 27 Jan 2014 03:10:34 +0000 (22:10 -0500)] 
Fix: consumerd: only return readiness when health is ready

Wait for health check to be ready before returning readiness to session
daemon.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: consumerd should initialize lttcomm
Mathieu Desnoyers [Mon, 27 Jan 2014 03:08:27 +0000 (22:08 -0500)] 
Fix: consumerd should initialize lttcomm

Missing initialization makes the consumer daemon not care about the
env. var. specifying the timeouts.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix health check: signal parent before exit testpoint
Mathieu Desnoyers [Thu, 23 Jan 2014 03:14:59 +0000 (22:14 -0500)] 
Fix health check: signal parent before exit testpoint

We need to signal parent for readiness before hitting the thread exit
testpoint, otherwise we hang the test.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoTest health: add test_thread_ok
Mathieu Desnoyers [Wed, 22 Jan 2014 20:24:33 +0000 (15:24 -0500)] 
Test health: add test_thread_ok

Tests sessiond, consumerd (UST+kernel) and relayd health "ok" case in
simple scenarios.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
7 years agohealth check: change --relayd-path arg to --relayd-path=arg
Mathieu Desnoyers [Wed, 22 Jan 2014 19:48:28 +0000 (14:48 -0500)] 
health check: change --relayd-path arg to --relayd-path=arg

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agorelayd: add LTTNG_RELAYD_HEALTH env var
Mathieu Desnoyers [Wed, 22 Jan 2014 19:48:07 +0000 (14:48 -0500)] 
relayd: add LTTNG_RELAYD_HEALTH env var

Allow override of path leading to health check named pipe.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoAdd sessiond/SESSIOND_ prefix to sessiond testpoints
Mathieu Desnoyers [Wed, 13 Nov 2013 21:40:53 +0000 (16:40 -0500)] 
Add sessiond/SESSIOND_ prefix to sessiond testpoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: zero out data structure before using it
David Goulet [Wed, 15 Jan 2014 20:30:47 +0000 (15:30 -0500)] 
Fix: zero out data structure before using it

Fixes #716

Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.076739 seconds and 4 git commands to generate.