lttng-tools.git
6 years agoTests: Java agent: update after Java agent refactoring
Michael Jeanson [Tue, 4 Aug 2015 22:21:40 +0000 (18:21 -0400)] 
Tests: Java agent: update after Java agent refactoring

This patch fixes the Java agent tests which were impossible to run since
the Jar files have been renamed. It also overhauls the java part of the
configure script to match what's in UST and replace some hardcoded path
with configurable values.

The tests are now enabled when corresponding classes are found in the
CLASSPATH during configure.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSet registration done Agent command version back to 0
Jérémie Galarneau [Mon, 3 Aug 2015 20:48:16 +0000 (16:48 -0400)] 
Set registration done Agent command version back to 0

The command version was used to indicate a workaround introducing a
change of behavior in a minor version. 2.6 was the only version affected
by this bug.

Fixes #884

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Don't send agent disable event command twice
Jérémie Galarneau [Mon, 3 Aug 2015 20:45:00 +0000 (16:45 -0400)] 
Fix: Don't send agent disable event command twice

The session daemon sends a "disable event" command to agents for each
event, enabled or not, on session destroy. This had no adverse effect
of the Java agent since it suffered from an unrelated bug which ignored
any refcount decrementation.

This fix bumps the command version to "1" to indicate that this behavior
is fixed on the session daemon's end.

Fixes #884

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: Python agent: update after Python agent refactoring
Philippe Proulx [Wed, 1 Apr 2015 00:10:07 +0000 (20:10 -0400)] 
Tests: Python agent: update after Python agent refactoring

This patch makes the tests follow the recent refactoring
of the LTTng-UST Python agent.

You need both python2 and python3 in your $PATH to run this
test now (since the agent is compatible with both versions
of Python).

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Remove redundant variable initialization
Jérémie Galarneau [Mon, 3 Aug 2015 16:18:10 +0000 (12:18 -0400)] 
Clean-up: Remove redundant variable initialization

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: incorrect variable being checked in libc-wrapper test
Antoine Busque [Sat, 1 Aug 2015 19:20:50 +0000 (15:20 -0400)] 
Fix: incorrect variable being checked in libc-wrapper test

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRename Python agent event name to omit "user"
Jérémie Galarneau [Thu, 30 Jul 2015 20:51:03 +0000 (16:51 -0400)] 
Rename Python agent event name to omit "user"

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoConsolidate agent event names regardless of user privilege
Jérémie Galarneau [Thu, 30 Jul 2015 20:49:49 +0000 (16:49 -0400)] 
Consolidate agent event names regardless of user privilege

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Move agent_apps_ht_by_sock definition to main.c
Jérémie Galarneau [Thu, 30 Jul 2015 16:48:52 +0000 (12:48 -0400)] 
Clean-up: Move agent_apps_ht_by_sock definition to main.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Initialize global agent_apps_ht_by_sock on session daemon launch
Jérémie Galarneau [Thu, 30 Jul 2015 16:46:56 +0000 (12:46 -0400)] 
Fix: Initialize global agent_apps_ht_by_sock on session daemon launch

Reported-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: set session should not set non-existent session
Partha Pratim Mukherjee [Sat, 25 Jul 2015 07:55:19 +0000 (13:25 +0530)] 
Fix: set session should not set non-existent session

set-session does not check the existence of a session before setting
it as the current session. Fix it so that it gives error for a
non-existent session.

Fixes #885

Signed-off-by: Partha Pratim Mukherjee <ppm.floss@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: pids should be numbers only
Jonathan Rajotte [Fri, 24 Jul 2015 21:42:59 +0000 (17:42 -0400)] 
Fix: pids should be numbers only

Ruled out cases: word, number+word, word+number, number+word+number
Ex: foo, 123foo, foo123, 123foo123

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Mishandled NULL short options in lttng-sessiond
Jérémie Galarneau [Sun, 26 Jul 2015 20:16:23 +0000 (16:16 -0400)] 
Fix: Mishandled NULL short options in lttng-sessiond

set_option() ignores any option which has no short option
defined.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUse popt "required_argument" and "no_argument" constants
Jérémie Galarneau [Sun, 26 Jul 2015 20:13:18 +0000 (16:13 -0400)] 
Use popt "required_argument" and "no_argument" constants

Use popt's provided constants for the "has_arg" field of long
options instead of hardcoding 0 and 1 everywhere.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Mishandled NULL short options in utils_generate_optstring()
Jérémie Galarneau [Sun, 26 Jul 2015 18:54:24 +0000 (14:54 -0400)] 
Fix: Mishandled NULL short options in utils_generate_optstring()

The NULL character is used to indicate that no short option is
available for a given command.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: only launch a new session daemon for the "create" command
Jérémie Galarneau [Sun, 26 Jul 2015 00:09:23 +0000 (20:09 -0400)] 
Fix: only launch a new session daemon for the "create" command

Fixes #859

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix 'daemon' typo in lttng-ctl-pc.in description
Jérémie Galarneau [Sat, 25 Jul 2015 23:50:22 +0000 (19:50 -0400)] 
Fix 'daemon' typo in lttng-ctl-pc.in description

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: clean-up agent app hash table from the main sessiond thread
Jérémie Galarneau [Sat, 25 Jul 2015 21:48:12 +0000 (17:48 -0400)] 
Fix: clean-up agent app hash table from the main sessiond thread

The agent application hash table, which is allocated by the session
daemon's main thread, is free'd from the agent application registration
thread.

This leads to a number of interesting scenarios under which the agent
app registration thread may encounter an error, thus tearing itself down
and freeing the agent_apps_ht_by_sock hash table. Of course, nothing then
prevents the client processing thread from accessing this invalidated hash
table to list, enable or disable agent events which leads to crashes or
assertions hitting in ht_match_reg_uid().

However, it is not necessary for the agent app registration thread to
encounter an error for this to prove problematic. As shown in bug #893,
the session daemon's teardown will assert on a NULL key in
ht_match_reg_uid() whenever it is performed while a JUL, Log4J or Python
event is still enabled in a session. This happens because the session
daemon's clean-up triggers the destruction of all sessions. The destruction
of those sessions would access the free'd agent_apps_ht_by_sock to disable
the registered agent events.

Fixes #893

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Remove undocumented session daemon short options
Jérémie Galarneau [Sat, 25 Jul 2015 21:38:29 +0000 (17:38 -0400)] 
Fix: Remove undocumented session daemon short options

Fixes #864

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoComment grammar correction
Jérémie Galarneau [Sat, 25 Jul 2015 20:31:43 +0000 (16:31 -0400)] 
Comment grammar correction

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoLog userspace application hash table allocation failure
Jérémie Galarneau [Sat, 25 Jul 2015 20:28:50 +0000 (16:28 -0400)] 
Log userspace application hash table allocation failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: RCU read-side lock released too early in destroy_agent_app
Jérémie Galarneau [Sat, 25 Jul 2015 20:24:05 +0000 (16:24 -0400)] 
Fix: RCU read-side lock released too early in destroy_agent_app

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: misleading logging statement in agent_find_event
Jérémie Galarneau [Sat, 25 Jul 2015 19:54:19 +0000 (15:54 -0400)] 
Fix: misleading logging statement in agent_find_event

An _event_ is not found, not an agent.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Unhandled domain option condition in list_agent_events
Jérémie Galarneau [Fri, 24 Jul 2015 22:01:02 +0000 (18:01 -0400)] 
Fix: Unhandled domain option condition in list_agent_events

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Crash on lttng list -j/-l/-p when no events are present
Jérémie Galarneau [Fri, 24 Jul 2015 21:54:47 +0000 (17:54 -0400)] 
Fix: Crash on lttng list -j/-l/-p when no events are present

The lttng client will free an uninitialized pointer whenever a the
lttng list command is invoked on a domain which involves the log4j,
JUL or Python agents.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: spelling fix in a comment
Jérémie Galarneau [Thu, 16 Jul 2015 17:16:20 +0000 (13:16 -0400)] 
Clean-up: spelling fix in a comment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocument relay_add_stream RCU locking
Jérémie Galarneau [Thu, 16 Jul 2015 17:13:09 +0000 (13:13 -0400)] 
Document relay_add_stream RCU locking

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Unbalanced rcu_read_unlock() on stream file creation failure
Jérémie Galarneau [Thu, 16 Jul 2015 17:04:05 +0000 (13:04 -0400)] 
Fix: Unbalanced rcu_read_unlock() on stream file creation failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Unbalanced rcu_read_unlock() on directory creation failure
Jérémie Galarneau [Thu, 16 Jul 2015 17:02:47 +0000 (13:02 -0400)] 
Fix: Unbalanced rcu_read_unlock() on directory creation failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Document the locking assumptions of ctf_trace_find_by_path()
Jérémie Galarneau [Thu, 16 Jul 2015 17:00:56 +0000 (13:00 -0400)] 
Fix: Document the locking assumptions of ctf_trace_find_by_path()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Memory leak in relay_add_stream error path
Jérémie Galarneau [Thu, 16 Jul 2015 16:58:44 +0000 (12:58 -0400)] 
Fix: Memory leak in relay_add_stream error path

Failing to allocate a struct ctf_trace results in the leak of a stream's
path and channel name.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUpdate master version to v2.8.0-pre
Jérémie Galarneau [Wed, 15 Jul 2015 22:40:38 +0000 (18:40 -0400)] 
Update master version to v2.8.0-pre

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUpdate version to v2.7.0-rc1 v2.7.0-rc1
Jérémie Galarneau [Wed, 15 Jul 2015 19:27:28 +0000 (15:27 -0400)] 
Update version to v2.7.0-rc1

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: lttng-ust-getcpu-override-test cache and error-check sysconf()
Jérémie Galarneau [Wed, 15 Jul 2015 19:15:49 +0000 (15:15 -0400)] 
Tests: lttng-ust-getcpu-override-test cache and error-check sysconf()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: lttng-ust-getcpu-override coding-style adjustments
Jérémie Galarneau [Wed, 15 Jul 2015 19:14:50 +0000 (15:14 -0400)] 
Tests: lttng-ust-getcpu-override coding-style adjustments

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoAdd CPU_ID LTTng-UST context to enum lttng_ust_context_type
Jérémie Galarneau [Wed, 15 Jul 2015 18:25:16 +0000 (14:25 -0400)] 
Add CPU_ID LTTng-UST context to enum lttng_ust_context_type

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoBump LTTNG_UST_ABI_MAJOR_VERSION to 6
Jérémie Galarneau [Wed, 15 Jul 2015 18:24:50 +0000 (14:24 -0400)] 
Bump LTTNG_UST_ABI_MAJOR_VERSION to 6

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: Ust getcpu override plugin
Jonathan Rajotte [Tue, 14 Jul 2015 21:52:51 +0000 (17:52 -0400)] 
Tests: Ust getcpu override plugin

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Follow struct dirent allocation guidelines of READDIR(3)
Jérémie Galarneau [Tue, 14 Jul 2015 15:33:41 +0000 (11:33 -0400)] 
Fix: Follow struct dirent allocation guidelines of READDIR(3)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUpdate comments regarding the power of 2 constraint on sub-buffer sizes
Jonathan Rajotte [Fri, 10 Jul 2015 21:50:02 +0000 (17:50 -0400)] 
Update comments regarding the power of 2 constraint on sub-buffer sizes

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoBuild: add Flex version check
Jonathan Rajotte [Fri, 10 Jul 2015 21:03:18 +0000 (17:03 -0400)] 
Build: add Flex version check

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoBuild: add Bison version check
Jonathan Rajotte [Fri, 10 Jul 2015 21:03:17 +0000 (17:03 -0400)] 
Build: add Bison version check

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: handle sys_futex() FUTEX_WAIT interrupted by signal
Mathieu Desnoyers [Mon, 6 Jul 2015 21:28:34 +0000 (17:28 -0400)] 
Fix: handle sys_futex() FUTEX_WAIT interrupted by signal

We need to handle EINTR returned by sys_futex() FUTEX_WAIT, otherwise a
signal interrupting this system call could make sys_futex return too
early, and therefore cause a synchronization issue.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: metadata push -EPIPE should be recoverable
Mathieu Desnoyers [Mon, 6 Jul 2015 16:21:06 +0000 (12:21 -0400)] 
Fix: metadata push -EPIPE should be recoverable

This return value can be caused by application terminating concurrently
(when using per-PID buffers), so it should not make the consumer
management thread exit.

CC: Aravind HT <aravind.ht@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: destroy session removes the default config file
Partha Pratim Mukherjee [Sun, 5 Jul 2015 19:31:15 +0000 (15:31 -0400)] 
Fix: destroy session removes the default config file

Destroy session command by default removes the default config file
without checking the current session. As a result when we call any
other command which expects a default session by calling
get_session_name() function, it fails.

This patch will fix this by checking that the default config file gets
removed only when destroy session is called with the current session.

Fixes: #887

Signed-off-by: Partha Pratim Mukherjee <ppm.floss@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoBuild: bump autoconf version requirement to 2.64
Jonathan Rajotte [Thu, 2 Jul 2015 22:55:32 +0000 (18:55 -0400)] 
Build: bump autoconf version requirement to 2.64

AC_INIT with package_url was introduced in AC 2.64

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Memory leak in setup of relayd_path
Jérémie Galarneau [Thu, 2 Jul 2015 22:55:17 +0000 (18:55 -0400)] 
Fix: Memory leak in setup of relayd_path

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: update liburcu URL
Jérémie Galarneau [Thu, 2 Jul 2015 22:25:28 +0000 (18:25 -0400)] 
Fix: update liburcu URL

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: test: use "$@" to pass and quote argument
Jonathan Rajotte [Sun, 26 Apr 2015 21:14:16 +0000 (17:14 -0400)] 
Fix: test: use "$@" to pass and quote argument

${*} expands wildcard and does not preserve initial arguments.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for lttng_snapshot_del_output
Jonathan Rajotte [Fri, 24 Apr 2015 20:50:39 +0000 (16:50 -0400)] 
Refactor: test: wrapper for lttng_snapshot_del_output

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for lttng_snapshot_add_output
Jonathan Rajotte [Fri, 24 Apr 2015 20:45:08 +0000 (16:45 -0400)] 
Refactor: test: wrapper for lttng_snapshot_add_output

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for destroy_lttng_session
Jonathan Rajotte [Fri, 24 Apr 2015 20:29:40 +0000 (16:29 -0400)] 
Refactor: test: wrapper for destroy_lttng_session

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for stop_lttng_tracing
Jonathan Rajotte [Fri, 24 Apr 2015 20:10:08 +0000 (16:10 -0400)] 
Refactor: test: wrapper for stop_lttng_tracing

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for start_lttng_tracing
Jonathan Rajotte [Fri, 24 Apr 2015 19:53:10 +0000 (15:53 -0400)] 
Refactor: test: wrapper for start_lttng_tracing

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for enable_ust_lttng_event
Jonathan Rajotte [Fri, 24 Apr 2015 17:50:04 +0000 (13:50 -0400)] 
Refactor: test: wrapper for enable_ust_lttng_event

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for enable_ust_lttng_channel
Jonathan Rajotte [Thu, 23 Apr 2015 21:22:36 +0000 (17:22 -0400)] 
Refactor: test: wrapper for enable_ust_lttng_channel

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoRefactor: test: wrapper for create_lttng_session
Jonathan Rajotte [Thu, 23 Apr 2015 20:32:19 +0000 (16:32 -0400)] 
Refactor: test: wrapper for create_lttng_session

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Memory allocated by xmlNodeGetContent() must be freed by xmlFree()
Jérémie Galarneau [Thu, 25 Jun 2015 16:42:48 +0000 (12:42 -0400)] 
Fix: Memory allocated by xmlNodeGetContent() must be freed by xmlFree()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSave/load: add support for shared memory path
Jonathan Rajotte [Fri, 17 Apr 2015 21:26:41 +0000 (17:26 -0400)] 
Save/load: add support for shared memory path

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: get_cmdline_by_pid path length assumes a max pid of 65535
Jérémie Galarneau [Tue, 23 Jun 2015 21:27:31 +0000 (23:27 +0200)] 
Fix: get_cmdline_by_pid path length assumes a max pid of 65535

PROC(5) mentions that "On 64-bit systems, pid_max can be set to any
value up to 2^22 (PID_MAX_LIMIT, approximately 4 million)."

We use 32 bits for simplicity's sake.

Reported-by: Zhenyu Ren <zhenyu.ren@aliyun.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Remove ifdef-ed out lttng list options
Jérémie Galarneau [Tue, 23 Jun 2015 20:30:59 +0000 (22:30 +0200)] 
Clean-up: Remove ifdef-ed out lttng list options

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTest: mi: test for greater or equal to a minimum of events on ust listing.
Jonathan Rajotte [Wed, 10 Jun 2015 15:27:41 +0000 (11:27 -0400)] 
Test: mi: test for greater or equal to a minimum of events on ust listing.

Since the number of events present in the tests apps in prone to change it
make more sense to look for a minimum of events. This is less rigourous
but more flexible to change.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: update regression tests involving UST
Antoine Busque [Wed, 27 May 2015 19:09:18 +0000 (15:09 -0400)] 
Fix: update regression tests involving UST

This patch fixes previously failing regression tests which involve
either the UST statedump or helper events, following a refactor and
rename.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up: Remove ifdef-ed out function:entry feature
Jérémie Galarneau [Fri, 22 May 2015 16:55:57 +0000 (12:55 -0400)] 
Clean-up: Remove ifdef-ed out function:entry feature

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Mark MI and Config string declarations as extern
Jérémie Galarneau [Fri, 22 May 2015 16:53:30 +0000 (12:53 -0400)] 
Fix: Mark MI and Config string declarations as extern

This fixes a build issue with GCC 5.1 which would complain about
these symbols being defined multiple times.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoClean-up append_list_to_probes()
Jérémie Galarneau [Wed, 6 May 2015 15:51:50 +0000 (11:51 -0400)] 
Clean-up append_list_to_probes()

Remove unecessary "index" variable and cur_mod increment which was
probably meant to increment "index", a bug fixed by 9ae17e2.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: modprobe.c: fix tmp_list memory leak
Philippe Proulx [Tue, 28 Apr 2015 21:09:16 +0000 (17:09 -0400)] 
Fix: modprobe.c: fix tmp_list memory leak

Reported-by: Hannes Weisbach <hannes.weisbach@mailbox.tu-dresden.de>
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: append_list_to_probes(): increment index
Philippe Proulx [Tue, 28 Apr 2015 21:08:58 +0000 (17:08 -0400)] 
Fix: append_list_to_probes(): increment index

Reported-by: Hannes Weisbach <hannes.weisbach@mailbox.tu-dresden.de>
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocs: LTTNG(1) filtering is now supported by the kernel tracer
Jérémie Galarneau [Wed, 29 Apr 2015 20:19:38 +0000 (16:19 -0400)] 
Docs: LTTNG(1) filtering is now supported by the kernel tracer

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: live_test regression on large number of cpus
Mathieu Desnoyers [Tue, 28 Apr 2015 21:23:34 +0000 (17:23 -0400)] 
Fix: live_test regression on large number of cpus

Merge fixes from Babeltrace lttng-live plugin, especially about
incorrect use of send() and recv().

Can be triggered with 32 virtual processors visible on the system with
the root_regression test suite.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: set UST register timeout to -1 as test default
Mathieu Desnoyers [Tue, 28 Apr 2015 14:16:37 +0000 (10:16 -0400)] 
Fix: set UST register timeout to -1 as test default

On busy systems, it's possible to spuriously hit the default 3 seconds
timeout for UST registration to sessiond, thus causing tests to be flaky
on those systems.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoMan page: reference lttng-crash under --shm-path option
Jonathan Rajotte [Wed, 22 Apr 2015 19:39:00 +0000 (15:39 -0400)] 
Man page: reference lttng-crash under --shm-path option

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoTests: Don't rely on implicit scalar expression dereference
Jérémie Galarneau [Thu, 23 Apr 2015 23:41:35 +0000 (19:41 -0400)] 
Tests: Don't rely on implicit scalar expression dereference

This silences an "experimental feature" warning when using Perl 5.20.2.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoman pages: use standard NAME format
Philippe Proulx [Wed, 8 Apr 2015 19:11:41 +0000 (15:11 -0400)] 
man pages: use standard NAME format

As per man(7):

    The only mandatory heading is NAME, which should
    be the first section and be followed on the next
    line by a one-line description of the program:

        .SH NAME
        item \- description

    It is extremely important that this format is followed,
    and that there is a backslash before the single dash
    which follows the item name. This syntax is used by the
    mandb(8) program to create a database of short
    descriptions for the whatis(1) and apropos(1) commands.

Furthermore (lexgrog(1)):

    When using the traditional man macro set, a correct NAME
    section looks something like this:

        .SH NAME
        foo \- program to do something

    Some manual pagers require the ‘\-’ to be exactly as shown;
    mandb is more tolerant, but for compatibility with other
    systems it is nevertheless a good idea to retain the
    backslash.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix python bindings' Makefile for out-of-tree builds
Simon Marchi [Tue, 14 Apr 2015 20:45:27 +0000 (16:45 -0400)] 
Fix python bindings' Makefile for out-of-tree builds

The references to the built archives should use top_builddir and not
top_srcdir, because that's where they are.

And new in V2, I got a new error:

  lttng_wrap.c:2970:25: fatal error: lttng/lttng.h: No such file or directory
   #include <lttng/lttng.h>

I think we are missing the -I$(top_srcdir)/include. I had not noticed this
previously, probably because I had an lttng/lttng.h in
/usr/local/include or /usr/include. Also, the other includes seem
unnecessary. The This is not really related to out-of-tree builds though.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: use LIBS instead of AM_LDFLAGS for dl and c linking
Jonathan Rajotte [Mon, 13 Apr 2015 18:53:04 +0000 (14:53 -0400)] 
Fix: use LIBS instead of AM_LDFLAGS for dl and c linking

The change to --as-needed on linking of the tool chain on Debian based dist
break the build. This fix aim to generalize the linking and be
independent of the distribution choice of base parameter for the linking
process.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Add missing -ldl when checking for lttng-ust
Jérémie Galarneau [Fri, 10 Apr 2015 23:08:03 +0000 (19:08 -0400)] 
Fix: Add missing -ldl when checking for lttng-ust

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoclock plugin: increase offset measurement accuracy
Mathieu Desnoyers [Sun, 12 Oct 2014 11:46:20 +0000 (13:46 +0200)] 
clock plugin: increase offset measurement accuracy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoImplement UST clock override plugin support
Mathieu Desnoyers [Wed, 1 Oct 2014 21:59:20 +0000 (17:59 -0400)] 
Implement UST clock override plugin support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: ownership of filter and filter_expression
Mathieu Desnoyers [Mon, 6 Apr 2015 16:17:20 +0000 (12:17 -0400)] 
Fix: ownership of filter and filter_expression

Applies to the kernel wildcard feature.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: zero memory passed to create channel kernel ioctl
Mathieu Desnoyers [Mon, 6 Apr 2015 16:16:11 +0000 (12:16 -0400)] 
Fix: zero memory passed to create channel kernel ioctl

Valgrind complains about uninitialized memory passed to ioctl.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Check that lttng create --live's time is not zero
Jérémie Galarneau [Thu, 2 Apr 2015 22:44:58 +0000 (18:44 -0400)] 
Fix: Check that lttng create --live's time is not zero

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: Validate lttng_create_session_live's timer is > 0
Jérémie Galarneau [Thu, 2 Apr 2015 22:37:18 +0000 (18:37 -0400)] 
Fix: Validate lttng_create_session_live's timer is > 0

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUI: Only show live timer when the session is in live mode
Jérémie Galarneau [Thu, 2 Apr 2015 22:09:29 +0000 (18:09 -0400)] 
UI: Only show live timer when the session is in live mode

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoUI: Only show tracker PID state when enabled
Jérémie Galarneau [Thu, 2 Apr 2015 22:07:45 +0000 (18:07 -0400)] 
UI: Only show tracker PID state when enabled

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoImplement kernel filter support
Mathieu Desnoyers [Tue, 11 Nov 2014 21:31:40 +0000 (16:31 -0500)] 
Implement kernel filter support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agosyscall tracing: update tests
Mathieu Desnoyers [Wed, 5 Nov 2014 21:54:48 +0000 (16:54 -0500)] 
syscall tracing: update tests

Update syscall tracing tests following the semantic changes of enablers
in lttng-modules and disable behavior of lttng-sessiond.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoSupport lttng-modules syscall wildcards
Mathieu Desnoyers [Wed, 5 Nov 2014 00:14:19 +0000 (19:14 -0500)] 
Support lttng-modules syscall wildcards

While we are there, fix semantic issues with disable-event and various
types of instrumentation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoImplement lttng-modules tracepoint wildcard support
Mathieu Desnoyers [Mon, 3 Nov 2014 20:52:36 +0000 (15:52 -0500)] 
Implement lttng-modules tracepoint wildcard support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix build when configuring with --disable-lttng-ust
Jérémie Galarneau [Tue, 31 Mar 2015 20:02:17 +0000 (16:02 -0400)] 
Fix build when configuring with --disable-lttng-ust

Mark trace_ust_list_tracker_pids as static inline to eliminate
"multiple definition" error.

Fix ust_app_global_update() stub to reflect the signature change
introduced by a9ad0c8f

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: add missing function prototype to trace-ust.h header
Mathieu Desnoyers [Fri, 20 Mar 2015 19:16:11 +0000 (15:16 -0400)] 
Fix: add missing function prototype to trace-ust.h header

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoImplement PID tracker content listing
Mathieu Desnoyers [Wed, 28 Jan 2015 14:50:07 +0000 (09:50 -0500)] 
Implement PID tracker content listing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoImplement UST PID tracker
Mathieu Desnoyers [Mon, 26 Jan 2015 19:01:12 +0000 (14:01 -0500)] 
Implement UST PID tracker

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoCleanup: Remove unimplemented UST domains
Mathieu Desnoyers [Sun, 25 Jan 2015 15:08:10 +0000 (10:08 -0500)] 
Cleanup: Remove unimplemented UST domains

They will be implemented as options of the UST domains.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoImplement PID tracking for kernel tracing
Mathieu Desnoyers [Sat, 27 Sep 2014 21:29:12 +0000 (17:29 -0400)] 
Implement PID tracking for kernel tracing

Implement PID tracking (per-session) for kernel tracing. Only
save/restore and MI are missing.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: leak on error in lttng-crash
Mathieu Desnoyers [Fri, 27 Mar 2015 19:52:00 +0000 (15:52 -0400)] 
Fix: leak on error in lttng-crash

Found by Coverity:
** CID 1291945:  Resource leaks  (RESOURCE_LEAK)
/src/bin/lttng-crash/lttng-crash.c: 769 in copy_crash_data()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoMan page fixes: missing --version option and typo
Jérémie Galarneau [Thu, 26 Mar 2015 21:38:17 +0000 (17:38 -0400)] 
Man page fixes: missing --version option and typo

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocs: add lttng-crash(1) man page
Jérémie Galarneau [Thu, 26 Mar 2015 21:37:07 +0000 (17:37 -0400)] 
Docs: add lttng-crash(1) man page

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoDocs: lttng-crash refers to "lttng"
Jérémie Galarneau [Thu, 26 Mar 2015 21:21:07 +0000 (17:21 -0400)] 
Docs: lttng-crash refers to "lttng"

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
6 years agoFix: possible use of uninitialized data in loglevel conversion funcs
Jérémie Galarneau [Thu, 26 Mar 2015 19:07:35 +0000 (15:07 -0400)] 
Fix: possible use of uninitialized data in loglevel conversion funcs

str will be uninitialized if inputstr[0] == '\0'

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.062939 seconds and 4 git commands to generate.