From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Tue, 7 Jul 2020 23:50:06 +0000 (-0400)
Subject: Fix: action: lttng_action_group_add_action returns status invalid
X-Git-Tag: v2.13.0-rc1~551
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=f3a9cc3478223679d8fea55d5eedce111b462feb;hp=2f571d6fcdc6603de2b68eef27214c360a1dac5d

Fix: action: lttng_action_group_add_action returns status invalid

IS_GROUP_ACTION macro was performed on the action to be added instead
of the action representing the group, `group` in this function.

This always resulted in error on call to lttng_action_group_add_action.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Iecf133fb2165686d1e8abd2225a8f90df22c41dc
---

diff --git a/src/common/actions/group.c b/src/common/actions/group.c
index 1a434616f..f57207415 100644
--- a/src/common/actions/group.c
+++ b/src/common/actions/group.c
@@ -278,7 +278,7 @@ enum lttng_action_status lttng_action_group_add_action(
 	enum lttng_action_status status;
 	int ret;
 
-	if (!group || !IS_GROUP_ACTION(action) || !action) {
+	if (!group || !IS_GROUP_ACTION(group) || !action) {
 		status = LTTNG_ACTION_STATUS_INVALID;
 		goto end;
 	}