From: Mathieu Desnoyers Date: Tue, 17 May 2016 13:20:17 +0000 (-0400) Subject: Fix: tests: incorrect uri index X-Git-Tag: v2.9.0-rc1~199 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=ee059b98e72ba715a13f32b5b4c43158db795c71;hp=ee059b98e72ba715a13f32b5b4c43158db795c71 Fix: tests: incorrect uri index Initial issue found by Coverity: CID 1322864 (#1 of 1): Constant expression result (CONSTANT_EXPRESSION_RESULT)impossible_and: The "and" condition size == 2L && (uri + 0).dtype == LTTNG_DST_IPV4 && (uri + 0).utype == LTTNG_URI_DST && (uri + 0).stype == 0U && (uri + 0).port == 8989 && strcmp((uri + 0).subdir, "my/test/path") == 0 && strcmp((uri + 0).dst.ipv4, "127.0.0.1") == 0 && (uri + 1).dtype == LTTNG_DST_IPV4 && (uri + 1).utype == LTTNG_URI_DST && (uri + 1).stype == 0U && (uri + 1).port == 4242 && strcmp((uri + 0).subdir, "my/test/path") == 0 && strcmp((uri + 1).dst.ipv4, "127.0.0.1") == 0 can never be true because (uri + 0).subdir cannot be equal to two different values at the same time. Review of the test source file led to further fixes. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau ---