From: Jérémie Galarneau Date: Tue, 14 Jul 2020 21:15:49 +0000 (-0400) Subject: Clean-up: relayd: unused tcp keep alive config return value X-Git-Tag: v2.13.0-rc1~601 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=e4265826e636834fa6ee86cc2873bd99e36ccea5;ds=sidebyside Clean-up: relayd: unused tcp keep alive config return value gcc 10.1.0 reports: tcp_keep_alive.c: In function \u2018tcp_keep_alive_init\u2019: tcp_keep_alive.c:519:9: warning: \u2018removed_return.58\u2019 is used uninitialized in this function [-Wuninitialized] 519 | return tcp_keep_alive_init_config(&support, &config); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tcp_keep_alive_init is a constructor and, as such, should not return a value. GCC warns that its return value is unused (although with a somewhat strange warning message). The return value of tcp_keep_alive_init_config is ignored as all error paths log a suitable error and not much more can be done. Signed-off-by: Jérémie Galarneau Change-Id: I912fe7e6c817edf77dd26bc7e18c0a14a9cbe94e --- diff --git a/src/bin/lttng-relayd/tcp_keep_alive.c b/src/bin/lttng-relayd/tcp_keep_alive.c index dc8cf2fb3..81d085024 100644 --- a/src/bin/lttng-relayd/tcp_keep_alive.c +++ b/src/bin/lttng-relayd/tcp_keep_alive.c @@ -513,10 +513,10 @@ error: /* Initialize the TCP keep-alive configuration. */ __attribute__((constructor)) static -int tcp_keep_alive_init(void) +void tcp_keep_alive_init(void) { tcp_keep_alive_init_support(&support); - return tcp_keep_alive_init_config(&support, &config); + (void) tcp_keep_alive_init_config(&support, &config); } /*