From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Sat, 5 Sep 2015 15:44:01 +0000 (-0400)
Subject: Silence undefined return value warning
X-Git-Tag: v2.8.0-rc1~398
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=dd49e13f4a9eddfda119f7bc9dbb1d836689eaad

Silence undefined return value warning

clang-analyzer complains that "ret" may be returned uninitialized
which can't happen with a valid session configuration. For this to
occur, either libxml2 would have to return a bogus ChildElementCount
(return non-zero when there a actually no child nodes) _or_ the node
would have children of an unexpected type, which would be catched by
the validation performed against the XSD.

Nonetheless, the value is initialized here to silence this warning.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/config/config.c b/src/common/config/config.c
index 48dc0b034..6834d7a54 100644
--- a/src/common/config/config.c
+++ b/src/common/config/config.c
@@ -2115,7 +2115,7 @@ static
 int process_pid_tracker_node(xmlNodePtr pid_tracker_node,
 	struct lttng_handle *handle)
 {
-	int ret, child;
+	int ret = 0, child;
 	xmlNodePtr targets_node = NULL;
 	xmlNodePtr node;