From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Tue, 15 Oct 2019 20:56:22 +0000 (-0400)
Subject: Fix: sessiond: application channel creation failure stops start cmd
X-Git-Tag: v2.12.0-rc1~308
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=d767977450c6bf1fb18ce8bb653d6b6dfdb6bb68

Fix: sessiond: application channel creation failure stops start cmd

The creation of an application's channel can fail when, for instance,
a context can't be created. This causes applications that would have
been started _after_ it to never be started.

This keeps the iteration going on error and starts all applications
that could be started. This is more in line with the behaviour of
2.10 (and earlier) since those channel creations would occur as
applications registered and not on tracing "start".

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/ust-app.c b/src/bin/lttng-sessiond/ust-app.c
index 47cda2451..c03772842 100644
--- a/src/bin/lttng-sessiond/ust-app.c
+++ b/src/bin/lttng-sessiond/ust-app.c
@@ -4212,7 +4212,7 @@ int ust_app_create_channel_glb(struct ltt_ust_session *usess,
 			if (session_was_created) {
 				destroy_app_session(app, ua_sess);
 			}
-			goto error_rcu_unlock;
+			/* Continue to the next application. */
 		}
 	}