From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Fri, 26 Feb 2021 19:06:57 +0000 (-0500)
Subject: Fix: lttng: add-trigger: leak of error string
X-Git-Tag: v2.13.0-rc1~304
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=cb1b81ea79adcdc60a2ead88aa787dbbcb2bf422;hp=f6b73530e969cb5bde9bc069f72ceec932bc86ef

Fix: lttng: add-trigger: leak of error string

argpar_state_parse_next allocates an error string on
`ARGPAR_STATE_PARSE_NEXT_STATUS_ERROR_UNKNOWN_OPT` which we choose not
to handle as an error. Still, the error must be free'd.

1447048 Resource leak

The system resource will not be reclaimed and reused, reducing the future availability of the resource.

In handle_action_simple_session: Leak of memory or pointers to system resources (CWE-404)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ib4495dedc6273f376f93f9c5e2a26baf1c08e16c
---

diff --git a/src/bin/lttng/commands/add_trigger.c b/src/bin/lttng/commands/add_trigger.c
index bbba2d4d8..74bb2b2aa 100644
--- a/src/bin/lttng/commands/add_trigger.c
+++ b/src/bin/lttng/commands/add_trigger.c
@@ -1114,9 +1114,9 @@ struct lttng_action *handle_action_simple_session(
 error:
 	lttng_action_destroy(action);
 	action = NULL;
-	free(error);
 	argpar_item_destroy(item);
 end:
+	free(error);
 	return action;
 }