From: Francis Deslauriers <francis.deslauriers@efficios.com>
Date: Tue, 1 Oct 2019 15:06:30 +0000 (-0400)
Subject: Fix: ust-consumer.c: Double unlock of channel lock
X-Git-Tag: v2.12.0-rc1~327
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=b7f59a04d41aae00e0801fbc595af304fe362b36

Fix: ust-consumer.c: Double unlock of channel lock

Coverity report:
  CID 1404942 (#1 of 1): Double unlock (LOCK)
  15. double_unlock: pthread_mutex_unlock unlocks channel->lock while it is
  unlocked.

Reported-by: Coverity (1404942) Double unlock
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/ust-consumer/ust-consumer.c b/src/common/ust-consumer/ust-consumer.c
index f8706d0ba..46b644d34 100644
--- a/src/common/ust-consumer/ust-consumer.c
+++ b/src/common/ust-consumer/ust-consumer.c
@@ -2170,7 +2170,6 @@ end_msg_sessiond:
 
 end_channel_error:
 	if (channel) {
-		pthread_mutex_unlock(&channel->lock);
 		/*
 		 * Free channel here since no one has a reference to it. We don't
 		 * free after that because a stream can store this pointer.