From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Tue, 16 Jul 2013 01:19:19 +0000 (-0400)
Subject: Document metadata_socket_lock nesting
X-Git-Tag: v2.3.0-rc1~15
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=ace17efaf90b672f303b22959146c01793e9d4b2

Document metadata_socket_lock nesting

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/src/common/consumer.h b/src/common/consumer.h
index 5a1195008..18f64b6ef 100644
--- a/src/common/consumer.h
+++ b/src/common/consumer.h
@@ -398,7 +398,11 @@ struct lttng_consumer_local_data {
 	int consumer_error_socket;
 	/* socket to ask metadata to sessiond. */
 	int consumer_metadata_socket;
-	/* Protect consumer_metadata_socket. */
+	/*
+	 * Protect consumer_metadata_socket.
+	 *
+	 * This is nested OUTSIDE the metadata cache lock.
+	 */
 	pthread_mutex_t metadata_socket_lock;
 	/* socket to exchange commands with sessiond */
 	char *consumer_command_sock_path;