From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 10 Apr 2019 20:46:35 +0000 (-0400)
Subject: Fix tests: NULL pointer dereference in ltt_session unit tests
X-Git-Tag: v2.12.0-rc1~614
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=acd4994ea8be231df5caecefd580bad358ce16e5;hp=30b66335dc3656fc79129b9e7dfe1cf13ae578e1;ds=sidebyside

Fix tests: NULL pointer dereference in ltt_session unit tests

Skip the session destruction test if the target session is not
found. Otherwise, a NULL pointer dereference will occur.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/tests/unit/test_session.c b/tests/unit/test_session.c
index 991b1dca3..cdb1bb88d 100644
--- a/tests/unit/test_session.c
+++ b/tests/unit/test_session.c
@@ -269,9 +269,13 @@ void test_destroy_session(void)
 	ok(tmp != NULL,
 	   "Destroying session: session found");
 
-	ok(destroy_one_session(tmp) == 0,
-	   "Destroying session: %s destroyed",
-	   SESSION1);
+	if (tmp) {
+		ok(destroy_one_session(tmp) == 0,
+		   "Destroying session: %s destroyed",
+		   SESSION1);
+	} else {
+		skip(1, "Skipping session destruction as it was not found");
+	}
 	session_unlock_list();
 }