From: Jérémie Galarneau Date: Wed, 27 Mar 2019 19:31:13 +0000 (-0400) Subject: Clarify incorrect channel output type logging message X-Git-Tag: v2.12.0-rc1~639 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=9381314c87fe85771c05b01c85ca1c389eacb853;hp=f72bb42fe5fb36e43df18f9df6d0d389db699170 Clarify incorrect channel output type logging message Recording a snapshot is only supported for channels that have an "mmap" output type. Add the channel's name and an explanation of the error in the consumer daemon's log as the channel's 'output' integral representation is of limited use. Signed-off-by: Jérémie Galarneau --- diff --git a/src/common/kernel-consumer/kernel-consumer.c b/src/common/kernel-consumer/kernel-consumer.c index 246ae6b59..4e93bee91 100644 --- a/src/common/kernel-consumer/kernel-consumer.c +++ b/src/common/kernel-consumer/kernel-consumer.c @@ -144,7 +144,8 @@ static int lttng_kconsumer_snapshot_channel( /* Splice is not supported yet for channel snapshot. */ if (channel->output != CONSUMER_CHANNEL_MMAP) { - ERR("Unsupported output %d", channel->output); + ERR("Unsupported output type for channel \"%s\": mmap output is required to record a snapshot", + channel->name); ret = -1; goto end; }