From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Mon, 20 Aug 2018 19:54:57 +0000 (-0400)
Subject: Fix: unchecked return value of cds_lfht_destroy
X-Git-Tag: v2.11.0-rc1~142
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=8aca663cd2a1cc1680b18a349f7d8b9bef8ef490

Fix: unchecked return value of cds_lfht_destroy

The sessiond should assert that cds_lfht_destroy returns 0 when
tearing down the 'pending rotate channel' hash table as a non-zero
value would indicate a leak.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/rotation-thread.c b/src/bin/lttng-sessiond/rotation-thread.c
index dcae248b4..24ab0c803 100644
--- a/src/bin/lttng-sessiond/rotation-thread.c
+++ b/src/bin/lttng-sessiond/rotation-thread.c
@@ -261,8 +261,11 @@ error:
 static
 void fini_thread_state(struct rotation_thread_state *state)
 {
+	int ret;
+
 	lttng_poll_clean(&state->events);
-	cds_lfht_destroy(channel_pending_rotate_ht, NULL);
+	ret = cds_lfht_destroy(channel_pending_rotate_ht, NULL);
+	assert(!ret);
 	if (rotate_notification_channel) {
 		lttng_notification_channel_destroy(rotate_notification_channel);
 	}