From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Tue, 16 Aug 2011 16:56:07 +0000 (-0400)
Subject: Turn consumer "normal" error into debug statement (with comment)
X-Git-Tag: v2.0-pre12~17
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=81ffcd20d37d0d99b2676a7eabb0f0bf42c54e69;ds=sidebyside

Turn consumer "normal" error into debug statement (with comment)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/ltt-kconsumerd/ltt-kconsumerd.c b/ltt-kconsumerd/ltt-kconsumerd.c
index cd4b00e01..ca939656b 100644
--- a/ltt-kconsumerd/ltt-kconsumerd.c
+++ b/ltt-kconsumerd/ltt-kconsumerd.c
@@ -207,7 +207,13 @@ static int read_subbuffer(struct lttng_kconsumerd_fd *kconsumerd_fd)
 	err = kernctl_get_next_subbuf(infd);
 	if (err != 0) {
 		ret = errno;
-		perror("Reserving sub buffer failed (everything is normal, "
+		/*
+		 * This is a debug message even for single-threaded consumer,
+		 * because poll() have more relaxed criterions than get subbuf,
+		 * so get_subbuf may fail for short race windows where poll()
+		 * would issue wakeups.
+		 */
+		DBG("Reserving sub buffer failed (everything is normal, "
 				"it is due to concurrency)");
 		goto end;
 	}