From: Jérémie Galarneau Date: Thu, 2 Apr 2020 02:16:32 +0000 (-0400) Subject: Fix: sessiond: erroneous error code returned on rotation failure X-Git-Tag: v2.13.0-rc1~694 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=7e0de2192e89732f6dea0b72992096a028ca02d1;hp=58f237ca4b04da3423263585b5cfa57845c44952 Fix: sessiond: erroneous error code returned on rotation failure `LTTNG_ERR_KERN_CONSUMER_FAIL` is returned by the kernel domain rotation handling code. This code is associated with a failure to launch the kernel consumer daemon which is not the case here. The `LTTNG_ERR_ROTATION_FAIL_CONSUMER` is used instead and returned to the client. Signed-off-by: Jérémie Galarneau Change-Id: Ifdc9e46addcc4dc7ca2002d6dff5b2d7ac6c31f3 --- diff --git a/src/bin/lttng-sessiond/kernel.c b/src/bin/lttng-sessiond/kernel.c index 547d2ec6c..53efad5e7 100644 --- a/src/bin/lttng-sessiond/kernel.c +++ b/src/bin/lttng-sessiond/kernel.c @@ -1741,7 +1741,7 @@ enum lttng_error_code kernel_rotate_session(struct ltt_session *session) ksess->uid, ksess->gid, ksess->consumer, /* is_metadata_channel */ false); if (ret < 0) { - status = LTTNG_ERR_KERN_CONSUMER_FAIL; + status = LTTNG_ERR_ROTATION_FAIL_CONSUMER; goto error; } } @@ -1753,7 +1753,7 @@ enum lttng_error_code kernel_rotate_session(struct ltt_session *session) ksess->uid, ksess->gid, ksess->consumer, /* is_metadata_channel */ true); if (ret < 0) { - status = LTTNG_ERR_KERN_CONSUMER_FAIL; + status = LTTNG_ERR_ROTATION_FAIL_CONSUMER; goto error; } }