From: Christian Babeux Date: Fri, 24 Aug 2012 02:05:12 +0000 (-0400) Subject: Notify the user if a filter is already enabled X-Git-Tag: v2.1.0-rc3~13 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=7671f53cf3b6029a3bf00e502a0a58ac7a82e378;hp=7671f53cf3b6029a3bf00e502a0a58ac7a82e378 Notify the user if a filter is already enabled When using the enable-event command in conjunction with the --filter option, a user can specify a filter expression to refine the trace output. As stated in the lttng(1) man page, only the first activation of a filter on an event will work. Subsequent activation of any filter expression on the same event will fail. e.g: > lttng enable-event app:tp -s session -u --filter 'somefield > 42' Case: invalid filter expression > lttng enable-event app:tp -s session -u --filter 'invalid expression' Error: Error setting filter Warning: Some command(s) went wrong > ... Case: filter already enabled for event app:tp > lttng enable-event app:tp -s session -u --filter 'someotherfield < 42' Error: Error setting filter Warning: Some command(s) went wrong This commit differentiate the case where a filter was already set for the specified event from the generic 'Error setting filter' error message. e.g: > lttng enable-event app:tp -s session -u --filter 'somefield > 42' Case: invalid filter expression > lttng enable-event app:tp -s session -u --filter 'invalid expression' Error: Error setting filter Warning: Some command(s) went wrong > ... Case: filter already enabled for event app:tp > lttng enable-event app:tp -s session -u --filter 'someotherfield < 42' Error: Filter on event app:tp is already enabled (channel 0, session session) Warning: Some command(s) went wrong Acked-by: Mathieu Desnoyers Signed-off-by: Christian Babeux Signed-off-by: David Goulet ---