From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 11 Sep 2019 00:26:47 +0000 (-0400)
Subject: Fix: report bytecode_push failure when pushing symbol
X-Git-Tag: v2.12.0-rc1~404
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=73e38068d5e19fd338f29e897598b15ab5ae743b;ds=inline

Fix: report bytecode_push failure when pushing symbol

The last use of bytecode_push's return value is not checked in
visit_node_load_expression_legacy().

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
index 74ec1a715..0e778562f 100644
--- a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
+++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
@@ -295,6 +295,9 @@ int visit_node_load_expression_legacy(struct filter_parser_ctx *ctx,
 	}
 	ret = bytecode_push(&ctx->bytecode_reloc, symbol,
 				1, strlen(symbol) + 1);
+	if (ret) {
+		goto end;
+	}
 	ret = 1;	/* legacy */
 end:
 	free(insn);