From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Fri, 26 Mar 2021 22:39:30 +0000 (-0400)
Subject: Fix: on-event condition: don't abort() on invalid event expression type
X-Git-Tag: v2.13.0-rc1~180
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=52894180cf9d44e1f13f467abafc1fd64ffb8c9e

Fix: on-event condition: don't abort() on invalid event expression type

Protocol errors should not result in crashes. Simply report the
failure to deserialize the event expression.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ic5a0be6b248c430fcf1fe487cd734d9bdf5dd36a
---

diff --git a/src/common/conditions/on-event.c b/src/common/conditions/on-event.c
index 31d6d756b..fa37a3540 100644
--- a/src/common/conditions/on-event.c
+++ b/src/common/conditions/on-event.c
@@ -743,7 +743,9 @@ struct lttng_event_expr *event_expr_from_payload(
 		break;
 	}
 	default:
-		abort();
+		ERR("Invalid event expression type encoutered while deserializing event expression: type = %" PRIu64,
+				type);
+		goto error;
 	}
 
 	goto end;