From: Jérémie Galarneau Date: Wed, 7 Apr 2021 16:54:09 +0000 (-0400) Subject: Fix: sessiond: error accounting: wrong sizeof argument cpu_counters X-Git-Tag: v2.13.0-rc1~151 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=477b83a4de8580a75e3aa88de423c7081e49d6e0;ds=sidebyside Fix: sessiond: error accounting: wrong sizeof argument cpu_counters `cpu_counters` is an array of `struct lttng_ust_abi_object_data *`, not of `struct lttng_ust_abi_object_data`. This didn't cause any problems since the structure is larger than a pointer. 1452203 Wrong sizeof argument The wrong sizeof value is used in an expression or as argument to a function. The result is an incorrect value that may cause unexpected program behaviors. In event_notifier_error_accounting_register_app: The sizeof operator is invoked on the wrong argument (CWE-569) Reported-by: Coverity Scan Signed-off-by: Jérémie Galarneau Change-Id: I9278949aab0a98f050ec232d7b8ce024240020d0 --- diff --git a/src/bin/lttng-sessiond/event-notifier-error-accounting.c b/src/bin/lttng-sessiond/event-notifier-error-accounting.c index f0e567f72..cb8380251 100644 --- a/src/bin/lttng-sessiond/event-notifier-error-accounting.c +++ b/src/bin/lttng-sessiond/event-notifier-error-accounting.c @@ -438,7 +438,7 @@ event_notifier_error_accounting_register_app(struct ust_app *app) goto error_send_counter_data; } - cpu_counters = zmalloc(entry->nr_counter_cpu_fds * sizeof(struct lttng_ust_abi_object_data)); + cpu_counters = zmalloc(entry->nr_counter_cpu_fds * sizeof(struct lttng_ust_abi_object_data *)); if (!cpu_counters) { PERROR("Failed to allocate event notifier error counter lttng_ust_abi_object_data array: application uid = %d, application name = '%s', pid = %d, allocation size = %zu", (int) app->uid, app->name, (int) app->pid,