From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Mon, 25 May 2020 20:15:40 +0000 (-0400)
Subject: Fix: validate that array expression contains constant
X-Git-Tag: v2.13.0-rc1~113
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=4062406e2a957323852dca73a41e0239f6b9df03;hp=6ac56bb9dd3adec203a6c689e37ea43f6f3ac19b;ds=sidebyside

Fix: validate that array expression contains constant

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ic7ea2192b3bf0f5c32f5db8fce622f73b182906f
---

diff --git a/src/common/filter/filter-visitor-generate-ir.c b/src/common/filter/filter-visitor-generate-ir.c
index b7bc17d18..fb5d815d9 100644
--- a/src/common/filter/filter-visitor-generate-ir.c
+++ b/src/common/filter/filter-visitor-generate-ir.c
@@ -244,6 +244,11 @@ struct ir_load_expression *create_load_expression(struct filter_node *node)
 				bracket_node != NULL;
 				bracket_node = bracket_node->u.expression.next_bracket) {
 			prev_op = load_exp_op;
+			if (bracket_node->type != NODE_EXPRESSION ||
+				bracket_node->u.expression.type != AST_EXP_CONSTANT) {
+					fprintf(stderr, "[error] Expecting constant index in array expression\n");
+					goto error;
+				}
 			load_exp_op = calloc(sizeof(struct ir_load_expression_op), 1);
 			if (!load_exp_op)
 				goto error;