From: Jérémie Galarneau Date: Sun, 30 Aug 2015 22:50:39 +0000 (-0400) Subject: Fix: Memory leak of agent X-Git-Tag: v2.8.0-rc1~443 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=35ed21a5450a8ac715e79663714fc3c0f475309d;ds=sidebyside Fix: Memory leak of agent agent_destroy() has a comment which indicates that it does _not_ destroy the pointer passed to it and it seems that agents are never realeased under any code path whatsoever. There does not seem to be an instance where an agent is allocated on the stack. Signed-off-by: Jérémie Galarneau --- diff --git a/src/bin/lttng-sessiond/agent.c b/src/bin/lttng-sessiond/agent.c index adca25ac1..b7d41f2f4 100644 --- a/src/bin/lttng-sessiond/agent.c +++ b/src/bin/lttng-sessiond/agent.c @@ -960,8 +960,7 @@ void agent_destroy_event(struct agent_event *event) } /* - * Destroy an agent completely. Note that the given pointer is NOT freed - * thus a reference to static or stack data can be passed to this function. + * Destroy an agent completely. */ void agent_destroy(struct agent *agt) { @@ -992,6 +991,7 @@ void agent_destroy(struct agent *agt) rcu_read_unlock(); ht_cleanup_push(agt->events); + free(agt); } /*