From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Sun, 23 Aug 2015 05:01:36 +0000 (-0700)
Subject: Fix: sessiond consumer thread should register as RCU thread
X-Git-Tag: v2.8.0-rc1~425
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=34c1e15a80239977ba300668f5736620938fea36

Fix: sessiond consumer thread should register as RCU thread

Fixes RCU race where objects are accessed by this thread under RCU
read-side lock after free. Since this thread is not a registered RCU
reader, the read-side lock has no effect.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index c5c7d84b1..5a7d153e5 100644
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -1216,6 +1216,9 @@ static void *thread_manage_consumer(void *data)
 
 	DBG("[thread] Manage consumer started");
 
+	rcu_register_thread();
+	rcu_thread_online();
+
 	health_register(health_sessiond, HEALTH_SESSIOND_TYPE_CONSUMER);
 
 	health_code_update();
@@ -1514,6 +1517,9 @@ error_poll:
 	health_unregister(health_sessiond);
 	DBG("consumer thread cleanup completed");
 
+	rcu_thread_offline();
+	rcu_unregister_thread();
+
 	return NULL;
 }