From: Mathieu Desnoyers Date: Tue, 17 May 2016 01:43:01 +0000 (-0400) Subject: Fix: illegal memory access in test_create_kernel_event X-Git-Tag: v2.9.0-rc1~211 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=1c0733db3285fb4e4a9ea4fe8f28a46dfe69e6d4 Fix: illegal memory access in test_create_kernel_event Found by Coverity: CID 1243030 (#1 of 1): Buffer not null terminated (BUFFER_SIZE_WARNING)1. buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array ev.name of size 256 bytes might leave the destination string unterminated. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- diff --git a/tests/unit/test_kernel_data.c b/tests/unit/test_kernel_data.c index f1e1b388c..fde46f76f 100644 --- a/tests/unit/test_kernel_data.c +++ b/tests/unit/test_kernel_data.c @@ -32,7 +32,7 @@ #define RANDOM_STRING_LEN 11 /* Number of TAP tests in this file */ -#define NUM_TESTS 10 +#define NUM_TESTS 11 /* For error.h */ int lttng_opt_quiet = 1; @@ -134,7 +134,9 @@ static void test_create_kernel_event(void) struct lttng_event ev; memset(&ev, 0, sizeof(ev)); - strncpy(ev.name, get_random_string(), LTTNG_KERNEL_SYM_NAME_LEN); + ok(lttng_strncpy(ev.name, get_random_string(), + LTTNG_KERNEL_SYM_NAME_LEN), + "Validate string length"); ev.type = LTTNG_EVENT_TRACEPOINT; ev.loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;