From: Mathieu Desnoyers Date: Tue, 17 May 2016 01:43:00 +0000 (-0400) Subject: Fix: illegal memory access in test_create_ust_channel X-Git-Tag: v2.9.0-rc1~212 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=1b0eb8655d6312877790b92ae3b0cc39f2cf1a13 Fix: illegal memory access in test_create_ust_channel Found by Coverity: CID 1243032 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)1. buffer_size: Calling strncpy with a source string whose length (8 chars) is greater than or equal to the size argument (8) will fail to null-terminate attr.name. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- diff --git a/tests/unit/test_ust_data.c b/tests/unit/test_ust_data.c index 29bb58f48..f5c8b0172 100644 --- a/tests/unit/test_ust_data.c +++ b/tests/unit/test_ust_data.c @@ -38,7 +38,7 @@ #define RANDOM_STRING_LEN 11 /* Number of TAP tests in this file */ -#define NUM_TESTS 12 +#define NUM_TESTS 13 /* For error.h */ int lttng_opt_quiet = 1; @@ -101,8 +101,8 @@ static void test_create_ust_channel(void) memset(&attr, 0, sizeof(attr)); - strncpy(attr.name, "channel0", 8); - + ok(lttng_strncpy(attr.name, "channel0", sizeof(attr.name)) == 0, + "Validate channel name length"); uchan = trace_ust_create_channel(&attr, LTTNG_DOMAIN_UST); ok(uchan != NULL, "Create UST channel");