From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Fri, 20 Sep 2019 15:34:21 +0000 (-0400)
Subject: Fix: Close socket handle on error
X-Git-Tag: v2.12.0-rc1~363
X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=189720830e2fc291831674419c1f303d91d10657;hp=e20ca0249f0a7b3b8e2d8f50437e63ea17b8f6e9

Fix: Close socket handle on error

Fixes coverity #1399739

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/client.c b/src/bin/lttng-sessiond/client.c
index 956dab8c8..870277534 100644
--- a/src/bin/lttng-sessiond/client.c
+++ b/src/bin/lttng-sessiond/client.c
@@ -1985,8 +1985,11 @@ static int create_client_sock(void)
 	/* File permission MUST be 660 */
 	ret = chmod(config.client_unix_sock_path.value, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP);
 	if (ret < 0) {
-		ERR("Set file permissions failed: %s", config.client_unix_sock_path.value);
+		ERR("Set file permissions failed: %s",
+				config.client_unix_sock_path.value);
 		PERROR("chmod");
+		(void) lttcomm_close_unix_sock(client_sock);
+		ret = -1;
 		goto end;
 	}
 	DBG("Created client socket (fd = %i)", client_sock);