From: Jérémie Galarneau Date: Wed, 27 Mar 2019 19:42:19 +0000 (-0400) Subject: Fix: wrong error code returned by kernel_snapshot_record() X-Git-Tag: v2.12.0-rc1~638 X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=0ed78e50c92e986d1c766a76ba5c3bca6125a989 Fix: wrong error code returned by kernel_snapshot_record() On snapshot error, kernel_snapshot_record() can return LTTNG_ERR_KERN_CONSUMER_FAIL which means that the kernel consumer daemon failed to launch. In this path, the appropriate error to return is LTTNG_ERR_KERN_META_FAIL. Signed-off-by: Jérémie Galarneau --- diff --git a/src/bin/lttng-sessiond/kernel.c b/src/bin/lttng-sessiond/kernel.c index 8e972b069..e3118f191 100644 --- a/src/bin/lttng-sessiond/kernel.c +++ b/src/bin/lttng-sessiond/kernel.c @@ -1297,7 +1297,7 @@ enum lttng_error_code kernel_snapshot_record(struct ltt_kernel_session *ksess, /* Put back the saved consumer output into the session. */ ksess->consumer = saved_output; if (ret < 0) { - status = LTTNG_ERR_KERN_CONSUMER_FAIL; + status = LTTNG_ERR_KERN_META_FAIL; goto error_consumer; }