Tests: Fix: 99% fill ratio for high buffer usage is too high for larger events
authorJonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Thu, 28 May 2020 01:29:05 +0000 (21:29 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 6 Nov 2020 20:20:16 +0000 (15:20 -0500)
If the event being registered is bigger than 1% of a subbuffer, the 99%
ratio cannot be achieved since the "last event" necessary to go over 99%
will always be dropped by the tracer.

e.g:
  DBG1 - 19:31:07.665963875 [Notification]: [notification-thread] High buffer usage condition being evaluated: threshold = 16220, highest usage = 16196 (in evaluate_buffer_usage_condition() at notification-thread-events.c:3733)

We use a ratio of 90% to keep a little headroom.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I06180735e0b5e88209b888e51cc83b4ac7d98193

tests/regression/tools/notification/notification.c

index 90abc11de1215a5d94ed90aa20b4b872ce2a2167..e13979ee8ca385f2de36347fb529f548e4d72eab 100644 (file)
@@ -413,7 +413,7 @@ void test_notification_channel(const char *session_name, const char *channel_nam
        struct lttng_condition *dummy_condition = NULL;
 
        double low_ratio = 0.0;
-       double high_ratio = 0.99;
+       double high_ratio = 0.90;
 
        /* Set-up */
        action = lttng_action_notify_create();
This page took 0.033164 seconds and 4 git commands to generate.