Fix: Use MSG_NOSIGNAL when calling sendmsg()

Applications using the liblttng-ctl library are most probably
not expecting the SIGPIPE signal which can be triggered by
sendmsg() on a closed socket. Use the MSG_NOSIGNAL flag to
handle such cases gracefully.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/common/sessiond-comm/unix.c b/src/common/sessiond-comm/unix.c
index 97537c538b9b28d37cbcbbbe857951b1545ef2a6..a66bb750a8633567d8020ba3ac1c1d6571f62662 100644 (file)
--- a/src/common/sessiond-comm/unix.c
+++ b/src/common/sessiond-comm/unix.c
@@ -173,7 +173,7 @@ ssize_t lttcomm_recv_unix_sock(int sock, void *buf, size_t len)
 
        do {
                len_last = iov[0].iov_len;
 
        do {
                len_last = iov[0].iov_len;

-               ret = recvmsg(sock, &msg, 0);
+               ret = recvmsg(sock, &msg, MSG_NOSIGNAL);

                if (ret > 0) {
                        iov[0].iov_base += ret;
                        iov[0].iov_len -= ret;
                if (ret > 0) {
                        iov[0].iov_base += ret;
                        iov[0].iov_len -= ret;