Fix: trigger: erroneous check for success of trigger creation

6808ef55e added a check for `ret == 0` to determine if a trigger
could be created from a payload. The function returns >= 0 on
success, leading to crashes when a trigger is de-serialized.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Icd769dcb04f7637aa1877436e9a5570e7f20b63b

diff --git a/src/common/trigger.c b/src/common/trigger.c
index e69e72e076267be0b7b6290b9032cc11b941caa1..e038fa81a052d71fe3952afaae96c96982a23ae3 100644 (file)
--- a/src/common/trigger.c
+++ b/src/common/trigger.c
@@ -264,7 +264,7 @@ error:
        lttng_condition_put(condition);
        lttng_action_put(action);
 end:
        lttng_condition_put(condition);
        lttng_action_put(action);
 end:

-       if (ret == 0) {
+       if (ret >= 0) {

                *_trigger = trigger;
        } else {
                lttng_trigger_put(trigger);
                *_trigger = trigger;
        } else {
                lttng_trigger_put(trigger);