Fix: set the logger level to prevent unexpected level inheritance
authorJonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Thu, 26 May 2016 22:14:37 +0000 (18:14 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Sat, 28 May 2016 06:35:55 +0000 (02:35 -0400)
BSF and other jars can ship with an embedded log4j.properties
file. This causes problem when launching an application with a general
class path (e.g /usr/share/java/*) since log4j will look for a
configuration file in all loaded jars. If any contains a directive for
the root logger, it will affect any logger with no level that are
directly under the root logger. This can result in an unexpected
behaviour (e.g no events triggered etc.).

Link: https://issues.apache.org/jira/browse/BSF-24
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
tests/regression/ust/java-log4j/JTestLTTng.java

index 64a471bf85607ffe6238f5ced8b6d436cc73a875..33566bd74256a1a1d8375f755361183909ea46ca 100644 (file)
@@ -23,6 +23,7 @@ import java.lang.Integer;
 import org.apache.log4j.Appender;
 import org.apache.log4j.BasicConfigurator;
 import org.apache.log4j.Logger;
+import org.apache.log4j.Level;
 import org.lttng.ust.agent.log4j.LttngLogAppender;
 
 public class JTestLTTng {
@@ -40,6 +41,18 @@ public class JTestLTTng {
                Logger lttng = Logger.getLogger("log4j-event");
                Logger lttng2 = Logger.getLogger("log4j-event-2");
 
+               /*
+                * Set lowest level to make sure all event levels are logged.
+                * Any jar can override the default log4j rootLogger level
+                * and a logger with no explicit level defaults to the non-null
+                * parent level. Events could be ignored if the inherited value
+                * is too low, thereby failing the test.
+                *
+                * See BSF  -> https://issues.apache.org/jira/browse/BSF-24
+                */
+               lttng.setLevel(Level.ALL);
+               lttng2.setLevel(Level.ALL);
+
                int nrIter = Integer.parseInt(args[0]);
                int waitTime = Integer.parseInt(args[1]);
                int fire_debug_tp = 0;
This page took 0.025012 seconds and 4 git commands to generate.