Clean-up: mi: remove logically dead code

1412199 Logically dead code

The indicated dead code may have performed some action; that action
will never occur.

In mi_lttng_id_target: Code can never be reached because of a logical
contradiction (CWE-561)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I8279cd1e6ab5bc86bd4ea4ca8ac721ad1e31e02b

diff --git a/src/common/mi-lttng.c b/src/common/mi-lttng.c
index bd5049efea8b8b88b5b833ad98763a58305a884c..f9f1e225aec32f1b383022e4a2afb55b2e9f90da 100644 (file)
--- a/src/common/mi-lttng.c
+++ b/src/common/mi-lttng.c
@@ -1743,9 +1743,6 @@ int mi_lttng_id_target(struct mi_writer *writer,
                ret = -LTTNG_ERR_INVALID;
                goto end;
        }
                ret = -LTTNG_ERR_INVALID;
                goto end;
        }

-       if (ret) {
-               goto end;
-       }

 
        if (!is_open) {
                ret = mi_lttng_writer_close_element(writer);
 
        if (!is_open) {
                ret = mi_lttng_writer_close_element(writer);