Fix: unchecked pointer from getenv() for lttng create
authorDavid Goulet <dgoulet@efficios.com>
Tue, 19 Jun 2012 15:15:38 +0000 (11:15 -0400)
committerDavid Goulet <dgoulet@efficios.com>
Tue, 19 Jun 2012 15:15:38 +0000 (11:15 -0400)
The lttng create command was not handling the return pointer from
getenv("HOME") and was passing it to a strdup() call.

(close #271)

Signed-off-by: David Goulet <dgoulet@efficios.com>
src/bin/lttng/commands/create.c

index 2778ef553cdd2a24c27567f780be0b1c950678c6..eac261ac7a4b6575405039553a1606970b74cc1d 100644 (file)
@@ -94,13 +94,14 @@ static int create_session()
 
        /* Auto output path */
        if (opt_output_path == NULL) {
 
        /* Auto output path */
        if (opt_output_path == NULL) {
-               alloc_path = strdup(config_get_default_path());
+               alloc_path = config_get_default_path();
                if (alloc_path == NULL) {
                if (alloc_path == NULL) {
-                       ERR("Home path not found.\n \
+                       ERR("HOME path not found.\n \
                                 Please specify an output path using -o, --output PATH");
                        ret = CMD_FATAL;
                        goto error;
                }
                                 Please specify an output path using -o, --output PATH");
                        ret = CMD_FATAL;
                        goto error;
                }
+               alloc_path = strdup(alloc_path);
 
                if (have_name) {
                        ret = asprintf(&traces_path, "%s/" DEFAULT_TRACE_DIR_NAME
 
                if (have_name) {
                        ret = asprintf(&traces_path, "%s/" DEFAULT_TRACE_DIR_NAME
This page took 0.035321 seconds and 4 git commands to generate.