Fix: relayd: Dereference after null check

Coverity report:
  CID 1404934 (#1 of 1): Dereference after null check (FORWARD_NULL)
  11. var_deref_model: Passing null pointer element to
  trace_chunk_registry_ht_element_put, which dereferences it.

Reported-by: Coverity (1404934) Dereference after null check
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-relayd/sessiond-trace-chunks.c b/src/bin/lttng-relayd/sessiond-trace-chunks.c
index 495227226e8a4bcb5f48c62a607ae29e1ce91336..f2dfa23a11826d935ec1e2f189d9bdeef4e6b958 100644 (file)
--- a/src/bin/lttng-relayd/sessiond-trace-chunks.c
+++ b/src/bin/lttng-relayd/sessiond-trace-chunks.c
@@ -151,6 +151,10 @@ static
 void trace_chunk_registry_ht_element_put(
                struct trace_chunk_registry_ht_element *element)
 {
 void trace_chunk_registry_ht_element_put(
                struct trace_chunk_registry_ht_element *element)
 {

+       if (!element) {
+               return;
+       }
+

        urcu_ref_put(&element->ref, trace_chunk_registry_ht_element_release);
 }
 
        urcu_ref_put(&element->ref, trace_chunk_registry_ht_element_release);
 }