Filter: document ust app ctx limitation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/event.c b/src/bin/lttng-sessiond/event.c
index b7b80d366c6ed60d9027ffcfd1e3320c60cc18d0..ecb368fd51ae5fd7971f7aa23d220918a07f9d2f 100644 (file)
--- a/src/bin/lttng-sessiond/event.c
+++ b/src/bin/lttng-sessiond/event.c
@@ -422,6 +422,9 @@ error:
 /*
  * Check if this event's filter requires the activation of application contexts
  * and enable them in the agent.
+ * TODO: bytecode iterator does not support non-legacy application
+ * contexts yet. Not an issue for now, since they are not generated by
+ * the lttng-ctl library.
  */
 static int add_filter_app_ctx(struct lttng_filter_bytecode *bytecode,
                const char *filter_expression, struct agent *agt)

diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
index 1ab98138e61e16f4120f3be7ae508b518dac65cc..74ec1a7157aa907610e18cf55098345cf79091a9 100644 (file)
--- a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
+++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
@@ -319,6 +319,10 @@ int visit_node_load_expression(struct filter_parser_ctx *ctx,
                return -EINVAL;
        }
 
+       /*
+        * TODO: if we remove legacy load for application contexts, we
+        * need to update session bytecode parser as well.
+        */
        ret = visit_node_load_expression_legacy(ctx, exp, op);
        if (ret < 0) {
                return ret;