Fix: sessiond: wrong variable checked for error code

Coverity reports:
  1430513 Logically dead code

  The indicated dead code may have performed some action; that action
  will never occur.

  In ust_app_open_packets: Code can never be reached because of a
  logical contradiction (CWE-561)

The `open_ret` variable should be checked instead of `ret` after calling
consumer_open_channel_packets.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I49ad2d2b747e29414fee7f0727df1feb343695bb

diff --git a/src/bin/lttng-sessiond/ust-app.c b/src/bin/lttng-sessiond/ust-app.c
index befbfab32dc2c692b56ef3005e4e46ad0ef9bf2a..58be25bbd20ff27ded6538aa9bfe329f8fbca6ec 100644 (file)
--- a/src/bin/lttng-sessiond/ust-app.c
+++ b/src/bin/lttng-sessiond/ust-app.c
@@ -6747,7 +6747,7 @@ enum lttng_error_code ust_app_open_packets(struct ltt_session *session)
                                         * Per-PID buffer and application going
                                         * away.
                                         */
                                         * Per-PID buffer and application going
                                         * away.
                                         */

-                                       if (ret == -LTTNG_ERR_CHAN_NOT_FOUND) {
+                                       if (open_ret == -LTTNG_ERR_CHAN_NOT_FOUND) {

                                                continue;
                                        }
 
                                                continue;
                                        }