Fix: remove logically dead code in send_channel_uid_to_ust
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tue, 17 May 2016 16:31:23 +0000 (12:31 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 18 May 2016 19:32:45 +0000 (15:32 -0400)
Found by Coverity:

at_most: At condition ret < 0, the value of ret must be at most -1.
    cannot_set: At condition ret < 0, the value of ret cannot be equal
to any of {-1030, -32}.
    dead_error_condition: The condition ret < 0 must be true.
2825                        } else if (ret < 0) {
2826                                goto error_stream_unlock;
2827                        }
    CID 1323135 (#1 of 1): Logically dead code
(DEADCODE)dead_error_line: Execution cannot reach this statement: goto
error_stream_unlock;.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng-sessiond/ust-app.c

index 1bb183d5c68dfe7d4e5d56125f1dfbac26492a3a..17e33a1087dc837593520a2eeb3249267a5096f1 100644 (file)
@@ -2821,9 +2821,6 @@ static int send_channel_uid_to_ust(struct buffer_reg_channel *reg_chan,
                        (void) release_ust_app_stream(-1, &stream, app);
                        if (ret == -EPIPE || ret == -LTTNG_UST_ERR_EXITING) {
                                ret = -ENOTCONN; /* Caused by app exiting. */
                        (void) release_ust_app_stream(-1, &stream, app);
                        if (ret == -EPIPE || ret == -LTTNG_UST_ERR_EXITING) {
                                ret = -ENOTCONN; /* Caused by app exiting. */
-                               goto error_stream_unlock;
-                       } else if (ret < 0) {
-                               goto error_stream_unlock;
                        }
                        goto error_stream_unlock;
                }
                        }
                        goto error_stream_unlock;
                }
This page took 0.039047 seconds and 4 git commands to generate.