Fix: sessiond: error accounting: wrong sizeof argument cpu_counters
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 7 Apr 2021 17:01:44 +0000 (13:01 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 7 Apr 2021 17:01:44 +0000 (13:01 -0400)
1452205 Wrong sizeof argument

The wrong sizeof value is used in an expression or as argument to a function. The result is an incorrect value that may cause unexpected program behaviors.

In create_uid_accounting_entry: The sizeof operator is invoked on the wrong argument (CWE-569)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I1912964bd1579f3b1ff013000848c28cea6a9d52

src/bin/lttng-sessiond/event-notifier-error-accounting.c

index cb8380251924476eb0efe4191b361edbac2eb195..aee82742a80ba9412f641632081fae402b3159b3 100644 (file)
@@ -223,11 +223,11 @@ struct error_account_entry *create_uid_accounting_entry(
                cpu_counter_fds[i] = -1;
        }
 
-       cpu_counters = zmalloc(entry->nr_counter_cpu_fds * sizeof(**cpu_counters));
+       cpu_counters = zmalloc(entry->nr_counter_cpu_fds * sizeof(struct lttng_ust_abi_object_data *));
        if (!cpu_counters) {
                PERROR("Failed to allocate event notifier error counter lttng_ust_abi_object_data array: application uid = %d, application name = '%s', pid = %d, allocation size = %zu",
                                (int) app->uid, app->name, (int) app->pid,
-                               entry->nr_counter_cpu_fds * sizeof(**cpu_counters));
+                               entry->nr_counter_cpu_fds * sizeof(struct lttng_ust_abi_object_data *));
                ret = -1;
                goto error_counter_cpus_alloc;
        }
This page took 0.033917 seconds and 4 git commands to generate.