Warn the user when the log level option is used when the kernel domain
is selected. Also, don't show the log level in the confirmation message
when kernel events are selected.
Fixes Bug #645
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
ret = CMD_ERROR;
goto error;
}
ret = CMD_ERROR;
goto error;
}
+ if (opt_loglevel) {
+ WARN("Kernel loglevels are not supported.");
+ }
}
/* Create lttng domain */
}
/* Create lttng domain */
switch (opt_event_type) {
case LTTNG_EVENT_TRACEPOINT:
switch (opt_event_type) {
case LTTNG_EVENT_TRACEPOINT:
+ if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) {
MSG("All %s tracepoints are enabled in channel %s for loglevel %s",
get_domain_str(dom.type),
print_channel_name(channel_name),
MSG("All %s tracepoints are enabled in channel %s for loglevel %s",
get_domain_str(dom.type),
print_channel_name(channel_name),
MSG("All %s tracepoints are enabled in channel %s",
get_domain_str(dom.type),
print_channel_name(channel_name));
MSG("All %s tracepoints are enabled in channel %s",
get_domain_str(dom.type),
print_channel_name(channel_name));
}
break;
case LTTNG_EVENT_SYSCALL:
}
break;
case LTTNG_EVENT_SYSCALL:
}
break;
case LTTNG_EVENT_ALL:
}
break;
case LTTNG_EVENT_ALL:
+ if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) {
MSG("All %s events are enabled in channel %s for loglevel %s",
get_domain_str(dom.type),
print_channel_name(channel_name),
MSG("All %s events are enabled in channel %s for loglevel %s",
get_domain_str(dom.type),
print_channel_name(channel_name),
- if (opt_loglevel) {
- MSG("Kernel loglevels are not supported.");
- ret = CMD_UNSUPPORTED;
- goto error;
- }
-
/* kernel loglevels not implemented */
ev.loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;
} else if (opt_userspace) { /* User-space tracer action */
/* kernel loglevels not implemented */
ev.loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;
} else if (opt_userspace) { /* User-space tracer action */